From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFCBCC433DF for ; Fri, 26 Jun 2020 22:36:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 92E8820C09 for ; Fri, 26 Jun 2020 22:36:52 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MmWG9oMG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 92E8820C09 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 256076B005C; Fri, 26 Jun 2020 18:36:52 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E5C66B005A; Fri, 26 Jun 2020 18:36:52 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 058426B0055; Fri, 26 Jun 2020 18:36:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0071.hostedemail.com [216.40.44.71]) by kanga.kvack.org (Postfix) with ESMTP id DF6CD6B0033 for ; Fri, 26 Jun 2020 18:36:51 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id A56AB2C84 for ; Fri, 26 Jun 2020 22:36:51 +0000 (UTC) X-FDA: 76972824222.13.swing39_620c91826e59 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id 7776C18140B67 for ; Fri, 26 Jun 2020 22:36:51 +0000 (UTC) X-HE-Tag: swing39_620c91826e59 X-Filterd-Recvd-Size: 8578 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.61]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Fri, 26 Jun 2020 22:36:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1593211010; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dcV8UWlWsC1eML+Y6HmJxR2Cl1DnigkEWgcHrN025RQ=; b=MmWG9oMGz+x4u2HLM4blZWfN2gjCAyuDgNvQrWGlokw6MHh811TLWUe7FS0nb8Y3NAteQX 0Qnl6o30BGiVxx5EQsZaL9yHg1Y67NetrK8cPpWr5l8I4itW7O3pDvlUhsU0TcC2Ex9BIU L8tlLChli5CGkNGfP93o/1xUEbdGC1Q= Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-246-o6LZj-EwPzq9QPMVzVZFxA-1; Fri, 26 Jun 2020 18:36:48 -0400 X-MC-Unique: o6LZj-EwPzq9QPMVzVZFxA-1 Received: by mail-qt1-f200.google.com with SMTP id c5so7516581qtv.20 for ; Fri, 26 Jun 2020 15:36:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=dcV8UWlWsC1eML+Y6HmJxR2Cl1DnigkEWgcHrN025RQ=; b=BFAJJBFWSMj8VeNo6+rw/FyoRDD9zsh6Qq9N7jDnl/xNNqgMdE/QDexlCp/DdKHJup GUbXCxHsybCfWZKmv5qc+8Ejukio2pF0XzKsFJU652DmqiU5xABNrxK1LPI2Y8wr1GXR lYR0HPQdfberFvP5BoAo+ptsUyskOc9b6l/RvNoHaKqysSYEJKU+DoClyRNVl8fo5Kmj yjmYelh6QRAjGy8VuPLsNPzsdZGjNlALZ1lTFhOnKmWn+CQsSh1EPWM64UttTAKu03NK 1wRwkrb5OxnW2oRC+2c7QhzstltEgUV3Q+JTsTItWgwCWYpCWYDFcCdfgjilKfwp6Qaw XFug== X-Gm-Message-State: AOAM532PzWyadFZ//YrlgmUcS06b/ZEgdD3wB1b3xMOlU+i31Kb5JlYm Ii8NcTd9dgjFw0wJ0ouyaTZrTpMyW7WMqqPNi6aXfsefPiMk+bD0Qih7KPKqcyaVlAVNBUpxp3l vd82MHItOdsA= X-Received: by 2002:ac8:7587:: with SMTP id s7mr5192326qtq.304.1593211007866; Fri, 26 Jun 2020 15:36:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx3dZZkXEut2YSkcj9Z923IX4G8sGFHFjPc5JlN6ewxXiJbeYgWJTu7LB7Nc6uW9BidINIy7w== X-Received: by 2002:ac8:7587:: with SMTP id s7mr5192304qtq.304.1593211007603; Fri, 26 Jun 2020 15:36:47 -0700 (PDT) Received: from xz-x1.redhat.com ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id r76sm8832654qka.30.2020.06.26.15.36.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jun 2020 15:36:47 -0700 (PDT) From: Peter Xu To: linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: Peter Xu , Andrew Morton , Linus Torvalds , Gerald Schaefer , Andrea Arcangeli , Will Deacon , Michael Ellerman Subject: [PATCH 25/26] mm: Clean up the last pieces of page fault accountings Date: Fri, 26 Jun 2020 18:36:45 -0400 Message-Id: <20200626223645.200199-1-peterx@redhat.com> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200626223130.199227-1-peterx@redhat.com> References: <20200626223130.199227-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Rspamd-Queue-Id: 7776C18140B67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Here're the last pieces of page fault accounting that were still done out= side handle_mm_fault() where we still have regs=3D=3DNULL when calling handle_= mm_fault(): arch/powerpc/mm/copro_fault.c: copro_handle_mm_fault arch/sparc/mm/fault_32.c: force_user_fault arch/um/kernel/trap.c: handle_page_fault mm/gup.c: faultin_page fixup_user_fault mm/hmm.c: hmm_vma_fault mm/ksm.c: break_ksm Some of them has the issue of duplicated accounting for page fault retrie= s. Some of them didn't do the accounting at all. This patch cleans all these up by letting handle_mm_fault() to do per-tas= k page fault accounting even if regs=3D=3DNULL (though we'll still skip the perf= event accountings). With that, we can safely remove all the outliers now. There's another functional change in that now we account the page faults = to the caller of gup, rather than the task_struct that passed into the gup code.= More information of this can be found at [1]. After this patch, below things should never be touched again outside handle_mm_fault(): - task_struct.[maj|min]_flt - PERF_COUNT_SW_PAGE_FAULTS_[MAJ|MIN] [1] https://lore.kernel.org/lkml/CAHk-=3Dwj_V2Tps2QrMn20_W0OJF9xqNh52XSGA= 42s-ZJ8Y+GyKw@mail.gmail.com/ Signed-off-by: Peter Xu --- arch/powerpc/mm/copro_fault.c | 5 ----- arch/um/kernel/trap.c | 4 ---- mm/gup.c | 13 ------------- mm/memory.c | 19 ++++++++++++------- 4 files changed, 12 insertions(+), 29 deletions(-) diff --git a/arch/powerpc/mm/copro_fault.c b/arch/powerpc/mm/copro_fault.= c index c0478bef1f14..2e59be1a9359 100644 --- a/arch/powerpc/mm/copro_fault.c +++ b/arch/powerpc/mm/copro_fault.c @@ -76,11 +76,6 @@ int copro_handle_mm_fault(struct mm_struct *mm, unsign= ed long ea, BUG(); } =20 - if (*flt & VM_FAULT_MAJOR) - current->maj_flt++; - else - current->min_flt++; - out_unlock: up_read(&mm->mmap_sem); return ret; diff --git a/arch/um/kernel/trap.c b/arch/um/kernel/trap.c index 32cc8f59322b..c881831de357 100644 --- a/arch/um/kernel/trap.c +++ b/arch/um/kernel/trap.c @@ -92,10 +92,6 @@ int handle_page_fault(unsigned long address, unsigned = long ip, BUG(); } if (flags & FAULT_FLAG_ALLOW_RETRY) { - if (fault & VM_FAULT_MAJOR) - current->maj_flt++; - else - current->min_flt++; if (fault & VM_FAULT_RETRY) { flags |=3D FAULT_FLAG_TRIED; =20 diff --git a/mm/gup.c b/mm/gup.c index 1a48c639ea49..17b4d0c45a6b 100644 --- a/mm/gup.c +++ b/mm/gup.c @@ -885,13 +885,6 @@ static int faultin_page(struct task_struct *tsk, str= uct vm_area_struct *vma, BUG(); } =20 - if (tsk) { - if (ret & VM_FAULT_MAJOR) - tsk->maj_flt++; - else - tsk->min_flt++; - } - if (ret & VM_FAULT_RETRY) { if (locked && !(fault_flags & FAULT_FLAG_RETRY_NOWAIT)) *locked =3D 0; @@ -1239,12 +1232,6 @@ int fixup_user_fault(struct task_struct *tsk, stru= ct mm_struct *mm, goto retry; } =20 - if (tsk) { - if (major) - tsk->maj_flt++; - else - tsk->min_flt++; - } return 0; } EXPORT_SYMBOL_GPL(fixup_user_fault); diff --git a/mm/memory.c b/mm/memory.c index 4a9b333b079e..0b3c747cd2b3 100644 --- a/mm/memory.c +++ b/mm/memory.c @@ -4350,6 +4350,8 @@ static vm_fault_t __handle_mm_fault(struct vm_area_= struct *vma, /** * mm_account_fault - Do page fault accountings * @regs: the pt_regs struct pointer. When set to NULL, will skip accou= nting + * of perf event counters, but we'll still do the per-task accoun= ting to + * the task who triggered this page fault. * @address: faulted address. * @major: whether this is a major fault. * @@ -4365,16 +4367,18 @@ static vm_fault_t __handle_mm_fault(struct vm_are= a_struct *vma, static inline void mm_account_fault(struct pt_regs *regs, unsigned long address, bool major) { + if (major) + current->maj_flt++; + else + current->min_flt++; + if (!regs) return; =20 - if (major) { - current->maj_flt++; + if (major) perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MAJ, 1, regs, address); - } else { - current->min_flt++; + else perf_sw_event(PERF_COUNT_SW_PAGE_FAULTS_MIN, 1, regs, address); - } } =20 /* @@ -4447,8 +4451,9 @@ vm_fault_t handle_mm_fault(struct vm_area_struct *v= ma, unsigned long address, * fault is VM_FAULT_MAJOR, or if it was a retry (which implies that * we couldn't handle it immediately previously). * - * - If the fault is done for GUP, regs will be NULL and no accounting - * will be done. + * - If the fault is done for GUP, regs will be NULL and we only do + * the accounting for the per thread fault counters who triggered + * the fault, and we skip the perf event updates. */ mm_account_fault(regs, address, (ret & VM_FAULT_MAJOR) || (flags & FAULT_FLAG_TRIED)); --=20 2.26.2