From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9EB7BC433E1 for ; Fri, 26 Jun 2020 11:17:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7B60520E65 for ; Fri, 26 Jun 2020 11:17:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B60520E65 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DB3E86B0003; Fri, 26 Jun 2020 07:17:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D63476B0005; Fri, 26 Jun 2020 07:17:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C79FE6B000A; Fri, 26 Jun 2020 07:17:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0211.hostedemail.com [216.40.44.211]) by kanga.kvack.org (Postfix) with ESMTP id B143C6B0003 for ; Fri, 26 Jun 2020 07:17:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 66B5A2C89 for ; Fri, 26 Jun 2020 11:17:16 +0000 (UTC) X-FDA: 76971111672.07.time24_0f183f226e55 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 32D291803F9B2 for ; Fri, 26 Jun 2020 11:17:16 +0000 (UTC) X-HE-Tag: time24_0f183f226e55 X-Filterd-Recvd-Size: 1407 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf18.hostedemail.com (Postfix) with ESMTP for ; Fri, 26 Jun 2020 11:17:15 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 9D8EFAC7A; Fri, 26 Jun 2020 11:17:13 +0000 (UTC) Date: Fri, 26 Jun 2020 13:17:11 +0200 From: Joerg Roedel To: Peter Zijlstra Cc: Joerg Roedel , x86@kernel.org, hpa@zytor.com, Dave Hansen , Andy Lutomirski , Andrew Morton , Steven Rostedt , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH] x86/mm: Pre-allocate p4d/pud pages for vmalloc area Message-ID: <20200626111711.GO14101@suse.de> References: <20200626093450.27741-1-joro@8bytes.org> <20200626110731.GC4817@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626110731.GC4817@hirez.programming.kicks-ass.net> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 32D291803F9B2 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 26, 2020 at 01:07:31PM +0200, Peter Zijlstra wrote: > Can't we now remove arch_sync_kernel_mappings() from this same file? Only if we panic on allocation failure. Joerg