From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C25E6C433DF for ; Fri, 26 Jun 2020 07:20:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 26D7D2076E for ; Fri, 26 Jun 2020 07:20:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 26D7D2076E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B25236B0006; Fri, 26 Jun 2020 03:20:47 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id AD5F66B0007; Fri, 26 Jun 2020 03:20:47 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9EB7E6B0008; Fri, 26 Jun 2020 03:20:47 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0229.hostedemail.com [216.40.44.229]) by kanga.kvack.org (Postfix) with ESMTP id 86F0D6B0006 for ; Fri, 26 Jun 2020 03:20:47 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3483E2DFA for ; Fri, 26 Jun 2020 07:20:47 +0000 (UTC) X-FDA: 76970515734.24.tooth10_4d16da226e53 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 103FA1A4A0 for ; Fri, 26 Jun 2020 07:20:47 +0000 (UTC) X-HE-Tag: tooth10_4d16da226e53 X-Filterd-Recvd-Size: 2339 Received: from fornost.hmeau.com (helcar.hmeau.com [216.24.177.18]) by imf38.hostedemail.com (Postfix) with ESMTP for ; Fri, 26 Jun 2020 07:20:46 +0000 (UTC) Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1joiex-0005M6-Hl; Fri, 26 Jun 2020 17:20:28 +1000 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Fri, 26 Jun 2020 17:20:27 +1000 Date: Fri, 26 Jun 2020 17:20:27 +1000 From: Herbert Xu To: Barry Song Cc: akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linuxarm@huawei.com, "Luis Claudio R . Goncalves" , Sebastian Andrzej Siewior , "David S . Miller" , Mahipal Challa , Seth Jennings , Dan Streetman , Vitaly Wool , Zhou Wang , Colin Ian King Subject: Re: [PATCH v3] mm/zswap: move to use crypto_acomp API for hardware acceleration Message-ID: <20200626072027.GA6153@gondor.apana.org.au> References: <20200626070903.27988-1-song.bao.hua@hisilicon.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200626070903.27988-1-song.bao.hua@hisilicon.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 103FA1A4A0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 26, 2020 at 07:09:03PM +1200, Barry Song wrote: > > + mutex_lock(&acomp_ctx->mutex); > + > + src = kmap(page); > + dst = acomp_ctx->dstmem; > + sg_init_one(&input, src, PAGE_SIZE); > + /* zswap_dstmem is of size (PAGE_SIZE * 2). Reflect same in sg_list */ > + sg_init_one(&output, dst, PAGE_SIZE * 2); > + acomp_request_set_params(acomp_ctx->req, &input, &output, PAGE_SIZE, dlen); > + ret = crypto_wait_req(crypto_acomp_compress(acomp_ctx->req), &acomp_ctx->wait); > + dlen = acomp_ctx->req->dlen; > + kunmap(page); Waiting on an async request like this is just silly. This defeats the whole purpose of having a fallback. Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt