From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4AF7FC433DF for ; Wed, 24 Jun 2020 20:07:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1F0042081A for ; Wed, 24 Jun 2020 20:07:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1F0042081A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8721D6B0010; Wed, 24 Jun 2020 16:07:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 823816B0022; Wed, 24 Jun 2020 16:07:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 713CF6B0023; Wed, 24 Jun 2020 16:07:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0002.hostedemail.com [216.40.44.2]) by kanga.kvack.org (Postfix) with ESMTP id 5C0656B0010 for ; Wed, 24 Jun 2020 16:07:54 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 1DD4F2DFC for ; Wed, 24 Jun 2020 20:07:54 +0000 (UTC) X-FDA: 76965191268.27.able83_0610b4a26e46 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id DD77B3D663 for ; Wed, 24 Jun 2020 20:07:53 +0000 (UTC) X-HE-Tag: able83_0610b4a26e46 X-Filterd-Recvd-Size: 5027 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 24 Jun 2020 20:07:53 +0000 (UTC) Received: by mail-wm1-f66.google.com with SMTP id a6so5221970wmm.0 for ; Wed, 24 Jun 2020 13:07:53 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=zn5H85cQV046jV3P3ggqci4wKXa88ITUcHIq4Namnmw=; b=Yidz3+oHFGQE9qF+5Mh1T8bTB+i6ElA7B/5gb2NDAGzmvtxdyGYux3GvWfFeMZ8RCZ PqGkZ5+auY+NVF1FH5mnKpmaF6xSKM0MxHT+mF1+naUBSswuxWCG6FyGJ/0oO0Z+aRxy vKMU+AmHfqX3N4mvef0n0CUGHVl88wjg4rd3BgwEFkmHKI2orU8z4mxPi2gqtbik3YaY kvTOBHg3PX1bk1g/iLsMRo4/MvwiB2iv16IMK5ZG27fU04ugvGdbykVavxs1/HE7OQk2 M1ld7KsRhKVfZq6YqFyWH4cOTux2FYuWMfi61BZMQJRSZLBlngFLNZl1r8nUahbj+5EE EHlw== X-Gm-Message-State: AOAM532sI1x5/X+0NVaz9ga2rkCzzqPGZaUtaUCemu5f+jSsfdvgMAHL N5KDY1lIWDoCB9u8IOdF9Jg= X-Google-Smtp-Source: ABdhPJwr1VPpzP8Gp/Rb+eJdNGBMXtHkdfBgz9FKMHSGQEcD4Z8LF6StyZfKxXHDBxgVQmEFARxA9Q== X-Received: by 2002:a1c:9613:: with SMTP id y19mr30634312wmd.135.1593029272410; Wed, 24 Jun 2020 13:07:52 -0700 (PDT) Received: from localhost (ip-37-188-168-3.eurotel.cz. [37.188.168.3]) by smtp.gmail.com with ESMTPSA id f16sm9565775wmh.27.2020.06.24.13.07.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 13:07:51 -0700 (PDT) Date: Wed, 24 Jun 2020 22:07:50 +0200 From: Michal Hocko To: Ben Widawsky Cc: linux-mm , Andi Kleen , Andrew Morton , Christoph Lameter , Dan Williams , Dave Hansen , David Hildenbrand , David Rientjes , Jason Gunthorpe , Johannes Weiner , Jonathan Corbet , Kuppuswamy Sathyanarayanan , Lee Schermerhorn , Li Xinhai , Mel Gorman , Mike Kravetz , Mina Almasry , Tejun Heo , Vlastimil Babka , linux-api@vger.kernel.org Subject: Re: [PATCH 00/18] multiple preferred nodes Message-ID: <20200624200750.GY1320@dhcp22.suse.cz> References: <20200619162425.1052382-1-ben.widawsky@intel.com> <20200622070957.GB31426@dhcp22.suse.cz> <20200623112048.GR31426@dhcp22.suse.cz> <20200623161211.qjup5km5eiisy5wy@intel.com> <20200624075216.GC1320@dhcp22.suse.cz> <20200624161643.75fkkvsxlmp3bf2e@intel.com> <20200624183917.GW1320@dhcp22.suse.cz> <20200624193733.tqeligjd3pdvrsmi@intel.com> <20200624195158.GX1320@dhcp22.suse.cz> <20200624200140.dypw6snshshzlbwa@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624200140.dypw6snshshzlbwa@intel.com> X-Rspamd-Queue-Id: DD77B3D663 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed 24-06-20 13:01:40, Ben Widawsky wrote: > On 20-06-24 21:51:58, Michal Hocko wrote: > > On Wed 24-06-20 12:37:33, Ben Widawsky wrote: > > > On 20-06-24 20:39:17, Michal Hocko wrote: > > > > On Wed 24-06-20 09:16:43, Ben Widawsky wrote: [...] > > > > > > Or do I miss something that really requires more involved approach like > > > > > > building custom zonelists and other larger changes to the allocator? > > > > > > > > > > I think I'm missing how this allows selecting from multiple preferred nodes. In > > > > > this case when you try to get the page from the freelist, you'll get the > > > > > zonelist of the preferred node, and when you actually scan through on page > > > > > allocation, you have no way to filter out the non-preferred nodes. I think the > > > > > plumbing of multiple nodes has to go all the way through > > > > > __alloc_pages_nodemask(). But it's possible I've missed the point. > > > > > > > > policy_nodemask() will provide the nodemask which will be used as a > > > > filter on the policy_node. > > > > > > Ah, gotcha. Enabling independent masks seemed useful. Some bad decisions got me > > > to that point. UAPI cannot get independent masks, and callers of these functions > > > don't yet use them. > > > > > > So let me ask before I actually type it up and find it's much much simpler, is > > > there not some perceived benefit to having both masks being independent? > > > > I am not sure I follow. Which two masks do you have in mind? zonelist > > and user provided nodemask? > > Internally, a nodemask_t for preferred node, and a nodemask_t for bound nodes. Each mask is a local to its policy object. -- Michal Hocko SUSE Labs