From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 73CF8C433DF for ; Wed, 24 Jun 2020 22:49:51 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2D57220738 for ; Wed, 24 Jun 2020 22:49:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tyqEQyYn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2D57220738 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B43D16B0005; Wed, 24 Jun 2020 18:49:50 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B1B046B0007; Wed, 24 Jun 2020 18:49:50 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A589D6B0008; Wed, 24 Jun 2020 18:49:50 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0226.hostedemail.com [216.40.44.226]) by kanga.kvack.org (Postfix) with ESMTP id 8E7EA6B0005 for ; Wed, 24 Jun 2020 18:49:50 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1FF651EE6 for ; Wed, 24 Jun 2020 22:49:50 +0000 (UTC) X-FDA: 76965599340.25.hill72_2b01a8526e47 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin25.hostedemail.com (Postfix) with ESMTP id DD8631804E3A8 for ; Wed, 24 Jun 2020 22:49:49 +0000 (UTC) X-HE-Tag: hill72_2b01a8526e47 X-Filterd-Recvd-Size: 5034 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Wed, 24 Jun 2020 22:49:49 +0000 (UTC) Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 45BE92065D; Wed, 24 Jun 2020 22:49:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593038988; bh=+Xiia5lz5jMxPkcFiSIcy2n0z1B9hfXtGE0im/2wmaI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tyqEQyYnCLpAXNAjThece3itLPMPam/8cGEiE9U1sggON915fah27trGQB5tulRRK T33Ra4e4yfl3IjKj3fYmxzC/HvLZmbLCcMxk1pZ/pnGC0169/YA7zcuM8ptR3Vbiw7 JerXELY9gmukeBuv6Rfq9DEfEVIhgShZYKoJYXWY= Date: Wed, 24 Jun 2020 15:49:47 -0700 From: Andrew Morton To: HORIGUCHI =?UTF-8?B?TkFPWUE=?=(=?UTF-8?B?5aCA5Y+j44CA55u05Lmf?=) Cc: "nao.horiguchi@gmail.com" , "linux-mm@kvack.org" , "mhocko@kernel.org" , "mike.kravetz@oracle.com" , "osalvador@suse.de" , "tony.luck@intel.com" , "david@redhat.com" , "aneesh.kumar@linux.vnet.ibm.com" , "zeil@yandex-team.ru" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v3 00/15] HWPOISON: soft offline rework Message-Id: <20200624154947.2f41c426d4b83fb9241d8584@linux-foundation.org> In-Reply-To: <20200624223618.GA13133@hori.linux.bs1.fc.nec.co.jp> References: <20200624150137.7052-1-nao.horiguchi@gmail.com> <20200624121742.711331a2a65633a0e16fd9e6@linux-foundation.org> <20200624223618.GA13133@hori.linux.bs1.fc.nec.co.jp> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 X-Rspamd-Queue-Id: DD8631804E3A8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 24 Jun 2020 22:36:18 +0000 HORIGUCHI NAOYA(=E5=A0=80=E5=8F=A3=E3=80= =80=E7=9B=B4=E4=B9=9F) wrote: > On Wed, Jun 24, 2020 at 12:17:42PM -0700, Andrew Morton wrote: > > On Wed, 24 Jun 2020 15:01:22 +0000 nao.horiguchi@gmail.com wrote: > >=20 > > > I rebased soft-offline rework patchset [1][2] onto the latest mmotm= . The > > > rebasing required some non-trivial changes to adjust, but mainly th= at was > > > straightforward. I confirmed that the reported problem doesn't rep= roduce on > > > compaction after soft offline. For more precise description of the= problem > > > and the motivation of this patchset, please see [2]. > > >=20 > > > I think that the following two patches in v2 are better to be done = with > > > separate work of hard-offline rework, so it's not included in this = series. > > >=20 > > > - mm,hwpoison: Take pages off the buddy when hard-offlining > > > - mm/hwpoison-inject: Rip off duplicated checks > > >=20 > > > These two are not directly related to the reported problem, so they= seems > > > not urgent. And the first one breaks num_poisoned_pages counting i= n some > > > testcases, and The second patch needs more consideration about comm= ented point. > > >=20 > >=20 > > It would be nice to have some sort of overview of the patch series in > > this [0/n] email. > >=20 > > > [1] v1: https://lore.kernel.org/linux-mm/1541746035-13408-1-git-sen= d-email-n-horiguchi@ah.jp.nec.com/ > > > [2] v2: https://lore.kernel.org/linux-mm/20191017142123.24245-1-osa= lvador@suse.de/ > >=20 > > The above have such, but are they up to date? >=20 > The description of the problem doesn't change, but there're some new pa= tches > and some patches are postponed, so I should've added an overview of thi= s series: >=20 > - patch 1, 2 are cleanups. > - patch 3, 4, 5 change the precondition when calling memory_failure(). = Previously > we sometimes call it with holding refcount of the target page and som= times call > without holding it, and we passed a flag of whether refcount was take= n out of > memory_failure(). It was confusing and caused code more complex than= needed. > - patch 6-10 are cleanups. > - patch 11 introduces new logic to remove the error page from buddy all= ocator, > which is also applied to the path of soft-offling in-use pages in pat= ch 12. > - patch 13 is basically a refactoring but I added some adjustment to ma= ke sure > that the freed page is surely sent back to buddy instead of being kep= t in pcplist, > which is based on discussion in v2. > - patch 14 fixes the inconsistency of return values between injection i= nterfaces. > - patch 15 is a new patch to complement missing code found in code revi= ew for > previous version. >=20 > Core change is in patch 11 and 12, and the others are kind of cleanup/r= efactoring. And all the other words in https://lore.kernel.org/linux-mm/1541746035-13408-1-git-send-email-n-hori= guchi@ah.jp.nec.com/ are still accurate and complete?