From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06FCBC433DF for ; Wed, 24 Jun 2020 14:29:29 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BAAAB2072E for ; Wed, 24 Jun 2020 14:29:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="fTHXbrpC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BAAAB2072E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4AB2B6B0006; Wed, 24 Jun 2020 10:29:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 434A96B0007; Wed, 24 Jun 2020 10:29:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2FAC16B0008; Wed, 24 Jun 2020 10:29:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id 14D4A6B0006 for ; Wed, 24 Jun 2020 10:29:28 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id BF4D4AF9A for ; Wed, 24 Jun 2020 14:29:27 +0000 (UTC) X-FDA: 76964338374.16.ring73_5609b2f26e44 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id 2D7FE1004F72B for ; Wed, 24 Jun 2020 14:27:48 +0000 (UTC) X-HE-Tag: ring73_5609b2f26e44 X-Filterd-Recvd-Size: 2210 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf14.hostedemail.com (Postfix) with ESMTP for ; Wed, 24 Jun 2020 14:27:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=B/J/FyLP/cMIITemkspmNPRPSrnTgO5+iMCk+rIrMjM=; b=fTHXbrpCNIaXRmGIlFIzloHQWu BefmN2QQ0pisXXhOvnyQ6qCVkwZyhiaNPwpapudqETMZ0aGNFS538bNGR0AdHhKkeSZ9hvexmFbY4 VyuOkBd+g8RJ+SQ/JDXH1dvjileLyG8oox+d3kYjVNF9CWK5fv9ZY7UuogIAk+l0EXe22836Eqtkc hihNt12XrBJIe6cS2SkYL9IObIRQLhT1dkuKyXJvHbxTQlu9pSdWK0huV+WIxBhEx90g4gBi5uOp7 y1A/WINxN+h1XIqcC7uuYH6xnrbF9hd2egil1WG3mcF1VHslWgnoNufND0LlhHTH1X6uXlyZGz7lQ F2dZvMnQ==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jo6NI-0000qG-El; Wed, 24 Jun 2020 14:27:40 +0000 Date: Wed, 24 Jun 2020 15:27:40 +0100 From: Matthew Wilcox To: Rafael Aquini Cc: Joel Savitz , linux-kernel@vger.kernel.org, Vlastimil Babka , John Hubbard , Andrew Morton , linux-mm@kvack.org Subject: Re: [PATCH] mm/page_alloc: fix documentation error and remove magic numbers Message-ID: <20200624142740.GO21350@casper.infradead.org> References: <20200624032712.23263-1-jsavitz@redhat.com> <20200624111255.GL21350@casper.infradead.org> <20200624140727.GA1987277@optiplex-lnx> <20200624140958.GN21350@casper.infradead.org> <20200624142626.GB1987277@optiplex-lnx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200624142626.GB1987277@optiplex-lnx> X-Rspamd-Queue-Id: 2D7FE1004F72B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.002944, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 24, 2020 at 10:26:26AM -0400, Rafael Aquini wrote: > Joel's approach, however, makes sense if you consider it's generally a > good practice to get rid of the unnamed magic numbers anti-pattern. But I don't. I care about how easy it is to understand the code, not conforming to some bullshit trendy word salad.