From: Matthew Wilcox <willy@infradead.org>
To: Rafael Aquini <aquini@redhat.com>
Cc: Joel Savitz <jsavitz@redhat.com>,
linux-kernel@vger.kernel.org, Vlastimil Babka <vbabka@suse.cz>,
John Hubbard <jhubbard@nvidia.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org
Subject: Re: [PATCH] mm/page_alloc: fix documentation error and remove magic numbers
Date: Wed, 24 Jun 2020 15:27:40 +0100 [thread overview]
Message-ID: <20200624142740.GO21350@casper.infradead.org> (raw)
In-Reply-To: <20200624142626.GB1987277@optiplex-lnx>
On Wed, Jun 24, 2020 at 10:26:26AM -0400, Rafael Aquini wrote:
> Joel's approach, however, makes sense if you consider it's generally a
> good practice to get rid of the unnamed magic numbers anti-pattern.
But I don't. I care about how easy it is to understand the code, not
conforming to some bullshit trendy word salad.
prev parent reply other threads:[~2020-06-24 14:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 3:27 Joel Savitz
2020-06-24 11:12 ` Matthew Wilcox
2020-06-24 14:07 ` Rafael Aquini
2020-06-24 14:09 ` Matthew Wilcox
2020-06-24 14:26 ` Rafael Aquini
2020-06-24 14:27 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200624142740.GO21350@casper.infradead.org \
--to=willy@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aquini@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=jsavitz@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox