From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F4E0C433E1 for ; Wed, 24 Jun 2020 18:53:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D3D822082F for ; Wed, 24 Jun 2020 18:53:20 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HlnPOjet" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D3D822082F Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5D03E6B002E; Wed, 24 Jun 2020 14:53:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 581056B002F; Wed, 24 Jun 2020 14:53:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 46F1C6B0036; Wed, 24 Jun 2020 14:53:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0108.hostedemail.com [216.40.44.108]) by kanga.kvack.org (Postfix) with ESMTP id 2F9716B002E for ; Wed, 24 Jun 2020 14:53:20 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B722C180AD81D for ; Wed, 24 Jun 2020 18:53:19 +0000 (UTC) X-FDA: 76965003318.10.line70_0d1054e26e46 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 9023E169F9A for ; Wed, 24 Jun 2020 18:53:19 +0000 (UTC) X-HE-Tag: line70_0d1054e26e46 X-Filterd-Recvd-Size: 3076 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Wed, 24 Jun 2020 18:53:19 +0000 (UTC) Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 22FA520823; Wed, 24 Jun 2020 18:53:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593024798; bh=HKslfhNl7tpZaCgmctNjhn1V/l+XNf4uwEwavirR290=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=HlnPOjetBcFqHdrq8LMZASzOmK8BPv6UmpdDbgMfkmZtg+ksWMcnQ5XEcWc7fnBRG bt/Qk+sTWwmhAjgam/0aNcgNVhbN7y2g8QIUyqCK2AHUu/Xel7zJ5oPEexSEc/9hpY WbHIcirhJNSFY2E02EGTcBZl2CyWIC39PCD6y3f0= Date: Wed, 24 Jun 2020 11:53:17 -0700 From: Andrew Morton To: Yang Shi Cc: hannes@cmpxchg.org, riel@surriel.com, shakeelb@google.com, gavin.dg@linux.alibaba.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: filemap: clear idle flag for writes Message-Id: <20200624115317.792d8fc6369d421d2898ab2f@linux-foundation.org> In-Reply-To: <1593020612-13051-1-git-send-email-yang.shi@linux.alibaba.com> References: <1593020612-13051-1-git-send-email-yang.shi@linux.alibaba.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9023E169F9A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 25 Jun 2020 01:43:32 +0800 Yang Shi wrote: > Since commit bbddabe2e436aa7869b3ac5248df5c14ddde0cbf ("mm: filemap: > only do access activations on reads"), mark_page_accessed() is called > for reads only. But the idle flag is cleared by mark_page_accessed() so > the idle flag won't get cleared if the page is write accessed only. > > Basically idle page tracking is used to estimate workingset size of > workload, noticeable size of workingset might be missed if the idle flag > is not maintained correctly. > > It seems good enough to just clear idle flag for write operations. > > ... > > --- a/mm/filemap.c > +++ b/mm/filemap.c > @@ -41,6 +41,7 @@ > #include > #include > #include > +#include > #include "internal.h" > > #define CREATE_TRACE_POINTS > @@ -1630,6 +1631,11 @@ struct page *pagecache_get_page(struct address_space *mapping, pgoff_t index, > > if (fgp_flags & FGP_ACCESSED) > mark_page_accessed(page); > + else if (fgp_flags & FGP_WRITE) { > + /* Clear idle flag for buffer write */ > + if (page_is_idle(page)) > + clear_page_idle(page); > + } > > no_page: > if (!page && (fgp_flags & FGP_CREAT)) { The kerneldoc comment for pagecache_get_page() could do with some updating - it fails to mention FGP_WRITE, FGP_NOFS and FGP_NOWAIT. This change seems correct but also will have runtime effects. What are they?