From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EBC7C433E0 for ; Wed, 24 Jun 2020 18:36:15 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5445E20767 for ; Wed, 24 Jun 2020 18:36:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="FIZjTg4x" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5445E20767 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id CDAD86B002A; Wed, 24 Jun 2020 14:36:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C67546B002B; Wed, 24 Jun 2020 14:36:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B2C2B6B002D; Wed, 24 Jun 2020 14:36:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0064.hostedemail.com [216.40.44.64]) by kanga.kvack.org (Postfix) with ESMTP id 97BB36B002A for ; Wed, 24 Jun 2020 14:36:14 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 173552C78 for ; Wed, 24 Jun 2020 18:36:14 +0000 (UTC) X-FDA: 76964960268.07.chess30_3611b2826e46 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id D09111803F9A5 for ; Wed, 24 Jun 2020 18:36:13 +0000 (UTC) X-HE-Tag: chess30_3611b2826e46 X-Filterd-Recvd-Size: 3651 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf05.hostedemail.com (Postfix) with ESMTP for ; Wed, 24 Jun 2020 18:36:13 +0000 (UTC) Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5297720724; Wed, 24 Jun 2020 18:36:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1593023772; bh=zAbzYru4IJFdsh6i/w0jgIRKlV0+glNcrScr56cweUQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FIZjTg4xAP6gEpo+5IWjKs1ow+z2InHOF9UTIBNoPSzTzUfUFAIaiwUfJkpzYl+aO 6PtyELdCLPPtvzhPLRlyIOSj34pSKn6In4jxiceWXZcvDamteov8bkke9ulDMUnm9Y SIhx3UTboYA83kFYZHVSplO4gwHp8a2NZcgxIxc4= Date: Wed, 24 Jun 2020 11:36:11 -0700 From: Andrew Morton To: Catalin Marinas Cc: linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, Will Deacon , Dave P Martin , Vincenzo Frascino , Szabolcs Nagy , Kevin Brodsky , Andrey Konovalov , Peter Collingbourne , Kevin Brodsky Subject: Re: [PATCH v5 11/25] mm: Introduce arch_calc_vm_flag_bits() Message-Id: <20200624113611.2cf12da3a325d03a862c0adf@linux-foundation.org> In-Reply-To: <20200624175244.25837-12-catalin.marinas@arm.com> References: <20200624175244.25837-1-catalin.marinas@arm.com> <20200624175244.25837-12-catalin.marinas@arm.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: D09111803F9A5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 24 Jun 2020 18:52:30 +0100 Catalin Marinas wrote: > From: Kevin Brodsky > > Similarly to arch_calc_vm_prot_bits(), introduce a dummy > arch_calc_vm_flag_bits() invoked from calc_vm_flag_bits(). This macro > can be overridden by architectures to insert specific VM_* flags derived > from the mmap() MAP_* flags. > > ... > > --- a/include/linux/mman.h > +++ b/include/linux/mman.h > @@ -74,13 +74,17 @@ static inline void vm_unacct_memory(long pages) > } > > /* > - * Allow architectures to handle additional protection bits > + * Allow architectures to handle additional protection and flag bits > */ > > #ifndef arch_calc_vm_prot_bits > #define arch_calc_vm_prot_bits(prot, pkey) 0 > #endif > > +#ifndef arch_calc_vm_flag_bits > +#define arch_calc_vm_flag_bits(flags) 0 > +#endif It would be helpful to add a comment specifying which arch header file is responsible for defining arch_calc_vm_flag_bits. Because in the past we've messed this sort of thing up and had different architectures define things in different header files, resulting in build issues as code evolves. > #ifndef arch_vm_get_page_prot > #define arch_vm_get_page_prot(vm_flags) __pgprot(0) > #endif > @@ -131,7 +135,8 @@ calc_vm_flag_bits(unsigned long flags) > return _calc_vm_trans(flags, MAP_GROWSDOWN, VM_GROWSDOWN ) | > _calc_vm_trans(flags, MAP_DENYWRITE, VM_DENYWRITE ) | > _calc_vm_trans(flags, MAP_LOCKED, VM_LOCKED ) | > - _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ); > + _calc_vm_trans(flags, MAP_SYNC, VM_SYNC ) | > + arch_calc_vm_flag_bits(flags); > } > > unsigned long vm_commit_limit(void);