From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E044C433E0 for ; Mon, 22 Jun 2020 21:50:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C29DB2073E for ; Mon, 22 Jun 2020 21:50:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lnWs0M9b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C29DB2073E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 41E806B0006; Mon, 22 Jun 2020 17:50:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3AA696B0007; Mon, 22 Jun 2020 17:50:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 26F546B000C; Mon, 22 Jun 2020 17:50:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0240.hostedemail.com [216.40.44.240]) by kanga.kvack.org (Postfix) with ESMTP id 0954F6B0006 for ; Mon, 22 Jun 2020 17:50:13 -0400 (EDT) Received: from smtpin30.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 8626D8248047 for ; Mon, 22 Jun 2020 21:50:12 +0000 (UTC) X-FDA: 76958191464.30.voice69_411411c26e36 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin30.hostedemail.com (Postfix) with ESMTP id 5D97718457084 for ; Mon, 22 Jun 2020 21:50:12 +0000 (UTC) X-HE-Tag: voice69_411411c26e36 X-Filterd-Recvd-Size: 4385 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf19.hostedemail.com (Postfix) with ESMTP for ; Mon, 22 Jun 2020 21:50:11 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id 35so8182541ple.0 for ; Mon, 22 Jun 2020 14:50:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=HO9AnfyoV6P1ml9RmfpxKfaeSgxzWVOaT2Vq3vNBOcc=; b=lnWs0M9bdocVBBBLhw+yUPaupQsgnQNFCJK+pJiVmZ07vNw8nK3vhTqTM7fjRtPrmQ BeXp8Y3BLVYRrEviTgHIDqlkTfPgwxk6+SKhwBh0lYzJXifq+81hLQjHZHXlwvYE7D3Z 338rLHdodna0JLZ+58OXLxtuOD7htkoppjQHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=HO9AnfyoV6P1ml9RmfpxKfaeSgxzWVOaT2Vq3vNBOcc=; b=NPzF8HXid6k/6LRIHFGuuxjw+CPr1eJmtkhKz0hATmSDKoKTT3KMhmTkS9+6PEMIx6 uBiIKcOsEvLe1ZAgnFb7k9CxpdpJvYD3Nnghy7CXN3gF1p4LaP6nHjpUjISXzhXAE5uu 9CImwVx9CmrqBZCCnHy7kbl/yti9z3qModS8a98wP8u0Y2dBxqD21gzj9vh8GpLrUger 3WKmbDI6cHAuaQDHGt4xsBR2P19KrIUi8nElXhNEpv6+JyjbSLtoM3tpVf931qkWL6TU ZFc/Bh4DF98zkfE2cdOGIQ4Za95hNabKmKZU2VQwX+q7TvY5yjeJ2ze6DYS6x+4wFcku EHJw== X-Gm-Message-State: AOAM531qyte7WCBem1Lj6t/FjRSr/Xk5HmJsDghsRidD7uEcSO/9LSbu dmFk8u9eqXiTj+BzPZoRoipt1A== X-Google-Smtp-Source: ABdhPJxa5Z82Hov2tfdjL/FmMAkdOj7Sb3arynM+T3CBUgUa49ZBQBQv4Q5BIBd9XVoezZqa3CUsJQ== X-Received: by 2002:a17:90a:a405:: with SMTP id y5mr20189871pjp.15.1592862611014; Mon, 22 Jun 2020 14:50:11 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id p14sm428618pjf.32.2020.06.22.14.50.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 22 Jun 2020 14:50:09 -0700 (PDT) Date: Mon, 22 Jun 2020 14:50:08 -0700 From: Kees Cook To: Randy Dunlap Cc: akpm@linux-foundation.org, broonie@kernel.org, mhocko@suse.cz, sfr@canb.auug.org.au, linux-next@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, mm-commits@vger.kernel.org, "open list:KERNEL SELFTEST FRAMEWORK" Subject: Re: mmotm 2020-06-20-21-36 uploaded (lkdtm/bugs.c) Message-ID: <202006221445.36E03CCBE9@keescook> References: <20200621043737.pb6JV%akpm@linux-foundation.org> <20a39fd4-622d-693c-c8d6-1fbab12af62a@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20a39fd4-622d-693c-c8d6-1fbab12af62a@gmail.com> X-Rspamd-Queue-Id: 5D97718457084 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 22, 2020 at 08:37:17AM -0700, Randy Dunlap wrote: > On 6/20/20 9:37 PM, akpm@linux-foundation.org wrote: > > The mm-of-the-moment snapshot 2020-06-20-21-36 has been uploaded to > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > mmotm-readme.txt says > > > > README for mm-of-the-moment: > > > > http://www.ozlabs.org/~akpm/mmotm/ > > > > This is a snapshot of my -mm patch queue. Uploaded at random hopefully > > more than once a week. > > drivers/misc/lkdtm/bugs.c has build errors when building UML for i386 > (allmodconfig or allyesconfig): > > > In file included from ../drivers/misc/lkdtm/bugs.c:17:0: > ../arch/x86/um/asm/desc.h:7:0: warning: "LDT_empty" redefined > #define LDT_empty(info) (\ > > In file included from ../arch/um/include/asm/mmu.h:10:0, > from ../include/linux/mm_types.h:18, > from ../include/linux/sched/signal.h:13, > from ../drivers/misc/lkdtm/bugs.c:11: > ../arch/x86/um/asm/mm_context.h:65:0: note: this is the location of the previous definition > #define LDT_empty(info) (_LDT_empty(info)) The LKDTM test landed a while ago: b09511c253e5 ("lkdtm: Add a DOUBLE_FAULT crash type on x86") and nothing has touched arch/x86/um/asm/desc.h nor arch/x86/um/asm/mm_context.h in a while either. Regardless, it seems arch/x86/um/asm/desc.h is not needed any more? -- Kees Cook