From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48181C433E0 for ; Thu, 18 Jun 2020 23:38:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E4DFC20888 for ; Thu, 18 Jun 2020 23:38:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="HD4RqH/4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E4DFC20888 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 401518D0065; Thu, 18 Jun 2020 19:38:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E1DC8D0052; Thu, 18 Jun 2020 19:38:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2EDBA8D0065; Thu, 18 Jun 2020 19:38:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0007.hostedemail.com [216.40.44.7]) by kanga.kvack.org (Postfix) with ESMTP id 15EC88D0052 for ; Thu, 18 Jun 2020 19:38:13 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BC1DC18064487 for ; Thu, 18 Jun 2020 23:38:12 +0000 (UTC) X-FDA: 76943948424.03.plot65_1b06c1b26e14 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 8C28A30F582 for ; Thu, 18 Jun 2020 22:40:15 +0000 (UTC) X-HE-Tag: plot65_1b06c1b26e14 X-Filterd-Recvd-Size: 3128 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Jun 2020 22:40:15 +0000 (UTC) Received: from paulmck-ThinkPad-P72.home (50-39-105-78.bvtn.or.frontiernet.net [50.39.105.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70F67206F1; Thu, 18 Jun 2020 21:34:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592516067; bh=gCSQ8dORA8i8XQTpX08qSMBD4GVasZLFb37hDSiHIQE=; h=Date:From:To:Cc:Subject:Reply-To:References:In-Reply-To:From; b=HD4RqH/4WEqnIBTR6cJ3TtCcV0qRrlPsOa6mKKso4feoO1utjqAMvec/NHV2VCVBv pR4jkroccINaphqCV2+vIH4W+bLGz0hJViaeHTPhf/ULdzMKPau4SCNRL+8GGlK6Iu wuBvu/g4Xo1m+aCTPdoFrIKD1BgwLWU/6uoxL+5o= Received: by paulmck-ThinkPad-P72.home (Postfix, from userid 1000) id 58A03352264E; Thu, 18 Jun 2020 14:34:27 -0700 (PDT) Date: Thu, 18 Jun 2020 14:34:27 -0700 From: "Paul E. McKenney" To: Uladzislau Rezki Cc: Matthew Wilcox , LKML , linux-mm@kvack.org, Andrew Morton , "Theodore Y . Ts'o" , Joel Fernandes , RCU , Oleksiy Avramchenko Subject: Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs Message-ID: <20200618213427.GV2723@paulmck-ThinkPad-P72> Reply-To: paulmck@kernel.org References: <20200617234609.GA10087@paulmck-ThinkPad-P72> <20200618005214.GN8681@bombadil.infradead.org> <20200618031823.GQ2723@paulmck-ThinkPad-P72> <20200618173520.GC14613@pc636> <20200618175719.GT2723@paulmck-ThinkPad-P72> <20200618183448.GA15136@pc636> <20200618190359.GU2723@paulmck-ThinkPad-P72> <20200618203557.GB16976@pc636> <20200618203821.GU8681@bombadil.infradead.org> <20200618211709.GA17263@pc636> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618211709.GA17263@pc636> User-Agent: Mutt/1.9.4 (2018-02-28) X-Rspamd-Queue-Id: 8C28A30F582 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 18, 2020 at 11:17:09PM +0200, Uladzislau Rezki wrote: > > > > > > trace_rcu_invoke_kfree_bulk_callback( > > > rcu_state.name, bkvhead[i]->nr_records, > > > bkvhead[i]->records); > > > if (i == 0) > > > kfree_bulk(bkvhead[i]->nr_records, > > > bkvhead[i]->records); > > > else > > > vfree_bulk(bkvhead[i]->nr_records, > > > bkvhead[i]->records); > > > > > > > > > Matthew, what is your thought? > > > > That was my thinking too. If we had a kvfree_bulk(), I would expect it to > > handle a mixture of vfree and kfree, but you've segregated them already. > > So I think this is better. > > > Yes, the segregation is done. Having vfree_bulk() is enough then. > We are on the same page :) Very good. When does kfree_rcu() and friends move out of kernel/rcu? Thanx, Paul