From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 113A2C433DF for ; Thu, 18 Jun 2020 22:35:36 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A6E5220707 for ; Thu, 18 Jun 2020 22:35:35 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HpuoGa6P" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A6E5220707 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C079F8D0062; Thu, 18 Jun 2020 18:35:34 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id B91198D0052; Thu, 18 Jun 2020 18:35:34 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A31EC8D0062; Thu, 18 Jun 2020 18:35:34 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0254.hostedemail.com [216.40.44.254]) by kanga.kvack.org (Postfix) with ESMTP id 887B78D0052 for ; Thu, 18 Jun 2020 18:35:34 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 1B5BD185BD913 for ; Thu, 18 Jun 2020 22:35:34 +0000 (UTC) X-FDA: 76943790588.03.frog55_4b16a9f26e13 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id D651A3C63E7 for ; Thu, 18 Jun 2020 21:17:31 +0000 (UTC) X-HE-Tag: frog55_4b16a9f26e13 X-Filterd-Recvd-Size: 4417 Received: from mail-lf1-f65.google.com (mail-lf1-f65.google.com [209.85.167.65]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Jun 2020 21:17:17 +0000 (UTC) Received: by mail-lf1-f65.google.com with SMTP id t74so4346085lff.2 for ; Thu, 18 Jun 2020 14:17:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=idHNUUuLhsbI+SMCrjb0o6RR15DaxhR7dGxO0G4VxCE=; b=HpuoGa6PnVdwnMuQ0O9frLNQHsBh6qEG75dT18PtTOeq3ScT6WdfmBEo1z/SV92bSd 8RdFO8FoHlTigsz0Yp4gmOnz8lcrbT9OORjSvH/RvuhZM4ph/vq7bBh0DAedAqnciYau pwy6rep+9+nkMPVZjwGUXYoGYZVFdmHSe0Oc24G/QqtzLZ8r8lrRDshEeOMylbL9TqWo /f6J+8SCnCim4bDcofhpbH7g0IpXAbFV1xfM+b9eiZfwYNm0yxkwIBBnD2lTsM1TfU0y LHGRlHopuR/eT8JsqeDywlAAgMAS1K0IBBRnLV25uZ0C6xWFX0DdlqygvzdKW0+3d5pd +/1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=idHNUUuLhsbI+SMCrjb0o6RR15DaxhR7dGxO0G4VxCE=; b=nnb/Gs8OATviG21oSSMhjmGz+JoVYU3QwMQ2twD8j46ssWRKPxIy4hPgPRG6EfoFb3 ZlxEFDFzpo1fL9/N0RKf2aqNKFb6mO9Trb8CBkmY8iwrVdx/RVv+AkqDJh3vkaHdgsZ2 m5Fz8U7kIh2Zs3Emc6IsDrEWaxJFQbLbYTApzYGHKAe+rbaqUbDrQfFbWzhSw0DQIhPn NGkvlxabJ0AZwrDOsmjDEx3rVhfGCCuBhvYlLIZ91az63AjE6v+fJHKHZPj0sPM+bxg9 on2iuQd5oTqzYTDfESGz30W+RsMw3njXFmDz15pUnUzQJGzqBE2EE/IRmP1VzEQuQKiy QApQ== X-Gm-Message-State: AOAM530qzoy9q5NTOXpiv7ltM5/mxl+caJPlaQ7U41axQp+Uku3SyLyH JEmMjZqmhtvH08JTGmD51ys= X-Google-Smtp-Source: ABdhPJza2WIVv0zoTR1seTP50OUqAb8gjUglXvAVMFnr1hlxbG9/1kxwveGGPE/EO0OfoFcG3M5O1g== X-Received: by 2002:a05:6512:3295:: with SMTP id p21mr124276lfe.114.1592515035643; Thu, 18 Jun 2020 14:17:15 -0700 (PDT) Received: from pc636 (h5ef52e31.seluork.dyn.perspektivbredband.net. [94.245.46.49]) by smtp.gmail.com with ESMTPSA id 24sm985812lfy.59.2020.06.18.14.17.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 14:17:11 -0700 (PDT) From: Uladzislau Rezki X-Google-Original-From: Uladzislau Rezki Date: Thu, 18 Jun 2020 23:17:09 +0200 To: Matthew Wilcox Cc: Uladzislau Rezki , "Paul E. McKenney" , LKML , linux-mm@kvack.org, Andrew Morton , "Theodore Y . Ts'o" , Joel Fernandes , RCU , Oleksiy Avramchenko Subject: Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs Message-ID: <20200618211709.GA17263@pc636> References: <20200525214800.93072-10-urezki@gmail.com> <20200617234609.GA10087@paulmck-ThinkPad-P72> <20200618005214.GN8681@bombadil.infradead.org> <20200618031823.GQ2723@paulmck-ThinkPad-P72> <20200618173520.GC14613@pc636> <20200618175719.GT2723@paulmck-ThinkPad-P72> <20200618183448.GA15136@pc636> <20200618190359.GU2723@paulmck-ThinkPad-P72> <20200618203557.GB16976@pc636> <20200618203821.GU8681@bombadil.infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618203821.GU8681@bombadil.infradead.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: D651A3C63E7 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > > > > trace_rcu_invoke_kfree_bulk_callback( > > rcu_state.name, bkvhead[i]->nr_records, > > bkvhead[i]->records); > > if (i == 0) > > kfree_bulk(bkvhead[i]->nr_records, > > bkvhead[i]->records); > > else > > vfree_bulk(bkvhead[i]->nr_records, > > bkvhead[i]->records); > > > > > > Matthew, what is your thought? > > That was my thinking too. If we had a kvfree_bulk(), I would expect it to > handle a mixture of vfree and kfree, but you've segregated them already. > So I think this is better. > Yes, the segregation is done. Having vfree_bulk() is enough then. We are on the same page :) Thanks! -- Vlad Rezki