From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: linux-mm@kvack.org
Cc: Christopher Lameter <cl@linux.com>,
Pekka Enberg <penberg@kernel.org>,
David Rientjes <rientjes@google.com>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Andrew Morton <akpm@linux-foundation.org>,
Thomas Gleixner <tglx@linutronix.de>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Yu Zhao <yuzhao@google.com>
Subject: [PATCH 2/2] slub: Drop lockdep_assert_held() from put_map()
Date: Thu, 18 Jun 2020 22:12:34 +0200 [thread overview]
Message-ID: <20200618201234.795692-2-bigeasy@linutronix.de> (raw)
In-Reply-To: <20200618201234.795692-1-bigeasy@linutronix.de>
There is no point in using lockdep_assert_held() unlock that is about to be
unlocked. It works only with lockdep and lockdep will complain if
spin_unlock() is used on a lock that has not been locked.
Remove superfluous lockdep_assert_held().
Cc: Yu Zhao <yuzhao@google.com>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
mm/slub.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/slub.c b/mm/slub.c
index 72195cafbb503..5a43ad225427f 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -469,8 +469,6 @@ static unsigned long *get_map(struct kmem_cache *s, struct page *page)
static void put_map(unsigned long *map) __releases(&object_map_lock)
{
VM_BUG_ON(map != object_map);
- lockdep_assert_held(&object_map_lock);
-
spin_unlock(&object_map_lock);
}
--
2.27.0
next prev parent reply other threads:[~2020-06-18 20:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 9:46 [RFC] SLUB: list_slab_objects() looks like a miss-merge Sebastian Andrzej Siewior
2020-06-18 15:03 ` Christopher Lameter
2020-06-18 20:12 ` [PATCH 1/2] slub: Cure list_slab_objects() from double fix Sebastian Andrzej Siewior
2020-06-18 20:12 ` Sebastian Andrzej Siewior [this message]
2020-06-18 21:02 ` [RFC] SLUB: list_slab_objects() looks like a miss-merge Yu Zhao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618201234.795692-2-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=tglx@linutronix.de \
--cc=yuzhao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox