From: Jason Gunthorpe <jgg@nvidia.com>
To: Jing Xiangfeng <jingxiangfeng@huawei.com>
Cc: <bvanassche@acm.org>, <dledford@redhat.com>,
<linux-rdma@vger.kernel.org>, <target-devel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [PATCH v3] IB/srpt: Remove WARN_ON from srpt_cm_req_recv
Date: Thu, 18 Jun 2020 15:18:16 -0300 [thread overview]
Message-ID: <20200618181816.GA2453631@mellanox.com> (raw)
In-Reply-To: <20200617140803.181333-1-jingxiangfeng@huawei.com>
On Wed, Jun 17, 2020 at 10:08:03PM +0800, Jing Xiangfeng wrote:
> The callers pass the pointer '&req' or 'private_data' to
> srpt_cm_req_recv(), and 'private_data' is initialized in srp_send_req().
> 'sdev' is allocated and stored in srpt_add_one(). It's easy to show that
> sdev and req are always valid. So we remove unnecessary WARN_ON.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> ---
> drivers/infiniband/ulp/srpt/ib_srpt.c | 3 ---
> 1 file changed, 3 deletions(-)
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2020-06-18 18:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-17 14:08 Jing Xiangfeng
2020-06-18 14:03 ` Bart Van Assche
2020-06-18 18:18 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618181816.GA2453631@mellanox.com \
--to=jgg@nvidia.com \
--cc=bvanassche@acm.org \
--cc=dledford@redhat.com \
--cc=jingxiangfeng@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-rdma@vger.kernel.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox