From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C5EDC433DF for ; Thu, 18 Jun 2020 17:35:37 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EF3E020706 for ; Thu, 18 Jun 2020 17:35:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="qDyD8J2e" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EF3E020706 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 9E0E38D004C; Thu, 18 Jun 2020 13:35:36 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 991168D0018; Thu, 18 Jun 2020 13:35:36 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8CDE48D004C; Thu, 18 Jun 2020 13:35:36 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 72A138D0018 for ; Thu, 18 Jun 2020 13:35:36 -0400 (EDT) Received: from smtpin13.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 20904A945A for ; Thu, 18 Jun 2020 17:35:36 +0000 (UTC) X-FDA: 76943034672.13.feet18_0f085b626e12 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin13.hostedemail.com (Postfix) with ESMTP id E88D118140D61 for ; Thu, 18 Jun 2020 17:35:35 +0000 (UTC) X-HE-Tag: feet18_0f085b626e12 X-Filterd-Recvd-Size: 3197 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf37.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Jun 2020 17:35:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=wKqNA3EeTkgG7RP/Q9T1JShDJKFnZTf+jj7QQYV4wkU=; b=qDyD8J2esdxA0WqhPixbQMugAB xett1RLL/j/foQDTYaVAx9vQqCwLW+SY7Vf4XlVNjaKuN3LL0BP9JSYwNs/+W1loT+akTcHMexJwC g2LCkmvVZ9mR+uCaYeh4EP1D8QTppiO3JqpAoiirWy3hkntYHZreyDfW12kHpPoDEeTjHGOtTEauk i2UxH1xejM6pFRDCezcjehVPbZgcjp2QgiXfEf09qDO+N+6JNWA/OlWaZRKxN9lqmqMHhdt4bjige p/ILAtdvmhpKIqeYcEVCJYTag3c0PHdSVkH5aooEpQ6UDqRgx4p7GNBxKMLJX+d7dWnz6rj6ymzLa d0I5zGtA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlyRj-0006ek-EB; Thu, 18 Jun 2020 17:35:27 +0000 Date: Thu, 18 Jun 2020 10:35:27 -0700 From: Matthew Wilcox To: Uladzislau Rezki Cc: "Paul E. McKenney" , LKML , linux-mm@kvack.org, Andrew Morton , "Theodore Y . Ts'o" , Joel Fernandes , RCU , Oleksiy Avramchenko Subject: Re: [PATCH v2 09/16] rcu/tree: Maintain separate array for vmalloc ptrs Message-ID: <20200618173527.GR8681@bombadil.infradead.org> References: <20200525214800.93072-1-urezki@gmail.com> <20200525214800.93072-10-urezki@gmail.com> <20200617234609.GA10087@paulmck-ThinkPad-P72> <20200618005214.GN8681@bombadil.infradead.org> <20200618173049.GB14613@pc636> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618173049.GB14613@pc636> X-Rspamd-Queue-Id: E88D118140D61 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 18, 2020 at 07:30:49PM +0200, Uladzislau Rezki wrote: > > I'd suggest: > > > > rcu_lock_acquire(&rcu_callback_map); > > trace_rcu_invoke_kfree_bulk_callback(rcu_state.name, > > bkvhead[i]->nr_records, bkvhead[i]->records); > > if (i == 0) { > > kfree_bulk(bkvhead[i]->nr_records, > > bkvhead[i]->records); > > } else { > > for (j = 0; j < bkvhead[i]->nr_records; j++) { > > vfree(bkvhead[i]->records[j]); > > } > > } > > rcu_lock_release(&rcu_callback_map); > > > There are two different trace functions, one for "bulk" tracing > messages, and another one is per one call of kfree(), though we use > to indicate vfree() call. > > Probably we can rename it to: trace_rcu_invoke_kvfree_callback(); > > What do you think? Works for me! > > But I'd also suggest a vfree_bulk be added. There are a few things > > which would be better done in bulk as part of the vfree process > > (we batch them up already, but i'm sure we could do better). > > I was thinking to implement of vfree_bulk() API, but i guess it can > be done as future work. > > Does that sound good? Yes, definitely a future piece of work.