From: Xiaoming Ni <nixiaoming@huawei.com>
To: <acme@kernel.org>, <alexander.shishkin@linux.intel.com>,
<arnd@arndb.de>, <borntraeger@de.ibm.com>,
<catalin.marinas@arm.com>, <christian@brauner.io>,
<cyphar@cyphar.com>, <dhowells@redhat.com>,
<ebiederm@xmission.com>, <fenghua.yu@intel.com>,
<geert@linux-m68k.org>, <gor@linux.ibm.com>,
<heiko.carstens@de.ibm.com>, <ink@jurassic.park.msu.ru>,
<jolsa@redhat.com>, <linux@armlinux.org.uk>, <lkp@intel.com>,
<mark.rutland@arm.com>, <mattst88@gmail.com>,
<minchan@kernel.org>, <mingo@redhat.com>, <monstr@monstr.eu>,
<namhyung@kernel.org>, <nixiaoming@huawei.com>,
<peterz@infradead.org>, <rth@twiddle.net>, <sargun@sargun.me>,
<sfr@canb.auug.org.au>, <tony.luck@intel.com>, <will@kernel.org>,
<akpm@linux-foundation.org>
Cc: <alex.huangjianhui@huawei.com>, <zhongjubin@huawei.com>,
<linux-kernel@vger.kernel.org>, <linux-s390@vger.kernel.org>,
<clang-built-linux@googlegroups.com>, <kbuild-all@lists.01.org>,
<linux-mm@kvack.org>
Subject: [PATCH v2] s390: fix build error for sys_call_table_emu
Date: Thu, 18 Jun 2020 22:14:26 +0800 [thread overview]
Message-ID: <20200618141426.16884-1-nixiaoming@huawei.com> (raw)
Build error on s390:
arch/s390/kernel/entry.o: in function `sys_call_table_emu':
>> (.rodata+0x1288): undefined reference to `__s390_'
In commit ("All arch: remove system call sys_sysctl")
148 common fdatasync sys_fdatasync sys_fdatasync
-149 common _sysctl sys_sysctl compat_sys_sysctl
+149 common _sysctl sys_ni_syscall
150 common mlock sys_mlock sys_mlock
After the patch is integrated, there is a format error in the generated
arch/s390/include/generated/asm/syscall_table.h:
SYSCALL(sys_fdatasync, sys_fdatasync)
SYSCALL(sys_ni_syscall,) /* cause build error */
SYSCALL(sys_mlock,sys_mlock)
According to the guidance of Heiko Carstens, use "-" to fill the empty system call
Similarly, modify tools/perf/arch/s390/entry/syscalls/syscall.tbl.
Fixes: ("All arch: remove system call sys_sysctl")
Fixes: https://lore.kernel.org/linuxppc-dev/20200616030734.87257-1-nixiaoming@huawei.com/
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Xiaoming Ni <nixiaoming@huawei.com>
changes in v2:
use "-" to fill the empty system call
v1: https://lore.kernel.org/lkml/20200618110320.104013-1-nixiaoming@huawei.com/
---
arch/s390/kernel/syscalls/syscall.tbl | 2 +-
tools/perf/arch/s390/entry/syscalls/syscall.tbl | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/s390/kernel/syscalls/syscall.tbl b/arch/s390/kernel/syscalls/syscall.tbl
index f17aaf6fe5de..04c34c2ed916 100644
--- a/arch/s390/kernel/syscalls/syscall.tbl
+++ b/arch/s390/kernel/syscalls/syscall.tbl
@@ -138,7 +138,7 @@
146 common writev sys_writev compat_sys_writev
147 common getsid sys_getsid sys_getsid
148 common fdatasync sys_fdatasync sys_fdatasync
-149 common _sysctl sys_ni_syscall
+149 common _sysctl - -
150 common mlock sys_mlock sys_mlock
151 common munlock sys_munlock sys_munlock
152 common mlockall sys_mlockall sys_mlockall
diff --git a/tools/perf/arch/s390/entry/syscalls/syscall.tbl b/tools/perf/arch/s390/entry/syscalls/syscall.tbl
index 0193f9b98753..29144b79a49d 100644
--- a/tools/perf/arch/s390/entry/syscalls/syscall.tbl
+++ b/tools/perf/arch/s390/entry/syscalls/syscall.tbl
@@ -138,7 +138,7 @@
146 common writev sys_writev compat_sys_writev
147 common getsid sys_getsid sys_getsid
148 common fdatasync sys_fdatasync sys_fdatasync
-149 common _sysctl sys_ni_syscall
+149 common _sysctl - -
150 common mlock sys_mlock compat_sys_mlock
151 common munlock sys_munlock compat_sys_munlock
152 common mlockall sys_mlockall sys_mlockall
--
2.27.0
next reply other threads:[~2020-06-18 14:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-18 14:14 Xiaoming Ni [this message]
2020-06-19 14:17 ` Heiko Carstens
2020-06-19 19:27 ` Arnaldo Carvalho de Melo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200618141426.16884-1-nixiaoming@huawei.com \
--to=nixiaoming@huawei.com \
--cc=acme@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.huangjianhui@huawei.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=arnd@arndb.de \
--cc=borntraeger@de.ibm.com \
--cc=catalin.marinas@arm.com \
--cc=christian@brauner.io \
--cc=clang-built-linux@googlegroups.com \
--cc=cyphar@cyphar.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=fenghua.yu@intel.com \
--cc=geert@linux-m68k.org \
--cc=gor@linux.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=ink@jurassic.park.msu.ru \
--cc=jolsa@redhat.com \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-s390@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lkp@intel.com \
--cc=mark.rutland@arm.com \
--cc=mattst88@gmail.com \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=monstr@monstr.eu \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=rth@twiddle.net \
--cc=sargun@sargun.me \
--cc=sfr@canb.auug.org.au \
--cc=tony.luck@intel.com \
--cc=will@kernel.org \
--cc=zhongjubin@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox