From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C343DC433E0 for ; Thu, 18 Jun 2020 12:41:35 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 8EABB20663 for ; Thu, 18 Jun 2020 12:41:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EABB20663 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 238A98D0001; Thu, 18 Jun 2020 08:41:35 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E89C6B0096; Thu, 18 Jun 2020 08:41:35 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0D7608D0001; Thu, 18 Jun 2020 08:41:35 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0176.hostedemail.com [216.40.44.176]) by kanga.kvack.org (Postfix) with ESMTP id E6DCF6B0095 for ; Thu, 18 Jun 2020 08:41:34 -0400 (EDT) Received: from smtpin24.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3B6F83584 for ; Thu, 18 Jun 2020 12:41:34 +0000 (UTC) X-FDA: 76942293708.24.floor91_100819226e10 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin24.hostedemail.com (Postfix) with ESMTP id 165771AA68 for ; Thu, 18 Jun 2020 12:41:34 +0000 (UTC) X-HE-Tag: floor91_100819226e10 X-Filterd-Recvd-Size: 4724 Received: from mail-ej1-f67.google.com (mail-ej1-f67.google.com [209.85.218.67]) by imf04.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Jun 2020 12:41:33 +0000 (UTC) Received: by mail-ej1-f67.google.com with SMTP id dr13so6256711ejc.3 for ; Thu, 18 Jun 2020 05:41:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GwWWgp6poedvgja7RNEoGmK1y3wNcNo/q/dYBmBGoA8=; b=Qo2kMIK8Bd8Za7rPWAnIgz1EU3N6sBkG+SsvcUFMqho0oqB4jAPEorrwPZNkTZlF9g zV/5cI6WUVZ8GBPo05P4C/TW/6XHU7P5jziXNguNeWf6sFcEG7gf6qJUMhSJ9gsIzSUA Lct7jBguXpAIUt+0NzFYSv9K7k/Sm5kXkb99olCokyfM4xmMLbAyS1IV3LSiH1sP9Ea1 vYZUm4eLG+S2lqyac+RxLk7bpr0K0EPzSkBcermmRPUwijPEJVbHeEUYiBqdAfwjNZFx z62iAk2X7HLfy1wNJGyPxmaE+3xcWUQ8/pElTu947w4gj59IYzOCKtlldKbt5t/ycWMT +qHg== X-Gm-Message-State: AOAM5333u8aQAn8Yzg4jpZqdVYnmyT1qeS357l535rMISAP+TW564L7J bHB/7Aos5dm1goHSEhb0BuI= X-Google-Smtp-Source: ABdhPJxMkauDVQefVPuJ2qpFGMV+90HykPa5BpTmZw4DM3T8iphGnLowIDqJy/XvxbHN8BtR+7Sktg== X-Received: by 2002:a17:907:20e5:: with SMTP id rh5mr3971654ejb.80.1592484092440; Thu, 18 Jun 2020 05:41:32 -0700 (PDT) Received: from localhost (ip-37-188-189-34.eurotel.cz. [37.188.189.34]) by smtp.gmail.com with ESMTPSA id dn15sm2375487ejc.26.2020.06.18.05.41.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 18 Jun 2020 05:41:31 -0700 (PDT) Date: Thu, 18 Jun 2020 14:41:29 +0200 From: Michal Hocko To: Chris Down Cc: Yafang Shao , Naresh Kamboju , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , Cgroups Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Message-ID: <20200618124129.GC15447@dhcp22.suse.cz> References: <20200521163450.GV6462@dhcp22.suse.cz> <20200617135758.GA548179@chrisdown.name> <20200617141155.GQ9499@dhcp22.suse.cz> <20200617160624.GS9499@dhcp22.suse.cz> <20200617210935.GA578452@chrisdown.name> <20200618123743.GA694719@chrisdown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200618123743.GA694719@chrisdown.name> X-Rspamd-Queue-Id: 165771AA68 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000025, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu 18-06-20 13:37:43, Chris Down wrote: > Yafang Shao writes: > > On Thu, Jun 18, 2020 at 5:09 AM Chris Down wrote: > > > > > > Naresh Kamboju writes: > > > >After this patch applied the reported issue got fixed. > > > > > > Great! Thank you Naresh and Michal for helping to get to the bottom of this :-) > > > > > > I'll send out a new version tomorrow with the fixes applied and both of you > > > credited in the changelog for the detection and fix. > > > > As we have already found that the usage around memory.{emin, elow} has > > many limitations, I think memory.{emin, elow} should be used for > > memcg-tree internally only, that means they can only be used to > > calculate the protection of a memcg in a specified memcg-tree but > > should not be exposed to other MM parts. > > I agree that the current semantics are mentally taxing and we should > generally avoid exposing the implementation details outside of memcg where > possible. Do you have a suggested rework? :-) I would really prefer to do that work on top of the fixes we (used to) have in mmotm (with the fixup). -- Michal Hocko SUSE Labs