From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 591B9C433E2 for ; Thu, 18 Jun 2020 10:35:14 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 010BC21D7A for ; Thu, 18 Jun 2020 10:35:13 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="DdyAOrKF" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 010BC21D7A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6864F6B007E; Thu, 18 Jun 2020 06:35:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 637026B0080; Thu, 18 Jun 2020 06:35:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 525CE6B0081; Thu, 18 Jun 2020 06:35:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id 36F176B007E for ; Thu, 18 Jun 2020 06:35:13 -0400 (EDT) Received: from smtpin27.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id A6C6F1EE6 for ; Thu, 18 Jun 2020 10:35:12 +0000 (UTC) X-FDA: 76941975264.27.mine72_3e13bad26e0f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin27.hostedemail.com (Postfix) with ESMTP id 787BC3D668 for ; Thu, 18 Jun 2020 10:35:12 +0000 (UTC) X-HE-Tag: mine72_3e13bad26e0f X-Filterd-Recvd-Size: 4131 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Thu, 18 Jun 2020 10:35:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=tliSKQbk7IKkXD+3sv6W4IKOfskIhBhUzC3bD3Cn3Ec=; b=DdyAOrKFtQPhPLgqdSUGoR/Pkw ETlLNIB3zwt3JUNas1N7hfkVOvAJg/+cvvcb7SvRYknq8Joove3g5DnH71qIUxZxP9EMUbsl5dWLC zM8r0ceGwzdqHzE/ZwK7uhJpHEMtzt9maVhQr0ZG+jyTDPNqy3NzR85KqeP9psQKHWE7H3MpGKjzG c6YNp6EtrIFK5c++jcfE8zJzmhEiH1XPjKAnPn8DknJi+BebmFwY5JubyGMmJkkOnrxEUmGRZfxMm lfzK49VAnUaxJzqLimyEivJmt/MtqbBl719cwHo0UEHeF6kKbXhcGkWONwWXaV83lNP1BFM+cKNme e/j7Fz5w==; Received: from j217100.upc-j.chello.nl ([24.132.217.100] helo=noisy.programming.kicks-ass.net) by bombadil.infradead.org with esmtpsa (Exim 4.92.3 #3 (Red Hat Linux)) id 1jlrsy-00027C-M3; Thu, 18 Jun 2020 10:35:08 +0000 Received: from hirez.programming.kicks-ass.net (hirez.programming.kicks-ass.net [192.168.1.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by noisy.programming.kicks-ass.net (Postfix) with ESMTPS id 47CD230018A; Thu, 18 Jun 2020 12:35:06 +0200 (CEST) Received: by hirez.programming.kicks-ass.net (Postfix, from userid 1000) id 338BD20C227A0; Thu, 18 Jun 2020 12:35:06 +0200 (CEST) Date: Thu, 18 Jun 2020 12:35:06 +0200 From: Peter Zijlstra To: David Hildenbrand Cc: Christoph Hellwig , Andrew Morton , Dexuan Cui , Vitaly Kuznetsov , Catalin Marinas , Will Deacon , Jessica Yu , x86@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-hyperv@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/3] arm64: use PAGE_KERNEL_ROX directly in alloc_insn_page Message-ID: <20200618103506.GH576905@hirez.programming.kicks-ass.net> References: <20200618064307.32739-1-hch@lst.de> <20200618064307.32739-3-hch@lst.de> <90234f58-e83a-7f20-62a7-80a4e81cde95@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <90234f58-e83a-7f20-62a7-80a4e81cde95@redhat.com> X-Rspamd-Queue-Id: 787BC3D668 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 18, 2020 at 10:55:58AM +0200, David Hildenbrand wrote: > On 18.06.20 08:43, Christoph Hellwig wrote: > > Use PAGE_KERNEL_ROX directly instead of allocating RWX and setting the > > page read-only just after the allocation. > > > > Signed-off-by: Christoph Hellwig > > --- > > arch/arm64/kernel/probes/kprobes.c | 12 +++--------- > > 1 file changed, 3 insertions(+), 9 deletions(-) > > > > diff --git a/arch/arm64/kernel/probes/kprobes.c b/arch/arm64/kernel/probes/kprobes.c > > index d1c95dcf1d7833..cbe49cd117cfec 100644 > > --- a/arch/arm64/kernel/probes/kprobes.c > > +++ b/arch/arm64/kernel/probes/kprobes.c > > @@ -120,15 +120,9 @@ int __kprobes arch_prepare_kprobe(struct kprobe *p) > > > > void *alloc_insn_page(void) > > { > > - void *page; > > - > > - page = vmalloc_exec(PAGE_SIZE); > > - if (page) { > > - set_memory_ro((unsigned long)page, 1); > > - set_vm_flush_reset_perms(page); > > - } > > - > > - return page; > > + return __vmalloc_node_range(PAGE_SIZE, 1, VMALLOC_START, VMALLOC_END, > > + GFP_KERNEL, PAGE_KERNEL_ROX, VM_FLUSH_RESET_PERMS, > > + NUMA_NO_NODE, __func__); > > I do wonder if something like vmalloc_prot(size, prot) would make this > (and the other two users) easier to read. > > So instead of ripping out vmalloc_exec(), converting it into > vmalloc_prot() instead. > > Did you consider that? For x86 Christoph did module_alloc_prot(), which is in his more extensive set of patches addressing this. I suspect that would be the right thing for ARM64 as well.