From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 019C0C433E0 for ; Wed, 17 Jun 2020 20:02:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B94FF20897 for ; Wed, 17 Jun 2020 20:02:07 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="AdXJC/hQ" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B94FF20897 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 362646B0006; Wed, 17 Jun 2020 16:02:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3120A6B000A; Wed, 17 Jun 2020 16:02:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24DE46B000C; Wed, 17 Jun 2020 16:02:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0189.hostedemail.com [216.40.44.189]) by kanga.kvack.org (Postfix) with ESMTP id 0A7016B0006 for ; Wed, 17 Jun 2020 16:02:07 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id B3BE08245571 for ; Wed, 17 Jun 2020 20:02:06 +0000 (UTC) X-FDA: 76939775052.29.loss05_250cd4026e0a Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin29.hostedemail.com (Postfix) with ESMTP id 92D2C18086E4B for ; Wed, 17 Jun 2020 20:02:06 +0000 (UTC) X-HE-Tag: loss05_250cd4026e0a X-Filterd-Recvd-Size: 2554 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 17 Jun 2020 20:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=9J8ZAxKKt3rYTkzZ/REcW+6qQSyuOPH1KZ7A4yaiyPk=; b=AdXJC/hQhxSujPpefoe9zdg9eV Ww7jsZFi2YRiF9EUuhRByXRCC/y/6FdUWiAVTz8Rv/K9wdAOFw7ibB6pehWvEEEnOu6LgiCfGrOIz +fVWlGN6ETaPTQeo6qFGuFJRNkC5iv1Vpqs/41uSP1ovc5TqAHiXGMnE0IK9oOe9HHay3FhrHsPOw +mQmNzA6iItHOHVicbE1WCoSF85LSYKTDXcb20VRahYMVfZajpoMhAhaFEzG7Iv3001sXoDx2/Pe0 20KlDX8TEDjKh3cffiIFTpK+ZFnouWyLBJn140i1pqUYmIKiSomI2xrp7ArmwuurnAwM72UZXK0dn 8EK4QNJQ==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jleFr-0001Jb-Lu; Wed, 17 Jun 2020 20:01:51 +0000 Date: Wed, 17 Jun 2020 13:01:51 -0700 From: Matthew Wilcox To: Kees Cook Cc: Andrew Morton , Vlastimil Babka , Roman Gushchin , Christoph Lameter , Alexander Popov , Pekka Enberg , David Rientjes , Joonsoo Kim , vinmenon@codeaurora.org, Matthew Garrett , Jann Horn , Vijayanand Jitta , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm: Expand CONFIG_SLAB_FREELIST_HARDENED to include SLAB and SLOB Message-ID: <20200617200151.GM8681@bombadil.infradead.org> References: <20200617195349.3471794-1-keescook@chromium.org> <20200617195349.3471794-2-keescook@chromium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200617195349.3471794-2-keescook@chromium.org> X-Rspamd-Queue-Id: 92D2C18086E4B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 17, 2020 at 12:53:48PM -0700, Kees Cook wrote: > Include SLAB and SLOB caches when performing kmem_cache pointer ... SLOB? Really? Objects from different kmem caches are mixed together on the same page with SLOB (at least last time I looked). So how does this work? > verification. A defense against such corruption[1] should be applied > to all the allocators. With this added, the "SLAB_FREE_CROSS" and > "SLAB_FREE_PAGE" LKDTM tests now pass on SLAB: