From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A9CDC433E0 for ; Wed, 17 Jun 2020 14:09:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 176AC20734 for ; Wed, 17 Jun 2020 14:09:49 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chrisdown.name header.i=@chrisdown.name header.b="d+J+aw6Z" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 176AC20734 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chrisdown.name Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A9BF96B0023; Wed, 17 Jun 2020 10:09:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A4D6D6B0024; Wed, 17 Jun 2020 10:09:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 93CBE6B0025; Wed, 17 Jun 2020 10:09:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0141.hostedemail.com [216.40.44.141]) by kanga.kvack.org (Postfix) with ESMTP id 7C78C6B0023 for ; Wed, 17 Jun 2020 10:09:48 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 3E8775AD19 for ; Wed, 17 Jun 2020 14:09:48 +0000 (UTC) X-FDA: 76938887256.28.net16_151826e26e08 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id 60520343E5 for ; Wed, 17 Jun 2020 14:09:02 +0000 (UTC) X-HE-Tag: net16_151826e26e08 X-Filterd-Recvd-Size: 4472 Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by imf34.hostedemail.com (Postfix) with ESMTP for ; Wed, 17 Jun 2020 14:09:01 +0000 (UTC) Received: by mail-wr1-f65.google.com with SMTP id p5so2476456wrw.9 for ; Wed, 17 Jun 2020 07:09:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chrisdown.name; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Q/YL4Tzx4ADMiyqvj4Ve2wziFTGT/p0DVcYFG6HXk08=; b=d+J+aw6Zm5XRvlxRf1UGsdkDdw/4mdWlAseuLVRmjuRl77imTs8xnEwfCx3+/GfmIn bikdBwRjyQV2FhPxZDoxaryjSxXvxqhpXbUEuGGRJ6XKTOw9aHhfZNDGhlxVfd4s8+dB zPJBHP+Y5JfMrXFtfl1BiiRwc2CLhSP1/aSVo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Q/YL4Tzx4ADMiyqvj4Ve2wziFTGT/p0DVcYFG6HXk08=; b=Jy/f8k5qBAvtEDJWZJ7lLfJBb5d/M9K9EolsJHObRYdMrvGFxdLzOwLpBMIaG6n7ez 74xjrVK9nD5dbZvd6N0vX6qLoQKEP30z1poDqK8a45cEPI3fZUHI7hg82tpBVDS+weog IKtCSWRC6vl0smM7xh44RWOa/XOjHA5YQWHhBIOhEK1rh/3n+06zJg89w9fdnXOPQ0J6 pYIcowtcEzOyIdV0qJ2WKzzWPigR4Xr7is+cP6iQF3RM2mS3WxSMasLf/JVGP89W8TMC MQvdvk81n1hKEzL7qNwHUJqS2bCS4wcFUJzWX+hzO0YmnIc6VbBZe1bB5vvVBGErPiSo G3hA== X-Gm-Message-State: AOAM533SHD5uW9TAZa9G9Y66Kc4qQ1684XoZlNoQVg2saFxlnfxOWBiH VkBmQYG/xJoF45gtvRrsZpdPHg== X-Google-Smtp-Source: ABdhPJzL0eIzzTI+SzZBoqt3/b7Xundx14ukkyOPthT2L2+/VFT7bPwecalJL/jau7TXAMBO1wA5IA== X-Received: by 2002:adf:fd48:: with SMTP id h8mr9338191wrs.226.1592402940724; Wed, 17 Jun 2020 07:09:00 -0700 (PDT) Received: from localhost ([2a01:4b00:8432:8a00:63de:dd93:20be:f460]) by smtp.gmail.com with ESMTPSA id o6sm33035118wrp.3.2020.06.17.07.08.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Jun 2020 07:08:59 -0700 (PDT) Date: Wed, 17 Jun 2020 15:08:59 +0100 From: Chris Down To: Michal Hocko Cc: Naresh Kamboju , Yafang Shao , Anders Roxell , "Linux F2FS DEV, Mailing List" , linux-ext4 , linux-block , Andrew Morton , open list , Linux-Next Mailing List , linux-mm , Arnd Bergmann , Andreas Dilger , Jaegeuk Kim , Theodore Ts'o , Chao Yu , Hugh Dickins , Andrea Arcangeli , Matthew Wilcox , Chao Yu , lkft-triage@lists.linaro.org, Johannes Weiner , Roman Gushchin , Cgroups Subject: Re: mm: mkfs.ext4 invoked oom-killer on i386 - pagecache_get_page Message-ID: <20200617140859.GB548179@chrisdown.name> References: <20200519075213.GF32497@dhcp22.suse.cz> <20200519084535.GG32497@dhcp22.suse.cz> <20200520190906.GA558281@chrisdown.name> <20200521095515.GK6462@dhcp22.suse.cz> <20200521163450.GV6462@dhcp22.suse.cz> <20200617135951.GP9499@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <20200617135951.GP9499@dhcp22.suse.cz> User-Agent: Mutt/1.14.3 (2020-06-14) X-Rspamd-Queue-Id: 60520343E5 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Michal Hocko writes: >and it makes some sense. Except for the root memcg where we do not >account any memory. Adding if (mem_cgroup_is_root(memcg)) return false; >should do the trick. The same is the case for mem_cgroup_below_low. >Could you give it a try please just to confirm? Oh, of course :-) This seems more likely than what I proposed, and would be great to test.