From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A96AC433DF for ; Wed, 17 Jun 2020 14:07:00 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2DA85207DD for ; Wed, 17 Jun 2020 14:07:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DA85207DD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A27496B0022; Wed, 17 Jun 2020 10:06:59 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9D85C6B0023; Wed, 17 Jun 2020 10:06:59 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8EEBA6B0024; Wed, 17 Jun 2020 10:06:59 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0192.hostedemail.com [216.40.44.192]) by kanga.kvack.org (Postfix) with ESMTP id 74D7B6B0022 for ; Wed, 17 Jun 2020 10:06:59 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 0A68E180ACA4E for ; Wed, 17 Jun 2020 14:06:59 +0000 (UTC) X-FDA: 76938880158.26.stew51_35141d326e08 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id 320BC180CDE4D for ; Wed, 17 Jun 2020 14:04:56 +0000 (UTC) X-HE-Tag: stew51_35141d326e08 X-Filterd-Recvd-Size: 2158 Received: from huawei.com (szxga07-in.huawei.com [45.249.212.35]) by imf10.hostedemail.com (Postfix) with ESMTP for ; Wed, 17 Jun 2020 14:04:55 +0000 (UTC) Received: from DGGEMS403-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 5B33BB4F90B46736D7A0; Wed, 17 Jun 2020 22:04:44 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS403-HUB.china.huawei.com (10.3.19.203) with Microsoft SMTP Server id 14.3.487.0; Wed, 17 Jun 2020 22:04:37 +0800 From: Jing Xiangfeng To: , , CC: , , , , Subject: [PATCH v3] IB/srpt: Remove WARN_ON from srpt_cm_req_recv Date: Wed, 17 Jun 2020 22:08:03 +0800 Message-ID: <20200617140803.181333-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: 320BC180CDE4D X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The callers pass the pointer '&req' or 'private_data' to srpt_cm_req_recv(), and 'private_data' is initialized in srp_send_req(). 'sdev' is allocated and stored in srpt_add_one(). It's easy to show that sdev and req are always valid. So we remove unnecessary WARN_ON. Signed-off-by: Jing Xiangfeng --- drivers/infiniband/ulp/srpt/ib_srpt.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/u= lp/srpt/ib_srpt.c index ef7fcd3..0fa65c6 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -2156,9 +2156,6 @@ static int srpt_cm_req_recv(struct srpt_device *con= st sdev, =20 WARN_ON_ONCE(irqs_disabled()); =20 - if (WARN_ON(!sdev || !req)) - return -EINVAL; - it_iu_len =3D be32_to_cpu(req->req_it_iu_len); =20 pr_info("Received SRP_LOGIN_REQ with i_port_id %pI6, t_port_id %pI6 and= it_iu_len %d on port %d (guid=3D%pI6); pkey %#04x\n", --=20 1.8.3.1