From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75244C433E0 for ; Tue, 16 Jun 2020 18:36:07 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 1DB5A2098B for ; Tue, 16 Jun 2020 18:36:06 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="tj/iyfEL" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1DB5A2098B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7C01C6B0003; Tue, 16 Jun 2020 14:36:06 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 771166B0005; Tue, 16 Jun 2020 14:36:06 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 65F436B0006; Tue, 16 Jun 2020 14:36:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0225.hostedemail.com [216.40.44.225]) by kanga.kvack.org (Postfix) with ESMTP id 4C71E6B0003 for ; Tue, 16 Jun 2020 14:36:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id EE9C718466568 for ; Tue, 16 Jun 2020 18:36:05 +0000 (UTC) X-FDA: 76935929490.18.horn04_45126d826e01 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin18.hostedemail.com (Postfix) with ESMTP id A6329103461F4 for ; Tue, 16 Jun 2020 18:36:05 +0000 (UTC) X-HE-Tag: horn04_45126d826e01 X-Filterd-Recvd-Size: 2961 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf02.hostedemail.com (Postfix) with ESMTP for ; Tue, 16 Jun 2020 18:36:05 +0000 (UTC) Received: from X1 (nat-ab2241.sltdut.senawave.net [162.218.216.4]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 055CF2082F; Tue, 16 Jun 2020 18:36:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592332564; bh=ygQw5Actl08lZMVXKCgVgtsSty25n+2zY0/omqxOYLQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tj/iyfELOQfWQKfZYRlE+bdGM9rpxcBcCT5k+18bsKLbIcMYvt0geXm/Y2GCZ6gHl /pcjFwHd0tgR6+tSlfAbCRQaMGOS5Bx3jJ7ihplGFAa4kLKlCutasfZAl2vU8IGyja VnyuM91jARusgdgYCClFkpGRHOjtZdG+lshXmLVo= Date: Tue, 16 Jun 2020 11:36:01 -0700 From: Andrew Morton To: js1304@gmail.com Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Johannes Weiner , Rik van Riel , Minchan Kim , Michal Hocko , kernel-team@lge.com, Joonsoo Kim Subject: Re: [PATCH for v5.8 2/3] mm/swap: fix for "mm: workingset: age nonresident information alongside anonymous pages" Message-Id: <20200616113601.a8ab80635b6434efe43d2ffc@linux-foundation.org> In-Reply-To: <1592288204-27734-3-git-send-email-iamjoonsoo.kim@lge.com> References: <1592288204-27734-1-git-send-email-iamjoonsoo.kim@lge.com> <1592288204-27734-3-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A6329103461F4 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 16 Jun 2020 15:16:43 +0900 js1304@gmail.com wrote: > Subject: [PATCH for v5.8 2/3] mm/swap: fix for "mm: workingset: age nonresident information alongside anonymous pages" I'm having trouble locating such a patch. > Non-file-lru page could also be activated in mark_page_accessed() > and we need to count this activation for nonresident_age. > > Note that it's better for this patch to be squashed into the patch > "mm: workingset: age nonresident information alongside anonymous pages". > > Signed-off-by: Joonsoo Kim > --- > mm/swap.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/mm/swap.c b/mm/swap.c > index 667133d..c5d5114 100644 > --- a/mm/swap.c > +++ b/mm/swap.c > @@ -443,8 +443,7 @@ void mark_page_accessed(struct page *page) > else > __lru_cache_activate_page(page); > ClearPageReferenced(page); > - if (page_is_file_lru(page)) > - workingset_activation(page); > + workingset_activation(page); > } > if (page_is_idle(page)) > clear_page_idle(page); AFAICT this patch Fixes: a528910e12ec7ee ("mm: thrash detection-based file cache sizing")?