* [PATCH v2] IB/srpt: Remove WARN_ON from srpt_cm_req_recv
@ 2020-06-16 1:17 Jing Xiangfeng
2020-06-16 6:20 ` Leon Romanovsky
0 siblings, 1 reply; 2+ messages in thread
From: Jing Xiangfeng @ 2020-06-16 1:17 UTC (permalink / raw)
To: bvanassche, dledford, jgg
Cc: linux-rdma, target-devel, linux-kernel, linux-mm, jingxiangfeng
It's easy to show that sdev and req are always valid,
so we remove unnecessary WARN_ON.
Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
---
drivers/infiniband/ulp/srpt/ib_srpt.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
index ef7fcd3..0fa65c6 100644
--- a/drivers/infiniband/ulp/srpt/ib_srpt.c
+++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
@@ -2156,9 +2156,6 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev,
WARN_ON_ONCE(irqs_disabled());
- if (WARN_ON(!sdev || !req))
- return -EINVAL;
-
it_iu_len = be32_to_cpu(req->req_it_iu_len);
pr_info("Received SRP_LOGIN_REQ with i_port_id %pI6, t_port_id %pI6 and it_iu_len %d on port %d (guid=%pI6); pkey %#04x\n",
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v2] IB/srpt: Remove WARN_ON from srpt_cm_req_recv
2020-06-16 1:17 [PATCH v2] IB/srpt: Remove WARN_ON from srpt_cm_req_recv Jing Xiangfeng
@ 2020-06-16 6:20 ` Leon Romanovsky
0 siblings, 0 replies; 2+ messages in thread
From: Leon Romanovsky @ 2020-06-16 6:20 UTC (permalink / raw)
To: Jing Xiangfeng
Cc: bvanassche, dledford, jgg, linux-rdma, target-devel,
linux-kernel, linux-mm
On Tue, Jun 16, 2020 at 09:17:15AM +0800, Jing Xiangfeng wrote:
> It's easy to show that sdev and req are always valid,
> so we remove unnecessary WARN_ON.
So show it in the commit message, please.
>
> Signed-off-by: Jing Xiangfeng <jingxiangfeng@huawei.com>
> ---
> drivers/infiniband/ulp/srpt/ib_srpt.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index ef7fcd3..0fa65c6 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -2156,9 +2156,6 @@ static int srpt_cm_req_recv(struct srpt_device *const sdev,
>
> WARN_ON_ONCE(irqs_disabled());
>
> - if (WARN_ON(!sdev || !req))
> - return -EINVAL;
> -
> it_iu_len = be32_to_cpu(req->req_it_iu_len);
>
> pr_info("Received SRP_LOGIN_REQ with i_port_id %pI6, t_port_id %pI6 and it_iu_len %d on port %d (guid=%pI6); pkey %#04x\n",
> --
> 1.8.3.1
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-06-16 8:09 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-16 1:17 [PATCH v2] IB/srpt: Remove WARN_ON from srpt_cm_req_recv Jing Xiangfeng
2020-06-16 6:20 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox