From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EC923C433DF for ; Mon, 15 Jun 2020 15:02:18 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B85B72063A for ; Mon, 15 Jun 2020 15:02:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B85B72063A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4390C6B0005; Mon, 15 Jun 2020 11:02:18 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 3E94F6B0006; Mon, 15 Jun 2020 11:02:18 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2D6C16B000D; Mon, 15 Jun 2020 11:02:18 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0054.hostedemail.com [216.40.44.54]) by kanga.kvack.org (Postfix) with ESMTP id 136A46B0005 for ; Mon, 15 Jun 2020 11:02:18 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 50CC718B105 for ; Mon, 15 Jun 2020 15:02:17 +0000 (UTC) X-FDA: 76931761914.17.tub69_500be5d26df7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 8C93E1827E918 for ; Mon, 15 Jun 2020 15:01:56 +0000 (UTC) X-HE-Tag: tub69_500be5d26df7 X-Filterd-Recvd-Size: 5838 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Mon, 15 Jun 2020 15:01:33 +0000 (UTC) Received: by mail-wm1-f65.google.com with SMTP id u26so210779wmn.1 for ; Mon, 15 Jun 2020 08:01:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=b5qvOg57UADgLzf+akmZ9rdaUG21I31nx25QubBlwmU=; b=jLPGgM5x/R9p4Pf22UhiiTrf/oSKo/FiuUpDwPYjUpmgfNwY/3cFl9L/2QNJOxHcOg 34La9R1rMs1pcwFR5IogVtyOQN3Sbr51B2+WbKYKmIL4gk3uDcAtLCiAdEjJBogSE7Av aEinmEERhclm1IH6sgguHO4dgmaI7KbTXf21P63h3KlEQD+yWK4zLh9ZjJLD0dqp9pYQ rbRx64iYqWgixQG6BB9wwn8nATGebE4YvTWa3BTrjfu3suizdnNfqznQq3leLMqy6+sS Y+CAt45cZq2UCUBk40gO9td/zK8pe3S16Aih4ES5Wn44Ozwr6OtE5Pt11JW+M5ZK5UVa A/aA== X-Gm-Message-State: AOAM530mDhDFtFrTvBkBN5YUJGyn70fXAJ8Jg4DjVYXLM5nPatenzD+k NtFgpIzlithm28NBiu/Sk4avPM2R X-Google-Smtp-Source: ABdhPJy9VSpz3kEOLPJzTJYggxYQ0jplJOLKluJZv/AfUmoOv+0rtrfCSC4WAqGA4V1CHa6ojpRzKQ== X-Received: by 2002:a05:600c:c3:: with SMTP id u3mr12771377wmm.108.1592233291158; Mon, 15 Jun 2020 08:01:31 -0700 (PDT) Received: from localhost (ip-37-188-174-201.eurotel.cz. [37.188.174.201]) by smtp.gmail.com with ESMTPSA id d9sm24638967wre.28.2020.06.15.08.01.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 08:01:29 -0700 (PDT) Date: Mon, 15 Jun 2020 17:01:28 +0200 From: Michal Hocko To: Johannes Weiner Cc: Andrew Morton , Tejun Heo , Roman Gushchin , Chris Down , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-team@fb.com Subject: Re: [PATCH] mm: memcontrol: handle div0 crash race condition in memory.low Message-ID: <20200615150128.GL25296@dhcp22.suse.cz> References: <20200615140658.601684-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200615140658.601684-1-hannes@cmpxchg.org> X-Rspamd-Queue-Id: 8C93E1827E918 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon 15-06-20 10:06:58, Johannes Weiner wrote: > Tejun reports seeing rare div0 crashes in memory.low stress testing: > > [37228.504582] RIP: 0010:mem_cgroup_calculate_protection+0xed/0x150 > [37228.505059] Code: 0f 46 d1 4c 39 d8 72 57 f6 05 16 d6 42 01 40 74 1f 4c 39 d8 76 1a 4c 39 d1 76 15 4c 29 d1 4c 29 d8 4d 29 d9 31 d2 48 0f af c1 <49> f7 f1 49 01 c2 4c 89 96 38 01 00 00 5d c3 48 0f af c7 31 d2 49 > [37228.506254] RSP: 0018:ffffa14e01d6fcd0 EFLAGS: 00010246 > [37228.506769] RAX: 000000000243e384 RBX: 0000000000000000 RCX: 0000000000008f4b > [37228.507319] RDX: 0000000000000000 RSI: ffff8b89bee84000 RDI: 0000000000000000 > [37228.507869] RBP: ffffa14e01d6fcd0 R08: ffff8b89ca7d40f8 R09: 0000000000000000 > [37228.508376] R10: 0000000000000000 R11: 00000000006422f7 R12: 0000000000000000 > [37228.508881] R13: ffff8b89d9617000 R14: ffff8b89bee84000 R15: ffffa14e01d6fdb8 > [37228.509397] FS: 0000000000000000(0000) GS:ffff8b8a1f1c0000(0000) knlGS:0000000000000000 > [37228.509917] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > [37228.510442] CR2: 00007f93b1fc175b CR3: 000000016100a000 CR4: 0000000000340ea0 > [37228.511076] Call Trace: > [37228.511561] shrink_node+0x1e5/0x6c0 > [37228.512044] balance_pgdat+0x32d/0x5f0 > [37228.512521] kswapd+0x1d7/0x3d0 > [37228.513346] ? wait_woken+0x80/0x80 > [37228.514170] kthread+0x11c/0x160 > [37228.514983] ? balance_pgdat+0x5f0/0x5f0 > [37228.515797] ? kthread_park+0x90/0x90 > [37228.516593] ret_from_fork+0x1f/0x30 > > This happens when parent_usage == siblings_protected. We check that > usage is bigger than protected, which should imply parent_usage being > bigger than siblings_protected. However, we don't read (or even > update) these values atomically, and they can be out of sync as the > memory state changes under us. A bit of fluctuation around the target > protection isn't a big deal, but we need to handle the div0 case. > > Check the parent state explicitly to make sure we have a reasonable > positive value for the divisor. > > Fixes: 8a931f801340 ("mm: memcontrol: recursive memory.low protection") > Reported-by: Tejun Heo > Cc: > Signed-off-by: Johannes Weiner Acked-by: Michal Hocko > --- > mm/memcontrol.c | 9 +++++++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 0b38b6ad547d..5de0a9035b5f 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -6360,11 +6360,16 @@ static unsigned long effective_protection(unsigned long usage, > * We're using unprotected memory for the weight so that if > * some cgroups DO claim explicit protection, we don't protect > * the same bytes twice. > + * > + * Check both usage and parent_usage against the respective > + * protected values. One should imply the other, but they > + * aren't read atomically - make sure the division is sane. > */ > if (!(cgrp_dfl_root.flags & CGRP_ROOT_MEMORY_RECURSIVE_PROT)) > return ep; > - > - if (parent_effective > siblings_protected && usage > protected) { > + if (parent_effective > siblings_protected && > + parent_usage > siblings_protected && > + usage > protected) { > unsigned long unclaimed; > > unclaimed = parent_effective - siblings_protected; > -- > 2.26.2 -- Michal Hocko SUSE Labs