From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.0 required=3.0 tests=INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4319FC433E0 for ; Mon, 15 Jun 2020 11:50:12 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 0CC8320679 for ; Mon, 15 Jun 2020 11:50:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0CC8320679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 8C66E6B0005; Mon, 15 Jun 2020 07:50:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 876F66B0006; Mon, 15 Jun 2020 07:50:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 765166B0007; Mon, 15 Jun 2020 07:50:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0031.hostedemail.com [216.40.44.31]) by kanga.kvack.org (Postfix) with ESMTP id 5D7B96B0005 for ; Mon, 15 Jun 2020 07:50:11 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0AD693568 for ; Mon, 15 Jun 2020 11:50:11 +0000 (UTC) X-FDA: 76931277822.22.hill76_26124f226df6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id CD56918038E67 for ; Mon, 15 Jun 2020 11:50:10 +0000 (UTC) X-HE-Tag: hill76_26124f226df6 X-Filterd-Recvd-Size: 3282 Received: from mail-ed1-f66.google.com (mail-ed1-f66.google.com [209.85.208.66]) by imf46.hostedemail.com (Postfix) with ESMTP for ; Mon, 15 Jun 2020 11:50:10 +0000 (UTC) Received: by mail-ed1-f66.google.com with SMTP id w7so11295208edt.1 for ; Mon, 15 Jun 2020 04:50:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=+yej3bVZL44K62xgZNububEbDVqfkX9q5JcG1+/l7Jc=; b=B/K3RZXpg9kzikoEoP1gI387j6jBzvr7eXTyupiSMU5mYkCrl8IN8lp/vk3cf+GJBV UwX2HDJREzEES3TLpE7+xIaRaLaqIghtWox5gNOPmAU1embTWm+lFfUtn2HpoVBlipGR 3PGyfzJJRVle6JdlIJhapFXweBmh6KBjcnOxapu5uqxL8f52mWa9jT13/r3bEQTSnQQE Evy24BMXbWEPrGkTxbNHRZkjTlnbXR5kNzb/nHlYPPx8/zy7u7fJ/PbnMs6s6Jxw7oHy 0wSj57Kv8NUvqAnQ5/cAAlDfaNv4PskLuOud91xhseTZxHSve2gaja7CFzkwG8G20GSp wHHQ== X-Gm-Message-State: AOAM531tQ3LVkPd9h++w4QF3Vn7dZMAVJrnFxLUzrRbj7Ht2ujz/Ii6N z/TyIACXJzw5NzezrDSeXrw= X-Google-Smtp-Source: ABdhPJxTXOAUJWO+cQ1kN5xMafzmrUC0J7b1CqTCSIVBiaG/MZIqi3SY+cCxzo0reetQHnIS+CppLQ== X-Received: by 2002:a50:9ead:: with SMTP id a42mr22645629edf.129.1592221809349; Mon, 15 Jun 2020 04:50:09 -0700 (PDT) Received: from localhost (ip-37-188-174-201.eurotel.cz. [37.188.174.201]) by smtp.gmail.com with ESMTPSA id o20sm8733405ejx.102.2020.06.15.04.50.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 15 Jun 2020 04:50:08 -0700 (PDT) Date: Mon, 15 Jun 2020 13:50:07 +0200 From: Michal Hocko To: Muchun Song Cc: hannes@cmpxchg.org, vdavydov.dev@gmail.com, akpm@linux-foundation.org, guro@fb.com, cai@lca.pw, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: memcontrol: Fix do not put the css reference Message-ID: <20200615115007.GI25296@dhcp22.suse.cz> References: <20200614122653.98829-1-songmuchun@bytedance.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200614122653.98829-1-songmuchun@bytedance.com> X-Rspamd-Queue-Id: CD56918038E67 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.003027, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun 14-06-20 20:26:53, Muchun Song wrote: > We should put the css reference when memory allocation failed. > > Fixes: f0a3a24b532d ("mm: memcg/slab: rework non-root kmem_cache lifecycle management") > Signed-off-by: Muchun Song This looks like a stable tree material to me. Acked-by: Michal Hocko > --- > mm/memcontrol.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 0b38b6ad547d..2323d811ee8e 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -2772,8 +2772,10 @@ static void memcg_schedule_kmem_cache_create(struct mem_cgroup *memcg, > return; > > cw = kmalloc(sizeof(*cw), GFP_NOWAIT | __GFP_NOWARN); > - if (!cw) > + if (!cw) { > + css_put(&memcg->css); > return; > + } > > cw->memcg = memcg; > cw->cachep = cachep; > -- > 2.11.0 -- Michal Hocko SUSE Labs