From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10072C433DF for ; Mon, 15 Jun 2020 09:09:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D452E2068E for ; Mon, 15 Jun 2020 09:09:10 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D452E2068E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=huawei.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 61BE16B0002; Mon, 15 Jun 2020 05:09:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5CCF46B0003; Mon, 15 Jun 2020 05:09:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BB406B0005; Mon, 15 Jun 2020 05:09:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0134.hostedemail.com [216.40.44.134]) by kanga.kvack.org (Postfix) with ESMTP id 333096B0002 for ; Mon, 15 Jun 2020 05:09:10 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id E6CC8180AD807 for ; Mon, 15 Jun 2020 09:09:09 +0000 (UTC) X-FDA: 76930872018.16.edge46_2d000fd26df5 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin16.hostedemail.com (Postfix) with ESMTP id AB650100E5A51 for ; Mon, 15 Jun 2020 09:09:09 +0000 (UTC) X-HE-Tag: edge46_2d000fd26df5 X-Filterd-Recvd-Size: 2355 Received: from huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 15 Jun 2020 09:09:08 +0000 (UTC) Received: from DGGEMS401-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id E0CBB22AA912C8934AB8; Mon, 15 Jun 2020 17:09:01 +0800 (CST) Received: from localhost.localdomain.localdomain (10.175.113.25) by DGGEMS401-HUB.china.huawei.com (10.3.19.201) with Microsoft SMTP Server id 14.3.487.0; Mon, 15 Jun 2020 17:08:53 +0800 From: Jing Xiangfeng To: , , CC: , , , , Subject: [PATCH] IB/srpt: Fix a potential null pointer dereference Date: Mon, 15 Jun 2020 17:12:20 +0800 Message-ID: <20200615091220.6439-1-jingxiangfeng@huawei.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.175.113.25] X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: AB650100E5A51 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000001, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: In srpt_cm_req_recv(), it is possible that sdev is NULL, so we should test sdev before using it. Signed-off-by: Jing Xiangfeng --- drivers/infiniband/ulp/srpt/ib_srpt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/u= lp/srpt/ib_srpt.c index 98552749d71c..72053254bf84 100644 --- a/drivers/infiniband/ulp/srpt/ib_srpt.c +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c @@ -2143,7 +2143,7 @@ static int srpt_cm_req_recv(struct srpt_device *con= st sdev, const struct srp_login_req *req, const char *src_addr) { - struct srpt_port *sport =3D &sdev->port[port_num - 1]; + struct srpt_port *sport; struct srpt_nexus *nexus; struct srp_login_rsp *rsp =3D NULL; struct srp_login_rej *rej =3D NULL; @@ -2162,6 +2162,7 @@ static int srpt_cm_req_recv(struct srpt_device *con= st sdev, if (WARN_ON(!sdev || !req)) return -EINVAL; =20 + sport =3D &sdev->port[port_num - 1]; it_iu_len =3D be32_to_cpu(req->req_it_iu_len); =20 pr_info("Received SRP_LOGIN_REQ with i_port_id %pI6, t_port_id %pI6 and= it_iu_len %d on port %d (guid=3D%pI6); pkey %#04x\n", --=20 2.17.1