From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 02927C433E0 for ; Fri, 12 Jun 2020 19:33:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id B41A72063A for ; Fri, 12 Jun 2020 19:33:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="VkvjODgq" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B41A72063A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=ziepe.ca Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4D0508D00CF; Fri, 12 Jun 2020 15:33:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 480338D00A0; Fri, 12 Jun 2020 15:33:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3475B8D00CF; Fri, 12 Jun 2020 15:33:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0042.hostedemail.com [216.40.44.42]) by kanga.kvack.org (Postfix) with ESMTP id 1AB7E8D00A0 for ; Fri, 12 Jun 2020 15:33:30 -0400 (EDT) Received: from smtpin03.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C4F3F180AD83A for ; Fri, 12 Jun 2020 19:33:29 +0000 (UTC) X-FDA: 76921558938.03.sugar59_120796f26ddf Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin03.hostedemail.com (Postfix) with ESMTP id 9E7A828A4EB for ; Fri, 12 Jun 2020 19:33:29 +0000 (UTC) X-HE-Tag: sugar59_120796f26ddf X-Filterd-Recvd-Size: 3854 Received: from mail-qt1-f195.google.com (mail-qt1-f195.google.com [209.85.160.195]) by imf16.hostedemail.com (Postfix) with ESMTP for ; Fri, 12 Jun 2020 19:33:29 +0000 (UTC) Received: by mail-qt1-f195.google.com with SMTP id w9so8024388qtv.3 for ; Fri, 12 Jun 2020 12:33:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ilDpfLP00UQ/R2Qf9P0wZzkKtgSCxD5QrqZdUMpKWYs=; b=VkvjODgqREAtawgDZeQ7ZsFwjPhZbKTzE41/I2eqftpq3JrrVwIJnCV9Ij9Z9dEbWv wZngzt8TgRLvNgmGoEursjurAb4GIey9Qli78XcfmSbv4An3zgYWOAE7gU+kVWpsNdfB 3TLWhxtly/QipREUrKW7WpRPc5FSdbLrEfCKScTQUFGYM3BTSfsKha91Stq9nVqle70A Jpi/iaIVWzjqmHHk16CryrsMxa0OQg330KDohiM9Sru85yOL+lb1c9Q4nYcqZCUDSpJ2 SB+6t4p6BnFEZ3tFke9b22zLdzKbUfRmnImiuxfrLS328RETUS4AJ18dwwkycqz1tPoa RveA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ilDpfLP00UQ/R2Qf9P0wZzkKtgSCxD5QrqZdUMpKWYs=; b=ALXXJmfnntXpg/scLh/pyoKJBqOqPGD9YCvcVH5ekC835MtMZD4jRgBzbxPuzy0IBm bBMBmSYE0oUt0jpfIGpmARpUpPVovxLUjs+9rrPInsn1W7PXjWZbmlxdJEimbi6Tomdh 5l/3SgulVvuJpRC07EVyFBtsDfrz/c696dkR+0kzgN8+kZ20jXiUw5SbQCbWe6fBqAdb RElNb4za86jbnBNWrPjnxbi+X6mrdqBX1fRX9wLLeYK7+SSA7H0BWqvqAi/juHjAkRYb gaFi6dwwW6BLoGyQxnP0YrAL0ocEh1lGBtlPFXIDOP9t7fq+cP+/vIpwIOBa+s6jV/b5 RZiA== X-Gm-Message-State: AOAM533B3c+GFiRXRZZsd8hFE64Fu06XR/xf8ojxWhn7PMztPx2G44ph R/dEgBuO3OgWiPbzLQn8E+i5tA== X-Google-Smtp-Source: ABdhPJwMPxIjibTfvRe4j2ZYdS9q7vrAFVO+GODVRtFzo2l2ZrQQbsPBX7fWPrzGPBv99zpT3+EDfQ== X-Received: by 2002:ac8:2bba:: with SMTP id m55mr4587204qtm.171.1591990408530; Fri, 12 Jun 2020 12:33:28 -0700 (PDT) Received: from ziepe.ca (hlfxns017vw-156-34-48-30.dhcp-dynamic.fibreop.ns.bellaliant.net. [156.34.48.30]) by smtp.gmail.com with ESMTPSA id w94sm5260212qte.19.2020.06.12.12.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 12 Jun 2020 12:33:27 -0700 (PDT) Received: from jgg by mlx with local (Exim 4.93) (envelope-from ) id 1jjpQd-006lke-CN; Fri, 12 Jun 2020 16:33:27 -0300 Date: Fri, 12 Jun 2020 16:33:27 -0300 From: Jason Gunthorpe To: Ralph Campbell Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Jerome Glisse , John Hubbard , Christoph Hellwig , Andrew Morton Subject: Re: [PATCH] mm/hmm: remove redundant check non_swap_entry() Message-ID: <20200612193327.GZ6578@ziepe.ca> References: <20200612192618.32579-1-rcampbell@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200612192618.32579-1-rcampbell@nvidia.com> X-Rspamd-Queue-Id: 9E7A828A4EB X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Jun 12, 2020 at 12:26:18PM -0700, Ralph Campbell wrote: > In zap_pte_range(), the check for non_swap_entry() and > is_device_private_entry() is redundant since the latter is a subset of the > former. Remove the redundant check to simplify the code and for clarity. > > Signed-off-by: Ralph Campbell > > This is based on the current linux tree and is intended for Andrew's mm > tree. There is no rush so it could go into 5.9 but I think it is safe > enough to go into an rc after the patch is reviewed. Probably shouldn't mark it as mm/hmm if Andrew is going to pick it Reviewed-by: Jason Gunthorpe Jason