From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 223AFC433E0 for ; Thu, 11 Jun 2020 15:12:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id EB2A220691 for ; Thu, 11 Jun 2020 15:12:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EB2A220691 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 7C3298D009E; Thu, 11 Jun 2020 11:12:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 74DC98D0084; Thu, 11 Jun 2020 11:12:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63C018D009E; Thu, 11 Jun 2020 11:12:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 4899E8D0084 for ; Thu, 11 Jun 2020 11:12:00 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 083081E72A7 for ; Thu, 11 Jun 2020 15:12:00 +0000 (UTC) X-FDA: 76917271200.14.wall15_350b19726dd4 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 50DD21824CA73 for ; Thu, 11 Jun 2020 15:11:22 +0000 (UTC) X-HE-Tag: wall15_350b19726dd4 X-Filterd-Recvd-Size: 2024 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf11.hostedemail.com (Postfix) with ESMTP for ; Thu, 11 Jun 2020 15:11:21 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx2.suse.de (Postfix) with ESMTP id 4494FAD33; Thu, 11 Jun 2020 15:11:23 +0000 (UTC) Date: Thu, 11 Jun 2020 16:11:16 +0100 From: Mel Gorman To: Jaewon Kim Cc: Mel Gorman , Baoquan He , minchan@kernel.org, hannes@cmpxchg.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com, ytk.lee@samsung.com, cmlaika.kim@samsung.com Subject: Re: [PATCH] page_alloc: consider highatomic reserve in wmartermark fast Message-ID: <20200611151116.GE3129@suse.de> References: <20200609095128.8112-1-jaewon31.kim@samsung.com> <20200609142747.GA3346@MiWiFi-R3L-srv> <20200609151330.GL3127@techsingularity.net> <5EE18C38.3090601@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <5EE18C38.3090601@samsung.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Queue-Id: 50DD21824CA73 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 11, 2020 at 10:43:20AM +0900, Jaewon Kim wrote: > > That's fine, I simply wanted to illustrate where I thought the check > > should go to minimise the impact to the majority of allocations. > Hello Mel. > Can I understand that you also agrees on checking highatomic reserved? > Yes, I think it should be ok. > Additionally I've wondered why the number of highatomic free pages is not > accurately counted like cma free. Is there any concern on counting it? At the time, the cost of tracking it with 100% accuracy was not worth it due to a reliance on the pageblock types to protect the regions from other allocation types. -- Mel Gorman SUSE Labs