linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: Mel Gorman <mgorman@suse.de>
To: Jaewon Kim <jaewon31.kim@samsung.com>
Cc: Mel Gorman <mgorman@techsingularity.net>,
	Baoquan He <bhe@redhat.com>,
	minchan@kernel.org, hannes@cmpxchg.org,
	akpm@linux-foundation.org, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, jaewon31.kim@gmail.com,
	ytk.lee@samsung.com, cmlaika.kim@samsung.com
Subject: Re: [PATCH] page_alloc: consider highatomic reserve in wmartermark fast
Date: Thu, 11 Jun 2020 16:11:16 +0100	[thread overview]
Message-ID: <20200611151116.GE3129@suse.de> (raw)
In-Reply-To: <5EE18C38.3090601@samsung.com>

On Thu, Jun 11, 2020 at 10:43:20AM +0900, Jaewon Kim wrote:
> > That's fine, I simply wanted to illustrate where I thought the check
> > should go to minimise the impact to the majority of allocations.
> Hello Mel.
> Can I understand that you also agrees on checking highatomic reserved?
> 

Yes, I think it should be ok.

> Additionally I've wondered why the number of  highatomic free pages is not
> accurately counted like cma free. Is there any concern on counting it?

At the time, the cost of tracking it with 100% accuracy was not worth
it due to a reliance on the pageblock types to protect the regions from
other allocation types.

-- 
Mel Gorman
SUSE Labs


  reply	other threads:[~2020-06-11 15:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20200609095139epcas1p17f9c213de6daf25fe848921bc70481c0@epcas1p1.samsung.com>
2020-06-09  9:51 ` Jaewon Kim
2020-06-09 14:27   ` Baoquan He
2020-06-09 15:13     ` Mel Gorman
2020-06-11  1:43       ` Jaewon Kim
2020-06-11 15:11         ` Mel Gorman [this message]
2020-06-10  1:21   ` Minchan Kim
2020-06-11  8:54     ` Jaewon Kim
2020-06-12  6:55       ` Minchan Kim
2020-06-12  7:03         ` Jaewon Kim
2020-06-12  7:40           ` Minchan Kim
2020-06-12  7:55             ` Jaewon Kim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200611151116.GE3129@suse.de \
    --to=mgorman@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=cmlaika.kim@samsung.com \
    --cc=hannes@cmpxchg.org \
    --cc=jaewon31.kim@gmail.com \
    --cc=jaewon31.kim@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=minchan@kernel.org \
    --cc=ytk.lee@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox