From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07DC8C433E0 for ; Wed, 10 Jun 2020 08:42:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id C14E420812 for ; Wed, 10 Jun 2020 08:42:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="oIJl3PxA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C14E420812 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 4576D6B0024; Wed, 10 Jun 2020 04:42:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 407336B0025; Wed, 10 Jun 2020 04:42:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 31E036B0026; Wed, 10 Jun 2020 04:42:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0065.hostedemail.com [216.40.44.65]) by kanga.kvack.org (Postfix) with ESMTP id 1B5416B0024 for ; Wed, 10 Jun 2020 04:42:32 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CF1D6180AEF50 for ; Wed, 10 Jun 2020 08:42:31 +0000 (UTC) X-FDA: 76912660902.02.honey76_3b0eca426dc9 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id AA67B248D for ; Wed, 10 Jun 2020 08:42:31 +0000 (UTC) X-HE-Tag: honey76_3b0eca426dc9 X-Filterd-Recvd-Size: 3558 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf29.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Jun 2020 08:42:31 +0000 (UTC) Received: from kernel.org (unknown [87.70.26.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CD9A320734; Wed, 10 Jun 2020 08:42:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591778550; bh=wjjPmI+WG54Mz1EL7HwR233NE+u8BMlzD5wxbDmEoOM=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oIJl3PxAd6TD5nHzwj0UKLRZMXYmocYU4/TUG9EvAfB4xNNfdmxYRGV0shFVvn3Pk URWZzVLrf1BNkBqOD4VV3l4aP2i+WGka8F5JjZ7ztm7TgcoAaC8sYeVJSgWcFvTatG HPGyY4wcqKg3LD+WQrlEMnuJcnMtmBEjLG5R9qw0= Date: Wed, 10 Jun 2020 11:42:23 +0300 From: Mike Rapoport To: "Kirill A. Shutemov" Cc: Dave Hansen , Andy Lutomirski , Peter Zijlstra , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Dan Williams , Tony Luck , x86@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Dave Hansen , stable@vger.kernel.org Subject: Re: [PATCHv2 2/2] x86/boot/KASLR: Fix boot with some memory above MAXMEM Message-ID: <20200610084223.GE1151302@kernel.org> References: <20200608125424.70198-1-kirill.shutemov@linux.intel.com> <20200608125424.70198-3-kirill.shutemov@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200608125424.70198-3-kirill.shutemov@linux.intel.com> X-Rspamd-Queue-Id: AA67B248D X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 08, 2020 at 03:54:24PM +0300, Kirill A. Shutemov wrote: > A 5-level paging capable machine can have memory above 46-bit in the > physical address space. This memory is only addressable in the 5-level > paging mode: we don't have enough virtual address space to create direct > mapping for such memory in the 4-level paging mode > > Teach KASLR to avoid memory regions above MAXMEM or truncate the region > if the end is above MAXMEM. > > Signed-off-by: Kirill A. Shutemov > Reviewed-by: Dave Hansen > Cc: stable@vger.kernel.org # v4.14 Reviewed-by: Mike Rapoport > --- > arch/x86/boot/compressed/kaslr.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/x86/boot/compressed/kaslr.c b/arch/x86/boot/compressed/kaslr.c > index d7408af55738..99db18eeb40e 100644 > --- a/arch/x86/boot/compressed/kaslr.c > +++ b/arch/x86/boot/compressed/kaslr.c > @@ -695,7 +695,18 @@ static bool process_mem_region(struct mem_vector *region, > unsigned long long minimum, > unsigned long long image_size) > { > + unsigned long long end; > int i; > + > + /* Cannot access memory region above MAXMEM: skip it. */ > + if (region->start >= MAXMEM) > + return 0; > + > + /* Truncate the region if the end is above MAXMEM */ > + end = region->start + region->size; > + end = min_t(unsigned long long, end, MAXMEM - 1); > + region->size = end - region->start; > + > /* > * If no immovable memory found, or MEMORY_HOTREMOVE disabled, > * use @region directly. > -- > 2.26.2 > > -- Sincerely yours, Mike.