From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B5DFEC433DF for ; Wed, 10 Jun 2020 04:27:11 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 772C52074B for ; Wed, 10 Jun 2020 04:27:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 772C52074B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id F178B6B0002; Wed, 10 Jun 2020 00:27:10 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E783F6B0005; Wed, 10 Jun 2020 00:27:10 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D19A66B0006; Wed, 10 Jun 2020 00:27:10 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id B5EB36B0002 for ; Wed, 10 Jun 2020 00:27:10 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 6A29821E4 for ; Wed, 10 Jun 2020 04:27:10 +0000 (UTC) X-FDA: 76912017420.14.view19_2d0badc26dc8 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 3D3F618229835 for ; Wed, 10 Jun 2020 04:27:10 +0000 (UTC) X-HE-Tag: view19_2d0badc26dc8 X-Filterd-Recvd-Size: 6005 Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf44.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Jun 2020 04:27:09 +0000 (UTC) Received: from pps.filterd (m0098417.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 05A42i6T071244; Wed, 10 Jun 2020 00:27:07 -0400 Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0a-001b2d01.pphosted.com with ESMTP id 31jkrgg3yk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jun 2020 00:27:07 -0400 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 05A4P9bq013527; Wed, 10 Jun 2020 04:27:05 GMT Received: from b06cxnps4074.portsmouth.uk.ibm.com (d06relay11.portsmouth.uk.ibm.com [9.149.109.196]) by ppma04ams.nl.ibm.com with ESMTP id 31g2s7y147-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 10 Jun 2020 04:27:05 +0000 Received: from d06av24.portsmouth.uk.ibm.com (mk.ibm.com [9.149.105.60]) by b06cxnps4074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 05A4R35L43319394 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 10 Jun 2020 04:27:03 GMT Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 1510242041; Wed, 10 Jun 2020 04:27:03 +0000 (GMT) Received: from d06av24.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6F8E54203F; Wed, 10 Jun 2020 04:27:02 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.202.223]) by d06av24.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Wed, 10 Jun 2020 04:27:02 +0000 (GMT) Date: Wed, 10 Jun 2020 07:27:00 +0300 From: Mike Rapoport To: Andrew Morton Cc: kernel test robot , kbuild-all@lists.01.org, Johannes Weiner , Linux Memory Management List Subject: Re: [hnaz-linux-mm:master 60/194] include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel' Message-ID: <20200610042700.GI1149842@linux.ibm.com> References: <202006100010.WRBnCFU1%lkp@intel.com> <20200609152606.b08651fe680ee9c6e94540ad@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200609152606.b08651fe680ee9c6e94540ad@linux-foundation.org> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-06-09_14:2020-06-09,2020-06-09 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 adultscore=0 spamscore=0 suspectscore=0 clxscore=1015 impostorscore=0 mlxscore=0 bulkscore=0 priorityscore=1501 phishscore=0 cotscore=-2147483648 lowpriorityscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006100030 X-Rspamd-Queue-Id: 3D3F618229835 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Jun 09, 2020 at 03:26:06PM -0700, Andrew Morton wrote: > On Wed, 10 Jun 2020 00:12:12 +0800 kernel test robot wrote: > > > tree: https://github.com/hnaz/linux-mm master > > head: a017b085735719105714da692a82a6eeb8830718 > > commit: f48b9eb10f8c3f378ea4552fee58db3dea980e62 [60/194] mm: consolidate pte_index() and pte_offset_*() definitions > > config: sparc-defconfig (attached as .config) > > compiler: sparc-linux-gcc (GCC) 9.3.0 > > reproduce (this is a W=1 build): > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > > chmod +x ~/bin/make.cross > > git checkout f48b9eb10f8c3f378ea4552fee58db3dea980e62 > > # save the attached .config to linux build tree > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc > > > > If you fix the issue, kindly add following tag as appropriate > > Reported-by: kernel test robot > > > > All error/warnings (new ones prefixed by >>, old ones prefixed by <<): > > > > In file included from include/linux/mm.h:31, > > from include/linux/memblock.h:13, > > from arch/sparc/mm/srmmu.c:14: > > >> include/linux/pgtable.h:74:27: error: redefinition of 'pte_offset_kernel' > > 74 | #define pte_offset_kernel pte_offset_kernel > > | ^~~~~~~~~~~~~~~~~ > > >> arch/sparc/mm/srmmu.c:144:8: note: in expansion of macro 'pte_offset_kernel' > > 144 | pte_t *pte_offset_kernel(pmd_t *dir, unsigned long address) > > | ^~~~~~~~~~~~~~~~~ > > include/linux/pgtable.h:70:22: note: previous definition of 'pte_offset_kernel' was here > > 70 | static inline pte_t *pte_offset_kernel(pmd_t *pmd, unsigned long address) > > | ^~~~~~~~~~~~~~~~~ > > arch/sparc/mm/srmmu.c: In function 'poke_hypersparc': > > arch/sparc/mm/srmmu.c:1093:25: error: variable 'clear' set but not used [-Werror=unused-but-set-variable] > > 1093 | volatile unsigned long clear; > > Well dang. The function was supposed to have been removed but > obviously this was lost during all the merging messes. > > Mike, can you please confirm that this is still good? Yep, it is. > --- a/arch/sparc/mm/srmmu.c~a > +++ a/arch/sparc/mm/srmmu.c > @@ -140,16 +140,6 @@ void pmd_set(pmd_t *pmdp, pte_t *ptep) > set_pte((pte_t *)&pmd_val(*pmdp), __pte(SRMMU_ET_PTD | ptp)); > } > > -/* Find an entry in the third-level page table.. */ > -pte_t *pte_offset_kernel(pmd_t *dir, unsigned long address) > -{ > - void *pte; > - > - pte = __nocache_va((pmd_val(*dir) & SRMMU_PTD_PMASK) << 4); > - return (pte_t *) pte + > - ((address >> PAGE_SHIFT) & (PTRS_PER_PTE - 1)); > -} > - > /* > * size: bytes to allocate in the nocache area. > * align: bytes, number to align at. > _ > -- Sincerely yours, Mike.