From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.3 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_INVALID,DKIM_SIGNED,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F14E3C433DF for ; Wed, 10 Jun 2020 00:10:47 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A53CD206C3 for ; Wed, 10 Jun 2020 00:10:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LFfZUNi8" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A53CD206C3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 825866B0006; Tue, 9 Jun 2020 20:10:45 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 789796B0007; Tue, 9 Jun 2020 20:10:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 627676B0008; Tue, 9 Jun 2020 20:10:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0198.hostedemail.com [216.40.44.198]) by kanga.kvack.org (Postfix) with ESMTP id 4905D6B0006 for ; Tue, 9 Jun 2020 20:10:45 -0400 (EDT) Received: from smtpin22.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 0B0F38026627 for ; Wed, 10 Jun 2020 00:10:45 +0000 (UTC) X-FDA: 76911371250.22.smash30_080b5ec26dc6 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin22.hostedemail.com (Postfix) with ESMTP id D48FB18038E6A for ; Wed, 10 Jun 2020 00:10:44 +0000 (UTC) X-HE-Tag: smash30_080b5ec26dc6 X-Filterd-Recvd-Size: 12632 Received: from mail-qk1-f196.google.com (mail-qk1-f196.google.com [209.85.222.196]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Wed, 10 Jun 2020 00:10:44 +0000 (UTC) Received: by mail-qk1-f196.google.com with SMTP id l17so423034qki.9 for ; Tue, 09 Jun 2020 17:10:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=/dMfydSWonUg9mfgzw2qcad02rS/tmupfZbjho9gzOk=; b=LFfZUNi8KYLxKLoeh5Muzu+W7yAxntAbyGfQZFWsNxxVmcGOTS92vcvmnzeYohSZcH /oM831CmmG/I/XUcUOtwumFVQ/i6rlIHifxtYnE1L1ePd1HWMjI+IPth1kgAmnEDjY2K sU+DkW12oePz/UnzhrJwVzn5V96LXAbDEOcF/a2oubf3kuup60W81HEs3Vfkjx5jtobh zdU6XYxjfO/zd+6eR7rcfPta3wNwFZ9LF2XOn9sg2k5OnDHFicK98wgyztIgBixppn5t D/FSKruwpY5NTZVllJCEmzLgIDzkDbuCJCw6IJ7IQDijV4OBub7pLgIxwy5ueVrDXTC+ ohwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/dMfydSWonUg9mfgzw2qcad02rS/tmupfZbjho9gzOk=; b=MVYWGg9stmjTHzF1AWLwqtY7wDp/6N2Z3eDvKYg1q8qISjhCeg/T9JCz/jF7pMFNeK HcSkeisK40uPtkRToJG5B0qIaDtxuFopVbbaitFZBOuYjTeKalKpBYYWISnWTzq+nvn0 pPhsOwh7sDP9OOgx1/bqZFyAmtvm3Bq/NpR3j9bxww2eizxgP+0kOAC4e0yDumM2UUFS 6mHEUSWTyWC8uh7xOBMzM0Fa/iwnvXbpHSGMlKPSzcI3sCSY9b0CxqYPe5nZ22WYfxOR 3LaKQUQWuLPFX1gHjXRjeDTy+KioZOwj9Y4TIxgn+3M3Iwwg3O0T+y35Vydun95W7rxP OGNQ== X-Gm-Message-State: AOAM5330CCHJ/aUrnz66LuVgWLUrsIcoViKlZNBLE/kZqBRzS0BR8scE 4NhYz+3xcYjooBXG/96PIw== X-Google-Smtp-Source: ABdhPJyqAiXOWN5H0P7Nw0bjpdcGv5juI2ZnvBBUKoWl6ZIfyyI01O7489NYJUx4txdtXiSp9iW9+Q== X-Received: by 2002:a05:620a:21d3:: with SMTP id h19mr477322qka.375.1591747843638; Tue, 09 Jun 2020 17:10:43 -0700 (PDT) Received: from moria.home.lan ([2601:19b:c500:a1:7285:c2ff:fed5:c918]) by smtp.gmail.com with ESMTPSA id c2sm1757836qkl.58.2020.06.09.17.10.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 Jun 2020 17:10:43 -0700 (PDT) From: Kent Overstreet To: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, viro@zeniv.linux.org.uk, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org Cc: Kent Overstreet Subject: [PATCH 2/2] fs: generic_file_buffered_read() now uses find_get_pages_contig Date: Tue, 9 Jun 2020 20:10:36 -0400 Message-Id: <20200610001036.3904844-3-kent.overstreet@gmail.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200610001036.3904844-1-kent.overstreet@gmail.com> References: <20200610001036.3904844-1-kent.overstreet@gmail.com> MIME-Version: 1.0 X-Rspamd-Queue-Id: D48FB18038E6A X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Convert generic_file_buffered_read() to get pages to read from in batches, and then copy data to userspace from many pages at once - in particular, we now don't touch any cachelines that might be contended while we're in the loop to copy data to userspace. This is is a performance improvement on workloads that do buffered reads with large blocksizes, and a very large performance improvement if that file is also being accessed concurrently by different threads. On smaller reads (512 bytes), there's a very small performance improvement (1%, within the margin of error). Signed-off-by: Kent Overstreet --- mm/filemap.c | 266 ++++++++++++++++++++++++++++----------------------- 1 file changed, 144 insertions(+), 122 deletions(-) diff --git a/mm/filemap.c b/mm/filemap.c index 206d51a1c9..0d1836081c 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2051,67 +2051,6 @@ static void shrink_readahead_size_eio(struct file_= ra_state *ra) ra->ra_pages /=3D 4; } =20 -static int generic_file_buffered_read_page_ok(struct kiocb *iocb, - struct iov_iter *iter, - struct page *page) -{ - struct address_space *mapping =3D iocb->ki_filp->f_mapping; - struct inode *inode =3D mapping->host; - struct file_ra_state *ra =3D &iocb->ki_filp->f_ra; - unsigned offset =3D iocb->ki_pos & ~PAGE_MASK; - unsigned bytes, copied; - loff_t isize, end_offset; - - BUG_ON(iocb->ki_pos >> PAGE_SHIFT !=3D page->index); - - /* - * i_size must be checked after we know the page is Uptodate. - * - * Checking i_size after the check allows us to calculate - * the correct value for "bytes", which means the zero-filled - * part of the page is not copied back to userspace (unless - * another truncate extends the file - this is desired though). - */ - - isize =3D i_size_read(inode); - if (unlikely(iocb->ki_pos >=3D isize)) - return 1; - - end_offset =3D min_t(loff_t, isize, iocb->ki_pos + iter->count); - - bytes =3D min_t(loff_t, end_offset - iocb->ki_pos, PAGE_SIZE - offset); - - /* If users can be writing to this page using arbitrary - * virtual addresses, take care about potential aliasing - * before reading the page on the kernel side. - */ - if (mapping_writably_mapped(mapping)) - flush_dcache_page(page); - - /* - * Ok, we have the page, and it's up-to-date, so - * now we can copy it to user space... - */ - - copied =3D copy_page_to_iter(page, offset, bytes, iter); - - iocb->ki_pos +=3D copied; - - /* - * When a sequential read accesses a page several times, - * only mark it as accessed the first time. - */ - if (iocb->ki_pos >> PAGE_SHIFT !=3D ra->prev_pos >> PAGE_SHIFT) - mark_page_accessed(page); - - ra->prev_pos =3D iocb->ki_pos; - - if (copied < bytes) - return -EFAULT; - - return !iov_iter_count(iter) || iocb->ki_pos =3D=3D isize; -} - static struct page * generic_file_buffered_read_readpage(struct file *filp, struct address_space *mapping, @@ -2255,6 +2194,79 @@ generic_file_buffered_read_no_cached_page(struct k= iocb *iocb, return generic_file_buffered_read_readpage(filp, mapping, page); } =20 +static int generic_file_buffered_read_get_pages(struct kiocb *iocb, + struct iov_iter *iter, + struct page **pages, + unsigned nr) +{ + struct file *filp =3D iocb->ki_filp; + struct address_space *mapping =3D filp->f_mapping; + struct file_ra_state *ra =3D &filp->f_ra; + pgoff_t index =3D iocb->ki_pos >> PAGE_SHIFT; + pgoff_t last_index =3D (iocb->ki_pos + iter->count + PAGE_SIZE-1) >> PA= GE_SHIFT; + int i, j, ret, err =3D 0; + + nr =3D min_t(unsigned long, last_index - index, nr); +find_page: + if (fatal_signal_pending(current)) + return -EINTR; + + ret =3D find_get_pages_contig(mapping, index, nr, pages); + if (ret) + goto got_pages; + + if (iocb->ki_flags & IOCB_NOWAIT) + return -EAGAIN; + + page_cache_sync_readahead(mapping, ra, filp, index, last_index - index)= ; + + ret =3D find_get_pages_contig(mapping, index, nr, pages); + if (ret) + goto got_pages; + + pages[0] =3D generic_file_buffered_read_no_cached_page(iocb, iter); + err =3D PTR_ERR_OR_ZERO(pages[0]); + ret =3D !IS_ERR_OR_NULL(pages[0]); +got_pages: + for (i =3D 0; i < ret; i++) { + struct page *page =3D pages[i]; + pgoff_t pg_index =3D index +i; + loff_t pg_pos =3D max(iocb->ki_pos, + (loff_t) pg_index << PAGE_SHIFT); + loff_t pg_count =3D iocb->ki_pos + iter->count - pg_pos; + + if (PageReadahead(page)) + page_cache_async_readahead(mapping, ra, filp, page, + pg_index, last_index - pg_index); + + if (!PageUptodate(page)) { + if (iocb->ki_flags & IOCB_NOWAIT) { + for (j =3D i; j < ret; j++) + put_page(pages[j]); + ret =3D i; + err =3D -EAGAIN; + break; + } + + page =3D generic_file_buffered_read_pagenotuptodate(filp, + iter, page, pg_pos, pg_count); + if (IS_ERR_OR_NULL(page)) { + for (j =3D i + 1; j < ret; j++) + put_page(pages[j]); + ret =3D i; + err =3D PTR_ERR_OR_ZERO(page); + break; + } + } + } + + if (likely(ret)) + return ret; + if (err) + return err; + goto find_page; +} + /** * generic_file_buffered_read - generic file read routine * @iocb: the iocb to read @@ -2275,83 +2287,93 @@ static ssize_t generic_file_buffered_read(struct = kiocb *iocb, struct iov_iter *iter, ssize_t written) { struct file *filp =3D iocb->ki_filp; + struct file_ra_state *ra =3D &filp->f_ra; struct address_space *mapping =3D filp->f_mapping; struct inode *inode =3D mapping->host; - struct file_ra_state *ra =3D &filp->f_ra; size_t orig_count =3D iov_iter_count(iter); - pgoff_t last_index; - int error =3D 0; + struct page *pages[64]; + int i, pg_nr, error =3D 0; + bool writably_mapped; + loff_t isize, end_offset; =20 if (unlikely(iocb->ki_pos >=3D inode->i_sb->s_maxbytes)) return 0; iov_iter_truncate(iter, inode->i_sb->s_maxbytes); =20 - last_index =3D (iocb->ki_pos + iter->count + PAGE_SIZE-1) >> PAGE_SHIFT= ; - - for (;;) { - pgoff_t index =3D iocb->ki_pos >> PAGE_SHIFT; - struct page *page; - + do { cond_resched(); -find_page: - if (fatal_signal_pending(current)) { - error =3D -EINTR; - goto out; - } =20 - page =3D find_get_page(mapping, index); - if (!page) { - if (iocb->ki_flags & IOCB_NOWAIT) - goto would_block; - page_cache_sync_readahead(mapping, - ra, filp, - index, last_index - index); - page =3D find_get_page(mapping, index); - if (unlikely(page =3D=3D NULL)) { - page =3D generic_file_buffered_read_no_cached_page(iocb, iter); - if (!page) - goto find_page; - if (IS_ERR(page)) { - error =3D PTR_ERR(page); - goto out; - } - } - } - if (PageReadahead(page)) { - page_cache_async_readahead(mapping, - ra, filp, page, - index, last_index - index); + i =3D 0; + pg_nr =3D generic_file_buffered_read_get_pages(iocb, iter, pages, + ARRAY_SIZE(pages)); + if (pg_nr < 0) { + error =3D pg_nr; + break; } - if (!PageUptodate(page)) { - if (iocb->ki_flags & IOCB_NOWAIT) { - put_page(page); - error =3D -EAGAIN; - goto out; - } =20 - page =3D generic_file_buffered_read_pagenotuptodate(filp, - iter, page, iocb->ki_pos, iter->count); - if (!page) - goto find_page; - if (IS_ERR(page)) { - error =3D PTR_ERR(page); - goto out; - } - } + /* + * i_size must be checked after we know the pages are Uptodate. + * + * Checking i_size after the check allows us to calculate + * the correct value for "nr", which means the zero-filled + * part of the page is not copied back to userspace (unless + * another truncate extends the file - this is desired though). + */ + isize =3D i_size_read(inode); + if (unlikely(iocb->ki_pos >=3D isize)) + goto put_pages; =20 - error =3D generic_file_buffered_read_page_ok(iocb, iter, page); - put_page(page); + end_offset =3D min_t(loff_t, isize, iocb->ki_pos + iter->count); =20 - if (error) { - if (error > 0) - error =3D 0; - goto out; + while ((iocb->ki_pos >> PAGE_SHIFT) + pg_nr > + (end_offset + PAGE_SIZE - 1) >> PAGE_SHIFT) + put_page(pages[--pg_nr]); + + /* + * Once we start copying data, we don't want to be touching any + * cachelines that might be contended: + */ + writably_mapped =3D mapping_writably_mapped(mapping); + + /* + * When a sequential read accesses a page several times, only + * mark it as accessed the first time. + */ + if (iocb->ki_pos >> PAGE_SHIFT !=3D + ra->prev_pos >> PAGE_SHIFT) + mark_page_accessed(pages[0]); + for (i =3D 1; i < pg_nr; i++) + mark_page_accessed(pages[i]); + + for (i =3D 0; i < pg_nr; i++) { + unsigned offset =3D iocb->ki_pos & ~PAGE_MASK; + unsigned bytes =3D min_t(loff_t, end_offset - iocb->ki_pos, + PAGE_SIZE - offset); + unsigned copied; + + /* + * If users can be writing to this page using arbitrary + * virtual addresses, take care about potential aliasing + * before reading the page on the kernel side. + */ + if (writably_mapped) + flush_dcache_page(pages[i]); + + copied =3D copy_page_to_iter(pages[i], offset, bytes, iter); + + iocb->ki_pos +=3D copied; + ra->prev_pos =3D iocb->ki_pos; + + if (copied < bytes) { + error =3D -EFAULT; + break; + } } - } +put_pages: + for (i =3D 0; i < pg_nr; i++) + put_page(pages[i]); + } while (iov_iter_count(iter) && iocb->ki_pos < isize && !error); =20 -would_block: - error =3D -EAGAIN; -out: file_accessed(filp); written +=3D orig_count - iov_iter_count(iter); =20 --=20 2.27.0