From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A338CC433E0 for ; Mon, 8 Jun 2020 04:41:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 661B0206D5 for ; Mon, 8 Jun 2020 04:41:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="cB3sN+fU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 661B0206D5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 084A16B006E; Mon, 8 Jun 2020 00:41:08 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 010C36B0070; Mon, 8 Jun 2020 00:41:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E18CD6B0071; Mon, 8 Jun 2020 00:41:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0238.hostedemail.com [216.40.44.238]) by kanga.kvack.org (Postfix) with ESMTP id C2FA86B006E for ; Mon, 8 Jun 2020 00:41:07 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 8727A181ABEA2 for ; Mon, 8 Jun 2020 04:41:07 +0000 (UTC) X-FDA: 76904794974.15.apple40_57086a326db7 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 5D188181184CD for ; Mon, 8 Jun 2020 04:41:07 +0000 (UTC) X-HE-Tag: apple40_57086a326db7 X-Filterd-Recvd-Size: 3859 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Jun 2020 04:41:06 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DB2A720812; Mon, 8 Jun 2020 04:41:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591591266; bh=t/FGQI+bhYsea466FzWkW1pOnHrk+s2gxbNBaL2BPV8=; h=Date:From:To:Subject:In-Reply-To:From; b=cB3sN+fUW49byL1egS/07QSnABuFaQa4/LU65j8QQwtWKoo/XHQXdolJgVsXfeFex ZuilGIObKcS+Fg0xFJ17biJKmYgl/viIAaskyt8m3MdU2vXnGu8NkLEJoWhnKAocEH +Yd6YN5qyM3o5ablFudgC6XEQrmGS9SusUfq+fdM= Date: Sun, 07 Jun 2020 21:41:05 -0700 From: Andrew Morton To: akpm@linux-foundation.org, daniel@ffwll.ch, david@fromorbit.com, david@redhat.com, jack@suse.cz, jglisse@redhat.com, jhubbard@nvidia.com, jrdr.linux@gmail.com, linux-mm@kvack.org, mm-commits@vger.kernel.org, pankaj.gupta.linux@gmail.com, torvalds@linux-foundation.org, vbabka@suse.cz Subject: [patch 19/54] mm/gup: frame_vector: convert get_user_pages() --> pin_user_pages() Message-ID: <20200608044105.MIbT3ImsG%akpm@linux-foundation.org> In-Reply-To: <20200607212615.b050e41fac139a1e16fe00bd@linux-foundation.org> User-Agent: s-nail v14.8.16 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 5D188181184CD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam04 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: =46rom: John Hubbard Subject: mm/gup: frame_vector: convert get_user_pages() --> pin_user_pages() This code was using get_user_pages*(), and all of the callers so far were in a "Case 2" scenario (DMA/RDMA), using the categorization from [1].=20 That means that it's time to convert the get_user_pages*() + put_page() calls to pin_user_pages*() + unpin_user_pages() calls. There is some helpful background in [2]: basically, this is a small part of fixing a long-standing disconnect between pinning pages, and file systems' use of those pages. [1] Documentation/core-api/pin_user_pages.rst [2] "Explicit pinning of user-space pages": https://lwn.net/Articles/807108/ Link: http://lkml.kernel.org/r/20200527223243.884385-3-jhubbard@nvidia.com Signed-off-by: John Hubbard Acked-by: David Hildenbrand Cc: Daniel Vetter Cc: J=C3=A9r=C3=B4me Glisse Cc: Vlastimil Babka Cc: Jan Kara Cc: Dave Chinner Cc: Pankaj Gupta Cc: Souptick Joarder Signed-off-by: Andrew Morton --- mm/frame_vector.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) --- a/mm/frame_vector.c~mm-gup-frame_vector-convert-get_user_pages-pin_user= _pages +++ a/mm/frame_vector.c @@ -72,7 +72,7 @@ int get_vaddr_frames(unsigned long start if (!(vma->vm_flags & (VM_IO | VM_PFNMAP))) { vec->got_ref =3D true; vec->is_pfns =3D false; - ret =3D get_user_pages_locked(start, nr_frames, + ret =3D pin_user_pages_locked(start, nr_frames, gup_flags, (struct page **)(vec->ptrs), &locked); goto out; } @@ -122,7 +122,6 @@ EXPORT_SYMBOL(get_vaddr_frames); */ void put_vaddr_frames(struct frame_vector *vec) { - int i; struct page **pages; =20 if (!vec->got_ref) @@ -135,8 +134,8 @@ void put_vaddr_frames(struct frame_vecto */ if (WARN_ON(IS_ERR(pages))) goto out; - for (i =3D 0; i < vec->nr_frames; i++) - put_page(pages[i]); + + unpin_user_pages(pages, vec->nr_frames); vec->got_ref =3D false; out: vec->nr_frames =3D 0; _