From: Roman Gushchin <guro@fb.com>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Christoph Lameter <cl@linux.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@kernel.org>,
Shakeel Butt <shakeelb@google.com>, <linux-mm@kvack.org>,
<kernel-team@fb.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 17/19] mm: memcg/slab: use a single set of kmem_caches for all allocations
Date: Fri, 5 Jun 2020 11:17:00 -0700 [thread overview]
Message-ID: <20200605181700.GB561977@carbon.DHCP.thefacebook.com> (raw)
In-Reply-To: <d7cdecbc-db24-8ced-1a86-6f4534613763@suse.cz>
On Fri, Jun 05, 2020 at 06:24:33PM +0200, Vlastimil Babka wrote:
> On 5/28/20 12:34 AM, Roman Gushchin wrote:
> > diff --git a/mm/slab.h b/mm/slab.h
> > index c49a863adb63..57b425d623e5 100644
> > --- a/mm/slab.h
> > +++ b/mm/slab.h
> ...
> > @@ -526,8 +430,7 @@ static inline struct kmem_cache *cache_from_obj(struct kmem_cache *s, void *x)
> > * When kmemcg is not being used, both assignments should return the
> > * same value. but we don't want to pay the assignment price in that
> > * case. If it is not compiled in, the compiler should be smart enough
> > - * to not do even the assignment. In that case, slab_equal_or_root
> > - * will also be a constant.
> > + * to not do even the assignment.
> > */
> > if (!memcg_kmem_enabled() &&
>
> Just realized that this test can go away - we don't have to call virt_to_cache()
> due to kmemcg if there is just a single cache.
Good point, will remove it in v6.
Thanks!
>
> > !IS_ENABLED(CONFIG_SLAB_FREELIST_HARDENED) &&
> > @@ -535,7 +438,7 @@ static inline struct kmem_cache *cache_from_obj(struct kmem_cache *s, void *x)
> > return s;
> >
> > cachep = virt_to_cache(x);
> > - WARN_ONCE(cachep && !slab_equal_or_root(cachep, s),
> > + WARN_ONCE(cachep && cachep != s,
> > "%s: Wrong slab cache. %s but object is from %s\n",
> > __func__, s->name, cachep->name);
> > return cachep;
>
next prev parent reply other threads:[~2020-06-05 18:17 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 22:33 [PATCH v5 00/19] The new cgroup slab memory controller Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 01/19] mm: memcg: factor out memcg- and lruvec-level changes out of __mod_lruvec_state() Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 02/19] mm: memcg: prepare for byte-sized vmstat items Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 03/19] mm: memcg: convert vmstat slab counters to bytes Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 04/19] mm: slub: implement SLUB version of obj_to_index() Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 05/19] mm: memcontrol: decouple reference counting from page accounting Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 06/19] mm: memcg/slab: obj_cgroup API Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 07/19] mm: memcg/slab: allocate obj_cgroups for non-root slab pages Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 08/19] mm: memcg/slab: save obj_cgroup for non-root slab objects Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 09/19] mm: memcg/slab: charge individual slab objects instead of pages Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 10/19] mm: memcg/slab: deprecate memory.kmem.slabinfo Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 11/19] mm: memcg/slab: move memcg_kmem_bypass() to memcontrol.h Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 12/19] mm: memcg/slab: use a single set of kmem_caches for all accounted allocations Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 13/19] mm: memcg/slab: simplify memcg cache creation Roman Gushchin
2020-05-27 22:33 ` [PATCH v5 14/19] mm: memcg/slab: remove memcg_kmem_get_cache() Roman Gushchin
2020-05-27 22:34 ` [PATCH v5 15/19] mm: memcg/slab: deprecate slab_root_caches Roman Gushchin
2020-05-27 22:34 ` [PATCH v5 16/19] mm: memcg/slab: remove redundant check in memcg_accumulate_slabinfo() Roman Gushchin
2020-05-27 22:34 ` [PATCH v5 17/19] mm: memcg/slab: use a single set of kmem_caches for all allocations Roman Gushchin
2020-06-05 16:24 ` Vlastimil Babka
2020-06-05 18:17 ` Roman Gushchin [this message]
2020-05-27 22:34 ` [PATCH v5 18/19] kselftests: cgroup: add kernel memory accounting tests Roman Gushchin
2020-05-27 22:34 ` [PATCH v5 19/19] tools/cgroup: add memcg_slabinfo.py tool Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200605181700.GB561977@carbon.DHCP.thefacebook.com \
--to=guro@fb.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux.com \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=shakeelb@google.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox