From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66AC5C433E0 for ; Fri, 5 Jun 2020 09:39:31 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 20DFF207D0 for ; Fri, 5 Jun 2020 09:39:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=mymailcheap.com header.i=@mymailcheap.com header.b="z8y/Uewa"; dkim=pass (1024-bit key) header.d=flygoat.com header.i=@flygoat.com header.b="B5JBJHJG" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 20DFF207D0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=flygoat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 928B08E0007; Fri, 5 Jun 2020 05:39:30 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8D83E8E0006; Fri, 5 Jun 2020 05:39:30 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7EDBB8E0007; Fri, 5 Jun 2020 05:39:30 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0228.hostedemail.com [216.40.44.228]) by kanga.kvack.org (Postfix) with ESMTP id 68CEF8E0006 for ; Fri, 5 Jun 2020 05:39:30 -0400 (EDT) Received: from smtpin26.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 1A88687F1 for ; Fri, 5 Jun 2020 09:39:30 +0000 (UTC) X-FDA: 76894660500.26.rake89_410d81c26d9e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin26.hostedemail.com (Postfix) with ESMTP id EFE9E1804B663 for ; Fri, 5 Jun 2020 09:39:29 +0000 (UTC) X-HE-Tag: rake89_410d81c26d9e X-Filterd-Recvd-Size: 5329 Received: from relay3.mymailcheap.com (relay3.mymailcheap.com [217.182.119.155]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Fri, 5 Jun 2020 09:39:29 +0000 (UTC) Received: from filter2.mymailcheap.com (filter2.mymailcheap.com [91.134.140.82]) by relay3.mymailcheap.com (Postfix) with ESMTPS id 920AE3ECDF; Fri, 5 Jun 2020 11:39:27 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by filter2.mymailcheap.com (Postfix) with ESMTP id 714562A8B2; Fri, 5 Jun 2020 11:39:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=mymailcheap.com; s=default; t=1591349967; bh=Mc+KjRBNjHChZugfBRKNmW7QiUMUHq4bLRjFgN61C1k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=z8y/Uewab6ayLKQzwu/SmIq6I/LY0DlIitaA8ocevUcr8WvbeXSWqZL6D7TRws1t4 EEKOfQ1RLAK2HeV4SbGuRRrlY4/Jn8eyUTqMtagZfnU4XpED/mwv5N1lJAmZk7ce76 e7FU4X6b8svHI3WlBbGqetpBUuKygUFQJDnDK81E= X-Virus-Scanned: Debian amavisd-new at filter2.mymailcheap.com Received: from filter2.mymailcheap.com ([127.0.0.1]) by localhost (filter2.mymailcheap.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id nqLx46V5Ntsd; Fri, 5 Jun 2020 11:39:26 +0200 (CEST) Received: from mail20.mymailcheap.com (mail20.mymailcheap.com [51.83.111.147]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by filter2.mymailcheap.com (Postfix) with ESMTPS; Fri, 5 Jun 2020 11:39:26 +0200 (CEST) Received: from [148.251.23.173] (ml.mymailcheap.com [148.251.23.173]) by mail20.mymailcheap.com (Postfix) with ESMTP id 9A5CC40FC0; Fri, 5 Jun 2020 09:39:23 +0000 (UTC) Authentication-Results: mail20.mymailcheap.com; dkim=pass (1024-bit key; unprotected) header.d=flygoat.com header.i=@flygoat.com header.b="B5JBJHJG"; dkim-atps=neutral AI-Spam-Status: Not processed Received: from localhost (unknown [60.177.191.23]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail20.mymailcheap.com (Postfix) with ESMTPSA id 746EF40FC0; Fri, 5 Jun 2020 09:39:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=flygoat.com; s=default; t=1591349959; bh=Mc+KjRBNjHChZugfBRKNmW7QiUMUHq4bLRjFgN61C1k=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=B5JBJHJGNTVBAPlWuCkYxb56+3QNYhdHNdSzlbJh4cA5HresEMMGXO+zn1lFR1vVp vSB0tSMniQIhftXQgt0NpzRV7O44txfV7cda/ePLSLWn++CrZ1IJ52nICGUnwv6Dmb 4MNtOdZoO5T40dUwkN+Ed9YtX254a647/eiAl5Ec= Date: Fri, 5 Jun 2020 17:39:09 +0800 From: Jiaxun Yang To: Bibo Mao Cc: Thomas Bogendoerfer , Andrew Morton , Paul Burton , linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] MIPS: set page access bit with pgprot on some MIPS platform Message-ID: <20200605173909.000018ff@flygoat.com> In-Reply-To: <1591348266-28392-1-git-send-email-maobibo@loongson.cn> References: <1591348266-28392-1-git-send-email-maobibo@loongson.cn> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: EFE9E1804B663 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, 5 Jun 2020 17:11:05 +0800 Bibo Mao wrote: > On MIPS system which has rixi hardware bit, page access bit is not > set in pgrot. For memory reading, there will be one page fault to > allocate physical page; however valid bit is not set, there will > be the second fast tlb-miss fault handling to set valid/access bit. > > This patch set page access/valid bit with pgrot if there is reading > access privilege. It will reduce one tlb-miss handling for memory > reading access. > > The valid/access bit will be cleared in order to track memory > accessing activity. If the page is accessed, tlb-miss fast handling > will set valid/access bit, pte_sw_mkyoung is not necessary in slow > page fault path. This patch removes pte_sw_mkyoung function which > is defined as empty function except MIPS system. > > Signed-off-by: Bibo Mao > --- Thanks for tracking it down. Could you please make the patch tittle more clear? "Some" looks confuse to me, "systems with RIXI" would be better. - Jiaxun