From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FCD7C433E2 for ; Fri, 5 Jun 2020 09:26:05 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2B82920772 for ; Fri, 5 Jun 2020 09:26:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="Lf5zWp9b" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B82920772 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C8D788E0006; Fri, 5 Jun 2020 05:26:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BEC0980009; Fri, 5 Jun 2020 05:26:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A178E8E0007; Fri, 5 Jun 2020 05:26:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8B52A8E0006 for ; Fri, 5 Jun 2020 05:26:04 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 444D0180AD806 for ; Fri, 5 Jun 2020 09:26:04 +0000 (UTC) X-FDA: 76894626648.21.fan83_3e1742226d9e Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 2BD42180442C0 for ; Fri, 5 Jun 2020 09:26:04 +0000 (UTC) X-HE-Tag: fan83_3e1742226d9e X-Filterd-Recvd-Size: 3625 Received: from smtp-fw-2101.amazon.com (smtp-fw-2101.amazon.com [72.21.196.25]) by imf31.hostedemail.com (Postfix) with ESMTP for ; Fri, 5 Jun 2020 09:26:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1591349164; x=1622885164; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version; bh=2WYBB4tJ65ci6WfpvKb1NLkX6q8yNQyc7qNwaxapXxQ=; b=Lf5zWp9bkIfUII2ojfNzumAXHv30UviKuCVaitTz0k8gsy5vimJRV9Jb zA+fEVRqeyQSM0/UzVF8x+sthR4G0iwJNLwvv9LH0+IDCbMeyNY5OuKmI a8bCPb7h/pepSmPQAw6hq7iPb1XIcRz4MLNjIHJNjPqriOJYhkul+y73i s=; IronPort-SDR: sLgFbT17zN8xu0PccVFOh0/XP8F5DkdxKEahcNZsXW/JB8HaQfG0DM3P7xaj6T2aEDjzAHO6DN VwnBtOhiEpzw== X-IronPort-AV: E=Sophos;i="5.73,475,1583193600"; d="scan'208";a="34633948" Received: from iad12-co-svc-p1-lb1-vlan2.amazon.com (HELO email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com) ([10.43.8.2]) by smtp-border-fw-out-2101.iad2.amazon.com with ESMTP; 05 Jun 2020 09:26:03 +0000 Received: from EX13MTAUEA002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan3.iad.amazon.com [10.40.159.166]) by email-inbound-relay-1d-38ae4ad2.us-east-1.amazon.com (Postfix) with ESMTPS id C503EA1F10; Fri, 5 Jun 2020 09:26:01 +0000 (UTC) Received: from EX13D31EUA001.ant.amazon.com (10.43.165.15) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Jun 2020 09:25:45 +0000 Received: from u886c93fd17d25d.ant.amazon.com (10.43.162.200) by EX13D31EUA001.ant.amazon.com (10.43.165.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 5 Jun 2020 09:25:38 +0000 From: SeongJae Park To: CC: , , , SeongJae Park Subject: [PATCH 1/2] mm/page_idle.c: Skip offline pages Date: Fri, 5 Jun 2020 11:25:01 +0200 Message-ID: <20200605092502.18018-2-sjpark@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200605092502.18018-1-sjpark@amazon.com> References: <20200605092502.18018-1-sjpark@amazon.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.162.200] X-ClientProxiedBy: EX13D32UWB003.ant.amazon.com (10.43.161.220) To EX13D31EUA001.ant.amazon.com (10.43.165.15) X-Rspamd-Queue-Id: 2BD42180442C0 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam03 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: SeongJae Park 'Idle page tracking' users can pass random pfn that might be mapped to an offline page. To avoid accessing such pages, this commit modifies the 'page_idle_get_page()' to use 'pfn_to_online_page()' instead of 'pfn_valid()' and 'pfn_to_page()' combination, so that the pfn mapped to an offline page can be skipped. Signed-off-by: SeongJae Park Reported-by: David Hildenbrand --- mm/page_idle.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/mm/page_idle.c b/mm/page_idle.c index 295512465065..057c61df12db 100644 --- a/mm/page_idle.c +++ b/mm/page_idle.c @@ -4,6 +4,7 @@ #include #include #include +#include #include #include #include @@ -30,13 +31,9 @@ */ static struct page *page_idle_get_page(unsigned long pfn) { - struct page *page; + struct page *page = pfn_to_online_page(pfn); pg_data_t *pgdat; - if (!pfn_valid(pfn)) - return NULL; - - page = pfn_to_page(pfn); if (!page || !PageLRU(page) || !get_page_unless_zero(page)) return NULL; -- 2.17.1