From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1FA8EC433DF for ; Thu, 4 Jun 2020 13:39:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id D85D5207DF for ; Thu, 4 Jun 2020 13:39:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ptx/FA/q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D85D5207DF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6CAD080007; Thu, 4 Jun 2020 09:39:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 67B308E0006; Thu, 4 Jun 2020 09:39:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B7CC80007; Thu, 4 Jun 2020 09:39:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0132.hostedemail.com [216.40.44.132]) by kanga.kvack.org (Postfix) with ESMTP id 45FFF8E0006 for ; Thu, 4 Jun 2020 09:39:48 -0400 (EDT) Received: from smtpin28.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 0786E28DAB for ; Thu, 4 Jun 2020 13:39:48 +0000 (UTC) X-FDA: 76891637256.28.desk28_8fb843c091f38 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin28.hostedemail.com (Postfix) with ESMTP id DB7A3A8C7 for ; Thu, 4 Jun 2020 13:39:47 +0000 (UTC) X-HE-Tag: desk28_8fb843c091f38 X-Filterd-Recvd-Size: 4134 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Jun 2020 13:39:47 +0000 (UTC) Received: by mail-pj1-f68.google.com with SMTP id jz3so1150318pjb.0 for ; Thu, 04 Jun 2020 06:39:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=xdNQxpJtISS4o6vSnha6RqnWoqxwne3xIxfhUtiWq4E=; b=ptx/FA/q9YK7emZal29VXFiq66Cn4ubmP6hwI1j4dhV3pxqqiLfOUbMobRWvthzHZb cxRSI1jNNmFd2mZklBhaBtQRD9dRF51IKgNb7cYHHhg/ahGEkSbMZRMMy8eJmPjndFkI yqFUTixfSpF4hhHVpdDRJ+J42RKcnJ7L1VDzzvOHN+xb9yDpEqH5Z+KeXGZUXLMY7OfK qpffryyj4QpWRsPzhboYUn64kraRv16xhPtE1PGBUKWEsSRxJ9tRN+BsFOqI+u32uR/S bOXNCVMBSO7vF7uItTIZit2rpUYVvBWkaAZ2U2rZMN5LcP4gSY34WsMWcOzFTHNMcITU umTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=xdNQxpJtISS4o6vSnha6RqnWoqxwne3xIxfhUtiWq4E=; b=PoGRElR0V+MYcyurmUh+dDISHFYOOPtXA2UPNPb0kRm1E1Nt0rQpGkIF2acwLmJecp BRrk8DWXHGcZbR0IgCRIGZsrVAGrh8FcjttSRlStD6p1PbLTkS/tARXxjqN4h7goybdd HXHEAw/IwneW66uSqcdL3ThKbnIUjb496aZfiSKZs3j6qSeAOwzdE1y5gJ3LENXTCkT8 5ABDWBHcwsS0zmDrFFhJ8XhJdrOPDFdMF5lXlzXfkCk5Qd83dXoA2pme2gEwwHLEYIcE wbhGZEP9gYiJm3HCfswjl2HTQS42ZZcRYLE0WgarWyUHCdG87Ej3rpRbk5p2cUEGbAm4 srhg== X-Gm-Message-State: AOAM531CENYglI9PGA4/g8XgpjMnYRNqA0xahxTzB21HaLiOWgDs6GRV XWlXG2x9VX1J+H+ISvklm4I= X-Google-Smtp-Source: ABdhPJyBfnbbCHIbmuWMniemDoympvaIcAtkiJiRkKf1Fxtt+P7S3ZcDVwGn7XVdmSCe/cyz3YASow== X-Received: by 2002:a17:902:a714:: with SMTP id w20mr4957921plq.125.1591277986510; Thu, 04 Jun 2020 06:39:46 -0700 (PDT) Received: from cosmos ([122.171.238.207]) by smtp.gmail.com with ESMTPSA id o25sm4069265pgn.84.2020.06.04.06.39.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 04 Jun 2020 06:39:46 -0700 (PDT) Date: Thu, 4 Jun 2020 19:09:42 +0530 From: Vamshi K Sthambamkadi To: akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: [PATCH] mm/memory_hotplug: fix default_zone_for_pfn() to include highmem zone range Message-ID: <20200604133938.GA1513@cosmos> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.5.24 (2015-08-30) X-Rspamd-Queue-Id: DB7A3A8C7 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On x86_32, while onlining highmem sections, the func default_zone_for_pfn() defaults target zone to ZONE_NORMAL (movable_node_enabled = 0). Onlining of pages is successful, and these highmem pages are moved into zone_normal. As a consequence, these pages are treated as low mem, and page addresses are calculated using lowmem_page_address() which effectively overflows the 32 bit virtual addresses, leading to kernel panics and system becomes unusable. Change default_kernel_zone_for_pfn() to intersect highmem pfn range, and calculate the default zone accordingly. Signed-off-by: Vamshi K Sthambamkadi --- mm/memory_hotplug.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c index c4d5c45..30f101a 100644 --- a/mm/memory_hotplug.c +++ b/mm/memory_hotplug.c @@ -725,8 +725,13 @@ static struct zone *default_kernel_zone_for_pfn(int nid, unsigned long start_pfn { struct pglist_data *pgdat = NODE_DATA(nid); int zid; + int nr_zones = ZONE_NORMAL; - for (zid = 0; zid <= ZONE_NORMAL; zid++) { +#ifdef CONFIG_HIGHMEM + nr_zones = ZONE_HIGHMEM; +#endif + + for (zid = 0; zid <= nr_zones; zid++) { struct zone *zone = &pgdat->node_zones[zid]; if (zone_intersects(zone, start_pfn, nr_pages)) -- 2.7.4