From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 454A2C433E1 for ; Thu, 4 Jun 2020 14:27:49 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E354D207F5 for ; Thu, 4 Jun 2020 14:27:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="e7eITrZA" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E354D207F5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3FA2F80007; Thu, 4 Jun 2020 10:27:48 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 384548E0006; Thu, 4 Jun 2020 10:27:48 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 24C9D80007; Thu, 4 Jun 2020 10:27:48 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0117.hostedemail.com [216.40.44.117]) by kanga.kvack.org (Postfix) with ESMTP id 07F6B8E0006 for ; Thu, 4 Jun 2020 10:27:48 -0400 (EDT) Received: from smtpin14.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id BB77C801926A for ; Thu, 4 Jun 2020 14:27:47 +0000 (UTC) X-FDA: 76891758174.14.dad99_7e2d276218506 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin14.hostedemail.com (Postfix) with ESMTP id 90C261809E1DA for ; Thu, 4 Jun 2020 14:27:47 +0000 (UTC) X-HE-Tag: dad99_7e2d276218506 X-Filterd-Recvd-Size: 4326 Received: from mail-pl1-f193.google.com (mail-pl1-f193.google.com [209.85.214.193]) by imf08.hostedemail.com (Postfix) with ESMTP for ; Thu, 4 Jun 2020 14:27:46 +0000 (UTC) Received: by mail-pl1-f193.google.com with SMTP id y11so2231539plt.12 for ; Thu, 04 Jun 2020 07:27:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=ELp8NKpDU/b4oaZzGkEuk3yIxekW0FfVsfMh0kEq3DQ=; b=e7eITrZAAG4SVhaatsNGEFfKSAV4mgFFeMordqmQufFe6/vzeagmQ484X5shPhREQO NcIW+cQNizrMWNfglE0Jh5V6uWSzvceN4EXsYppzfKNVQcK2K6MGcm3eAbNC9iODqDY1 7i/uriuA9VGz8WZ62VSr78LapWZNk/5N3ydBE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=ELp8NKpDU/b4oaZzGkEuk3yIxekW0FfVsfMh0kEq3DQ=; b=RCpJ9l2qI0gDueS0x68DlHTZ4t7yrBqbLRp7WTNHPyL/8q6Ue1/DyGbe+XUslkGJ0I pv2VDpqFUjtEPHosgGcjpUoStuMbz3k1untaWRU3JHtzymGIBVMf/rCkXy4tIJ1IBBfg P1wkVxXoo0JISnOtgpoK1l0tk6PJ0EeD7+alJyFs3VISd8bQdFdjddoMpjrsLR1TE5OT ewJKvh0vlavn4+a+iL8lSa2OtAVSbzDE6NkR3SiiJrMo0sTvhfTIlKHN1yEzLJUm2sXV K85uhnGR0q5iOtaYXd7XKCVyzS3x4uWz55NANNMLYHQkT61SDylkHKr8XbixvoFV2s19 REMg== X-Gm-Message-State: AOAM531M7rGxdtTrf47dNrVbDa7mHdNo0Y27OS8ybDFFXNuHhqdc7xxj eFPkvsoEgVhmOYD5dspefXD31w== X-Google-Smtp-Source: ABdhPJyh46iXXKU9Sh1DXTFOzkFXYm4paCXLSWoWqbxFRDWCjy8xbqFVrhjjddGEPZlvsY+JnIndAg== X-Received: by 2002:a17:90b:188d:: with SMTP id mn13mr6391960pjb.84.1591280865425; Thu, 04 Jun 2020 07:27:45 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id j15sm5944936pjj.12.2020.06.04.07.27.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jun 2020 07:27:44 -0700 (PDT) Date: Thu, 4 Jun 2020 07:27:42 -0700 From: Kees Cook To: Sedat Dilek Cc: Nathan Chancellor , linux-kernel@vger.kernel.org, Linus Torvalds , Miguel Ojeda , Alexander Potapenko , Joe Perches , Andy Whitcroft , x86@kernel.org, drbd-dev@lists.linbit.com, linux-block@vger.kernel.org, b43-dev@lists.infradead.org, netdev@vger.kernel.org, linux-wireless@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-spi@vger.kernel.org, linux-mm@kvack.org, Clang-Built-Linux ML Subject: Re: [PATCH 00/10] Remove uninitialized_var() macro Message-ID: <202006040727.265B0E586@keescook> References: <20200603233203.1695403-1-keescook@chromium.org> <20200604033347.GA3962068@ubuntu-n2-xlarge-x86> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Queue-Id: 90C261809E1DA X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, Jun 04, 2020 at 09:26:58AM +0200, Sedat Dilek wrote: > On Thu, Jun 4, 2020 at 5:33 AM Nathan Chancellor > wrote: > > > > On Wed, Jun 03, 2020 at 04:31:53PM -0700, Kees Cook wrote: > > > Using uninitialized_var() is dangerous as it papers over real bugs[1] > > > (or can in the future), and suppresses unrelated compiler warnings > > > (e.g. "unused variable"). If the compiler thinks it is uninitialized, > > > either simply initialize the variable or make compiler changes. > > > > > > As recommended[2] by[3] Linus[4], remove the macro. > > [...] > > For the series, consider it: > > > > Tested-by: Nathan Chancellor [build] > [...] > > I tried with updated version (checkpatch) of your tree and see no > (new) warnings in my build-log. > > Feel free to add my... > > Tested-by: Sedat Dilek Awesome! Thank you both! :) -- Kees Cook