From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 98699C433DF for ; Wed, 3 Jun 2020 16:10:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 59B25205CB for ; Wed, 3 Jun 2020 16:10:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="CkSq+MeP" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 59B25205CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E066E80008; Wed, 3 Jun 2020 12:10:16 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id DB68C8E0006; Wed, 3 Jun 2020 12:10:16 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CA57D80008; Wed, 3 Jun 2020 12:10:16 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0109.hostedemail.com [216.40.44.109]) by kanga.kvack.org (Postfix) with ESMTP id AF8838E0006 for ; Wed, 3 Jun 2020 12:10:16 -0400 (EDT) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 78B4B80222CD for ; Wed, 3 Jun 2020 16:10:16 +0000 (UTC) X-FDA: 76888387632.07.step35_599a7da30a924 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin07.hostedemail.com (Postfix) with ESMTP id 543F818033D16 for ; Wed, 3 Jun 2020 16:10:16 +0000 (UTC) X-HE-Tag: step35_599a7da30a924 X-Filterd-Recvd-Size: 5125 Received: from userp2120.oracle.com (userp2120.oracle.com [156.151.31.85]) by imf17.hostedemail.com (Postfix) with ESMTP for ; Wed, 3 Jun 2020 16:10:15 +0000 (UTC) Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 053G2ZaW174548; Wed, 3 Jun 2020 16:10:07 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=7IsA5VW1Zg1DgEuhycSVbfO4BwikUQw+wlbXCIQb/7Y=; b=CkSq+MePI0NOwIfe34RP6fn/SRURzkGbFrYQcpsLHhQKw21ivXkE0CEk3sDOkbiJP9Zc 7KUALeVsIcnppHdE6cHfjt6L34fjrF86cABJWh5k2X1dFU44Bq+f+RnGjDnVn6RJvL7j CtlImTVgphHSm5fuiVfX4ZlZmiKnxaCREW4YhiTqP9j5tLi47iTlBtp7oxvSKgOx7soT G7ER8ycztdchPehc8Gk3pclN4XSUFHr0oJYcZu2et/1PYuP5Ov9Hxc7rmhf12+D5bSqt iLudbgrOv/YqbZlmGhTK6YVuTzNrrLj38vwKrJnf8qBAlYpLT8kMPOBybDpLnXcmHrCJ Fg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 31ef1ng177-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Wed, 03 Jun 2020 16:10:07 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 053G7S2M078237; Wed, 3 Jun 2020 16:08:06 GMT Received: from aserv0121.oracle.com (aserv0121.oracle.com [141.146.126.235]) by aserp3030.oracle.com with ESMTP id 31c12r3yh5-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 03 Jun 2020 16:08:05 +0000 Received: from abhmp0012.oracle.com (abhmp0012.oracle.com [141.146.116.18]) by aserv0121.oracle.com (8.14.4/8.13.8) with ESMTP id 053G83k9027868; Wed, 3 Jun 2020 16:08:03 GMT Received: from ca-dmjordan1.us.oracle.com (/10.211.9.48) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Wed, 03 Jun 2020 09:08:03 -0700 Date: Wed, 3 Jun 2020 12:08:28 -0400 From: Daniel Jordan To: Anshuman Khandual Cc: Daniel Jordan , John Hubbard , linux-mm@kvack.org, hughd@google.com, Naoya Horiguchi , Zi Yan , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm/vmstat: Add events for PMD based THP migration without split Message-ID: <20200603160828.2sfuyjpyyc2bpuan@ca-dmjordan1.us.oracle.com> References: <1590118444-21601-1-git-send-email-anshuman.khandual@arm.com> <20200601165736.qw5kwwknxltk7bv6@ca-dmjordan1.us.oracle.com> <0a936ec7-f44f-1d72-915f-f5758d25fd72@nvidia.com> <1e71d815-5359-3ebe-5d2b-5a3b54b63b51@arm.com> <274be3bf-2206-5e98-8114-1d91fac472c9@nvidia.com> <20200602145208.qucum52lwslhiqff@ca-dmjordan1.us.oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9641 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 suspectscore=0 spamscore=0 bulkscore=0 mlxlogscore=999 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006030128 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9641 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 clxscore=1015 malwarescore=0 priorityscore=1501 impostorscore=0 spamscore=0 suspectscore=0 bulkscore=0 phishscore=0 adultscore=0 lowpriorityscore=0 mlxscore=0 cotscore=-2147483648 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006030127 X-Rspamd-Queue-Id: 543F818033D16 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jun 03, 2020 at 10:06:31AM +0530, Anshuman Khandual wrote: > Does this look okay and sufficient ? > > --- a/Documentation/vm/page_migration.rst > +++ b/Documentation/vm/page_migration.rst > @@ -253,5 +253,20 @@ which are function pointers of struct address_space_operations. > PG_isolated is alias with PG_reclaim flag so driver shouldn't use the flag > for own purpose. > > +Quantifying Migration > +===================== > +Following events can be used to quantify page migration. > + > +- PGMIGRATE_SUCCESS > +- PGMIGRATE_FAIL > +- THP_MIGRATION_SUCCESS > +- THP_MIGRATION_FAILURE > + > +THP_MIGRATION_FAILURE in particular represents an event when a THP could not be > +migrated as a single entity following an allocation failure and ended up getting > +split into constituent normal pages before being retried. This event, along with > +PGMIGRATE_SUCCESS and PGMIGRATE_FAIL will help in quantifying and analyzing THP > +migration events including both success and failure cases. Looks great! > Sure, will update the commit message accordingly. Thanks. Hopefully these will help someone in the future.