From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E27F4C433E0 for ; Tue, 2 Jun 2020 16:23:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 894072067B for ; Tue, 2 Jun 2020 16:23:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="GkgO5Unv" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 894072067B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=oracle.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D85B080007; Tue, 2 Jun 2020 12:23:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D360D8E0006; Tue, 2 Jun 2020 12:23:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C246380007; Tue, 2 Jun 2020 12:23:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0154.hostedemail.com [216.40.44.154]) by kanga.kvack.org (Postfix) with ESMTP id AB4F88E0006 for ; Tue, 2 Jun 2020 12:23:40 -0400 (EDT) Received: from smtpin20.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 42A0E653A3 for ; Tue, 2 Jun 2020 16:23:40 +0000 (UTC) X-FDA: 76884792600.20.game42_28eafed11332 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin20.hostedemail.com (Postfix) with ESMTP id 54C24180C0BC8 for ; Tue, 2 Jun 2020 16:23:38 +0000 (UTC) X-HE-Tag: game42_28eafed11332 X-Filterd-Recvd-Size: 5783 Received: from userp2130.oracle.com (userp2130.oracle.com [156.151.31.86]) by imf13.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Jun 2020 16:23:37 +0000 (UTC) Received: from pps.filterd (userp2130.oracle.com [127.0.0.1]) by userp2130.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 052GLt7R192089; Tue, 2 Jun 2020 16:23:20 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=Y5LdSgBmJ2jbl4KvvXpeOA/MkXso/O6fdO5mSUzOdjw=; b=GkgO5UnvzPFh3X3pBSu/fmAAdi6lrwUApwMVxMDyjF3ry4q6k3+AZv7aH2JdpEUmG+lu l5S8G8Z4XG0g2wWCBBdvfuVn/nudS3APMMTNDtyvprEBoH8cB2HC9eaKufD1psPCnHOM T/fLEU+CwMQMXbCJWAIAFde9CiNA8smjUnYgh8/aZ2snd8q7jsKEu7kjuNhomeU4aZFH ITc7F64jkxjJ5hMjXh4Aj0TOscf8s5PCaHjjo+gKS+NSt2fWvpi9PekP5qNbkc+VLgy9 Cx4gFRa/Hf16S0aDP8k53lRoTHqbmY+qAILIYtlJyU1TZNeMZ40y95ocXq8KtBseY8Dw vA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2130.oracle.com with ESMTP id 31bewqw0xe-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Tue, 02 Jun 2020 16:23:20 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 052GHPwB059450; Tue, 2 Jun 2020 16:23:19 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 31c12pgh94-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 02 Jun 2020 16:23:19 +0000 Received: from abhmp0014.oracle.com (abhmp0014.oracle.com [141.146.116.20]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 052GNHWf018941; Tue, 2 Jun 2020 16:23:17 GMT Received: from localhost (/67.169.218.210) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 02 Jun 2020 09:23:16 -0700 Date: Tue, 2 Jun 2020 09:23:15 -0700 From: "Darrick J. Wong" To: Andrew Morton Cc: david@fromorbit.com, guoqing.jiang@cloud.ionos.com, hch@infradead.org, linux-mm@kvack.org, mm-commits@vger.kernel.org, torvalds@linux-foundation.org Subject: Re: [patch 044/128] iomap: use attach/detach_page_private Message-ID: <20200602162315.GC8204@magnolia> References: <20200601214457.919c35648e96a2b46b573fe1@linux-foundation.org> <20200602044754.UTp724lWN%akpm@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200602044754.UTp724lWN%akpm@linux-foundation.org> X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9640 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 malwarescore=0 adultscore=0 suspectscore=2 spamscore=0 bulkscore=0 mlxlogscore=980 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006020116 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9640 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 priorityscore=1501 bulkscore=0 phishscore=0 suspectscore=2 impostorscore=0 cotscore=-2147483648 lowpriorityscore=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=999 malwarescore=0 clxscore=1011 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2006020116 X-Rspamd-Queue-Id: 54C24180C0BC8 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jun 01, 2020 at 09:47:54PM -0700, Andrew Morton wrote: > From: Guoqing Jiang > Subject: iomap: use attach/detach_page_private > > Since the new pair function is introduced, we can call them to clean the > code in iomap. > > Link: http://lkml.kernel.org/r/20200517214718.468-7-guoqing.jiang@cloud.ionos.com > Signed-off-by: Guoqing Jiang > Reviewed-by: Andrew Morton > Cc: Christoph Hellwig > Cc: "Darrick J. Wong" > Cc: Dave Chinner > Signed-off-by: Andrew Morton That looked reasonable enough... Reviewed-by: Darrick J. Wong --D > --- > > fs/iomap/buffered-io.c | 19 ++++--------------- > 1 file changed, 4 insertions(+), 15 deletions(-) > > --- a/fs/iomap/buffered-io.c~iomap-use-attach-detach_page_private > +++ a/fs/iomap/buffered-io.c > @@ -59,24 +59,19 @@ iomap_page_create(struct inode *inode, s > * migrate_page_move_mapping() assumes that pages with private data have > * their count elevated by 1. > */ > - get_page(page); > - set_page_private(page, (unsigned long)iop); > - SetPagePrivate(page); > + attach_page_private(page, iop); > return iop; > } > > static void > iomap_page_release(struct page *page) > { > - struct iomap_page *iop = to_iomap_page(page); > + struct iomap_page *iop = detach_page_private(page); > > if (!iop) > return; > WARN_ON_ONCE(atomic_read(&iop->read_count)); > WARN_ON_ONCE(atomic_read(&iop->write_count)); > - ClearPagePrivate(page); > - set_page_private(page, 0); > - put_page(page); > kfree(iop); > } > > @@ -526,14 +521,8 @@ iomap_migrate_page(struct address_space > if (ret != MIGRATEPAGE_SUCCESS) > return ret; > > - if (page_has_private(page)) { > - ClearPagePrivate(page); > - get_page(newpage); > - set_page_private(newpage, page_private(page)); > - set_page_private(page, 0); > - put_page(page); > - SetPagePrivate(newpage); > - } > + if (page_has_private(page)) > + attach_page_private(newpage, detach_page_private(page)); > > if (mode != MIGRATE_SYNC_NO_COPY) > migrate_page_copy(newpage, page); > _