From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95DC6C433DF for ; Tue, 2 Jun 2020 15:43:32 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B960207D8 for ; Tue, 2 Jun 2020 15:43:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=amazon.com header.i=@amazon.com header.b="LZ2nTXFn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B960207D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=quarantine dis=none) header.from=amazon.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DBCB980007; Tue, 2 Jun 2020 11:43:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D6C1C8E0006; Tue, 2 Jun 2020 11:43:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C32BD80007; Tue, 2 Jun 2020 11:43:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0170.hostedemail.com [216.40.44.170]) by kanga.kvack.org (Postfix) with ESMTP id A97D88E0006 for ; Tue, 2 Jun 2020 11:43:31 -0400 (EDT) Received: from smtpin15.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 68E731809B0CE for ; Tue, 2 Jun 2020 15:43:31 +0000 (UTC) X-FDA: 76884691422.15.wood26_5887d59d0123b Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin15.hostedemail.com (Postfix) with ESMTP id 15038180A3A8E for ; Tue, 2 Jun 2020 15:43:30 +0000 (UTC) X-HE-Tag: wood26_5887d59d0123b X-Filterd-Recvd-Size: 7168 Received: from smtp-fw-33001.amazon.com (smtp-fw-33001.amazon.com [207.171.190.10]) by imf42.hostedemail.com (Postfix) with ESMTP for ; Tue, 2 Jun 2020 15:43:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amazon.com; i=@amazon.com; q=dns/txt; s=amazon201209; t=1591112609; x=1622648609; h=from:to:cc:subject:date:message-id:in-reply-to: mime-version; bh=xo5iQNh2u9O4I7ZyRk3wLunxD/gOFcQ/CX+VsNZiQws=; b=LZ2nTXFnGGXi6qrkBWgfc0Vm+nmtOQZZD/kgoO559ppocc+Sv09vXmnO ZrxrNO2U+KntNViW4ue4JePiR36bEJk+/9WP0cOKkcmSFiaJsMQEWazM7 moa3q56ZneESDNQcM3NIgi0fGWwQmJ0nRf+Hj8+0KchObuNj1qm4BeR0d w=; IronPort-SDR: 2XGqGmkKWyxqG6NkZJ8CgeI5Dq3JIkhit5hVVFb0kIskPSovnTNXNe/s+8uaOszlPilgH3s4v3 +BcfWsBqjocg== X-IronPort-AV: E=Sophos;i="5.73,465,1583193600"; d="scan'208";a="47881129" Received: from sea32-co-svc-lb4-vlan2.sea.corp.amazon.com (HELO email-inbound-relay-1a-715bee71.us-east-1.amazon.com) ([10.47.23.34]) by smtp-border-fw-out-33001.sea14.amazon.com with ESMTP; 02 Jun 2020 15:43:10 +0000 Received: from EX13MTAUEA002.ant.amazon.com (iad55-ws-svc-p15-lb9-vlan2.iad.amazon.com [10.40.159.162]) by email-inbound-relay-1a-715bee71.us-east-1.amazon.com (Postfix) with ESMTPS id 01269A2242; Tue, 2 Jun 2020 15:43:07 +0000 (UTC) Received: from EX13D31EUA001.ant.amazon.com (10.43.165.15) by EX13MTAUEA002.ant.amazon.com (10.43.61.77) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 2 Jun 2020 15:43:07 +0000 Received: from u886c93fd17d25d.ant.amazon.com (10.43.161.82) by EX13D31EUA001.ant.amazon.com (10.43.165.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 2 Jun 2020 15:42:51 +0000 From: SeongJae Park To: Steven Rostedt CC: SeongJae Park , , "SeongJae Park" , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: Re: [PATCH v14 09/15] mm/damon: Add tracepoints Date: Tue, 2 Jun 2020 17:42:34 +0200 Message-ID: <20200602154234.26962-1-sjpark@amazon.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20200602113536.16e8e767@gandalf.local.home> (raw) MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.43.161.82] X-ClientProxiedBy: EX13D24UWA004.ant.amazon.com (10.43.160.233) To EX13D31EUA001.ant.amazon.com (10.43.165.15) X-Rspamd-Queue-Id: 15038180A3A8E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 2 Jun 2020 11:35:36 -0400 Steven Rostedt wrote: > On Tue, 2 Jun 2020 15:12:49 +0200 > SeongJae Park wrote: > > > From: SeongJae Park > > > > This commit adds a tracepoint for DAMON. It traces the monitoring > > results of each region for each aggregation interval. Using this, DAMON > > will be easily integrated with any tracepoints supporting tools such as > > perf. > > > > Signed-off-by: SeongJae Park > > Reviewed-by: Leonard Foerster > > --- > > include/trace/events/damon.h | 43 ++++++++++++++++++++++++++++++++++++ > > mm/damon.c | 5 +++++ > > 2 files changed, 48 insertions(+) > > create mode 100644 include/trace/events/damon.h > > > > diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h > > new file mode 100644 > > index 000000000000..22236642d366 > > --- /dev/null > > +++ b/include/trace/events/damon.h > > @@ -0,0 +1,43 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +#undef TRACE_SYSTEM > > +#define TRACE_SYSTEM damon > > + > > +#if !defined(_TRACE_DAMON_H) || defined(TRACE_HEADER_MULTI_READ) > > +#define _TRACE_DAMON_H > > + > > +#include > > +#include > > + > > +TRACE_EVENT(damon_aggregated, > > + > > + TP_PROTO(int pid, unsigned int nr_regions, > > + unsigned long vm_start, unsigned long vm_end, > > + unsigned int nr_accesses), > > + > > + TP_ARGS(pid, nr_regions, vm_start, vm_end, nr_accesses), > > + > > + TP_STRUCT__entry( > > + __field(int, pid) > > + __field(unsigned int, nr_regions) > > + __field(unsigned long, vm_start) > > + __field(unsigned long, vm_end) > > + __field(unsigned int, nr_accesses) > > + ), > > + > > + TP_fast_assign( > > + __entry->pid = pid; > > + __entry->nr_regions = nr_regions; > > + __entry->vm_start = vm_start; > > + __entry->vm_end = vm_end; > > + __entry->nr_accesses = nr_accesses; > > + ), > > + > > + TP_printk("pid=%d nr_regions=%u %lu-%lu: %u", __entry->pid, > > + __entry->nr_regions, __entry->vm_start, > > + __entry->vm_end, __entry->nr_accesses) > > +); > > + > > +#endif /* _TRACE_DAMON_H */ > > + > > +/* This part must be outside protection */ > > +#include > > diff --git a/mm/damon.c b/mm/damon.c > > index 6b0b8f21a6c6..af6f395fe06c 100644 > > --- a/mm/damon.c > > +++ b/mm/damon.c > > @@ -9,6 +9,8 @@ > > > > #define pr_fmt(fmt) "damon: " fmt > > > > +#define CREATE_TRACE_POINTS > > + > > #include > > #include > > #include > > @@ -20,6 +22,7 @@ > > #include > > #include > > #include > > +#include > > > > /* Minimal region size. Every damon_region is aligned by this. */ > > #define MIN_REGION PAGE_SIZE > > @@ -650,6 +653,8 @@ static void kdamond_reset_aggregated(struct damon_ctx *c) > > damon_write_rbuf(c, &r->vm_end, sizeof(r->vm_end)); > > damon_write_rbuf(c, &r->nr_accesses, > > sizeof(r->nr_accesses)); > > + trace_damon_aggregated(t->pid, nr, > > + r->vm_start, r->vm_end, r->nr_accesses); > > For a little better code, what about passing in t and r directly, and then > having the TP_fast_assign just do the dereferencing there? > > __entry->pid = t->pid; > __entry->vm_start = r->vm_start; > __entry->vm_end = r->vm_end; > __entry->nr_accesses = r->nr_accesses; > > It will produce better code at the trace point call (which is the important > part) and make the trace event a bit more flexible in the future, without > having to modify the call site. Good point, I will do so in the next spin! Thanks, SeongJae Park > > -- Steve > > > > r->nr_accesses = 0; > > } > > }