From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4FE15C433DF for ; Fri, 29 May 2020 20:31:43 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id CEBF8206F0 for ; Fri, 29 May 2020 20:31:42 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="PngoQ199" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEBF8206F0 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linux-foundation.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 3E4B28001A; Fri, 29 May 2020 16:31:42 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 36E4A80010; Fri, 29 May 2020 16:31:42 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 25D208001A; Fri, 29 May 2020 16:31:42 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0037.hostedemail.com [216.40.44.37]) by kanga.kvack.org (Postfix) with ESMTP id 0998D80010 for ; Fri, 29 May 2020 16:31:42 -0400 (EDT) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id B9B592C18 for ; Fri, 29 May 2020 20:31:41 +0000 (UTC) X-FDA: 76870902402.19.ear06_2bdb37f2eb424 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 9F6061ACC2B for ; Fri, 29 May 2020 20:31:41 +0000 (UTC) X-HE-Tag: ear06_2bdb37f2eb424 X-Filterd-Recvd-Size: 2821 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf36.hostedemail.com (Postfix) with ESMTP for ; Fri, 29 May 2020 20:31:41 +0000 (UTC) Received: from localhost.localdomain (c-73-231-172-41.hsd1.ca.comcast.net [73.231.172.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2FB54206F0; Fri, 29 May 2020 20:31:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590784300; bh=iwg5xpx340WIZx8dbdOVoA8fI2HWqbDeM/Uw/iUZQoc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=PngoQ1995ch2LtSeqE5PWXfJ+jQoI7D4q0+9TlJqVEjNsprMzFwTnjwzOWnNQurfb rYL4UNYU2LwujAQ1WlcS0k1GdsGMYMbW4V2gdtowF1VLHGueIlveqiQq3MIgYzZoRA rEOQnSykc9M6ZZn7U7DeIlZjqeg8oWPm6UXBv35U= Date: Fri, 29 May 2020 13:31:39 -0700 From: Andrew Morton To: Linus Torvalds Cc: mm-commits@vger.kernel.org, Linux-MM Subject: Re: incoming Message-Id: <20200529133139.c606b0e34255336d97af2b30@linux-foundation.org> In-Reply-To: References: <20200527222015.62ba8592af63dae12ab58ffe@linux-foundation.org> X-Mailer: Sylpheed 3.5.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 9F6061ACC2B X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 28 May 2020 13:10:18 -0700 Linus Torvalds wrote: > Hmm.. > > On Wed, May 27, 2020 at 10:20 PM Andrew Morton > wrote: > > > > fs/binfmt_elf.c | 2 +- > > include/asm-generic/topology.h | 2 +- > > include/linux/mm.h | 19 +++++++++++++++---- > > mm/khugepaged.c | 1 + > > mm/z3fold.c | 3 +++ > > 5 files changed, 21 insertions(+), 6 deletions(-) > > I wonder how you generate that diffstat. > > The change to simply doesn't match what you sent me. The > patch you sent me that changed mm.h had this: > > include/linux/mm.h | 15 +++++++++++++-- > 1 file changed, 13 insertions(+), 2 deletions(-) > > (note 15 lines changed: it's +13 and -2) but now suddenly in your > overall diffstat you have that > > include/linux/mm.h | 19 +++++++++++++++---- > > with +15/-4. > > So your diffstat simply doesn't match what you are sending. What's going on? > Bah. I got lazy (didn't want to interrupt an ongoing build) so I generated the diffstat prior to folding two patches into a single one. Evidently diffstat isn't as smart as I had assumed!