From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB589C433E0 for ; Fri, 29 May 2020 12:32:53 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 89BE6207F5 for ; Fri, 29 May 2020 12:32:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="P4YLwj/G" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 89BE6207F5 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 18B2B800C5; Fri, 29 May 2020 08:32:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 13C0080010; Fri, 29 May 2020 08:32:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 077F2800C5; Fri, 29 May 2020 08:32:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0193.hostedemail.com [216.40.44.193]) by kanga.kvack.org (Postfix) with ESMTP id DE87880010 for ; Fri, 29 May 2020 08:32:52 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 9B5C6824556B for ; Fri, 29 May 2020 12:32:52 +0000 (UTC) X-FDA: 76869695784.17.wheel04_5340e87868357 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin17.hostedemail.com (Postfix) with ESMTP id 7DB02180D0186 for ; Fri, 29 May 2020 12:32:52 +0000 (UTC) X-HE-Tag: wheel04_5340e87868357 X-Filterd-Recvd-Size: 2183 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf45.hostedemail.com (Postfix) with ESMTP for ; Fri, 29 May 2020 12:32:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=Content-Transfer-Encoding: MIME-Version:Message-Id:Date:Subject:Cc:To:From:Sender:Reply-To:Content-Type: Content-ID:Content-Description:In-Reply-To:References; bh=mJ8iy+UT8B6cQYYg2PEAw6wR1Yqbah8+8gx3cuWvIYo=; b=P4YLwj/GmcrI3iZ0Ad2OfwPITV 3dTuNLwkIi9f7ho2QWUavCEtpwf1M+gVSBiGfsi47EeMn3O1BOncnmxeAMvtdH19kuVn2oCGcc3sM Ku0fUx7KPvJvqUUZJn7LmZ2TXTI4VF9uuPWFWZStoeQNbJOKnfYB4FjzLNB1WgU40m1xHrLknKTU5 M1Zg7UCWYuWlOjkNDFbK8CwWVDz3LGXxrBLQsaQOjHO2jardisUgnjYdEPszu0RzWUkEOSGDITef4 61aS/ibuIoLilMCZ0K+BrPP2tCAVrxjO0gbewTVDiLxpFj6D5JAVFsPcKJceK7wq2IPBtgVPcCM4w dlFOLNWA==; Received: from willy by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jeeBu-0005P9-Qe; Fri, 29 May 2020 12:32:50 +0000 From: Matthew Wilcox To: Andrew Morton Cc: "Matthew Wilcox (Oracle)" , linux-mm@kvack.org Subject: [PATCH] mm: Remove misleading comment Date: Fri, 29 May 2020 05:32:43 -0700 Message-Id: <20200529123243.20640-1-willy@infradead.org> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 7DB02180D0186 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: "Matthew Wilcox (Oracle)" We no longer return 0 here and the comment doesn't tell us anything that we don't already know (SIGBUS is a pretty good indicator that things didn't work out). Signed-off-by: Matthew Wilcox (Oracle) --- mm/filemap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/mm/filemap.c b/mm/filemap.c index 23a051a7ef0f..fe079e9219d1 100644 --- a/mm/filemap.c +++ b/mm/filemap.c @@ -2566,7 +2566,6 @@ vm_fault_t filemap_fault(struct vm_fault *vmf) if (!error || error =3D=3D AOP_TRUNCATED_PAGE) goto retry_find; =20 - /* Things didn't work out. Return zero to tell the mm layer so. */ shrink_readahead_size_eio(ra); return VM_FAULT_SIGBUS; =20 --=20 2.26.2