From: Peter Zijlstra <peterz@infradead.org>
To: Axel Rasmussen <axelrasmussen@google.com>
Cc: "Steven Rostedt" <rostedt@goodmis.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
"David Rientjes" <rientjes@google.com>,
"Davidlohr Bueso" <dbueso@suse.de>,
"Ingo Molnar" <mingo@kernel.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Jerome Glisse" <jglisse@redhat.com>,
"Laurent Dufour" <ldufour@linux.ibm.com>,
"Liam R . Howlett" <Liam.Howlett@oracle.com>,
"Matthew Wilcox" <willy@infradead.org>,
"Michel Lespinasse" <walken@google.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Will Deacon" <will@kernel.org>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org,
"AKASHI Takahiro" <takahiro.akashi@linaro.org>,
"Aleksa Sarai" <cyphar@cyphar.com>,
"Alexander Potapenko" <glider@google.com>,
"Alexey Dobriyan" <adobriyan@gmail.com>,
"Al Viro" <viro@zeniv.linux.org.uk>,
"Andrei Vagin" <avagin@gmail.com>,
"Ard Biesheuvel" <ardb@kernel.org>,
"Brendan Higgins" <brendanhiggins@google.com>,
chenqiwu <chenqiwu@xiaomi.com>,
"Christian Brauner" <christian.brauner@ubuntu.com>,
"Christian Kellner" <christian@kellner.me>,
"Corentin Labbe" <clabbe@baylibre.com>,
"Daniel Jordan" <daniel.m.jordan@oracle.com>,
"Dan Williams" <dan.j.williams@intel.com>,
"David Gow" <davidgow@google.com>,
"David S. Miller" <davem@davemloft.net>,
"Dmitry V. Levin" <ldv@altlinux.org>,
"Eric W. Biederman" <ebiederm@xmission.com>,
"Eugene Syromiatnikov" <esyr@redhat.com>,
"Jamie Liu" <jamieliu@google.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"John Garry" <john.garry@huawei.com>,
"John Hubbard" <jhubbard@nvidia.com>,
"Jonathan Adams" <jwadams@google.com>,
"Junaid Shahid" <junaids@google.com>,
"Kees Cook" <keescook@chromium.org>,
"Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
"Konstantin Khlebnikov" <khlebnikov@yandex-team.ru>,
"Krzysztof Kozlowski" <krzk@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Masahiro Yamada" <yamada.masahiro@socionext.com>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Mathieu Desnoyers" <mathieu.desnoyers@efficios.com>,
"Michal Hocko" <mhocko@suse.com>,
"Mikhail Zaslonko" <zaslonko@linux.ibm.com>,
"Petr Mladek" <pmladek@suse.com>,
"Ralph Campbell" <rcampbell@nvidia.com>,
"Randy Dunlap" <rdunlap@infradead.org>,
"Roman Gushchin" <guro@fb.com>,
"Shakeel Butt" <shakeelb@google.com>,
"Tal Gilboa" <talgi@mellanox.com>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Uwe Kleine-König" <uwe@kleine-koenig.org>,
"Vincenzo Frascino" <vincenzo.frascino@arm.com>,
"Yang Shi" <yang.shi@linux.alibaba.com>,
"Yu Zhao" <yuzhao@google.com>, "Tom Zanussi" <zanussi@kernel.org>
Subject: Re: [PATCH v2 0/7] Add histogram measuring mmap_lock contention latency
Date: Fri, 29 May 2020 10:09:57 +0200 [thread overview]
Message-ID: <20200529080957.GI706495@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAJHvVchm6jaOk53h543mdagao7GT6nhBgReQcFkJKisHSmFN_g@mail.gmail.com>
On Thu, May 28, 2020 at 06:39:08PM -0700, Axel Rasmussen wrote:
> The use case we have in mind for this is to enable this instrumentation
> widely in Google's production fleet. Internally, we have a userspace thing
> which scrapes these metrics and publishes them such that we can look at
> aggregate metrics across our fleet. The thinking is that mechanisms like
> lockdep or getting histograms with e.g. BPF attached to the tracepoint
> introduces too much overhead for this to be viable. (Although, granted, I
> don't have benchmarks to prove this - if there's skepticism, I can produce
> such a thing - or prove myself wrong and rethink my approach. :) )
Whichever way around; I don't believe in special instrumentation like
this. We'll grow a thousand separate pieces of crap if we go this route.
Next on, someone will come and instrument yet another lock, with yet
another 1000 lines of gunk.
Why can't you kprobe the mmap_lock things and use ftrace histograms?
next prev parent reply other threads:[~2020-05-29 8:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-28 23:52 Axel Rasmussen
2020-05-29 0:24 ` Steven Rostedt
2020-05-29 1:39 ` Axel Rasmussen
2020-05-29 8:09 ` Peter Zijlstra [this message]
2020-05-29 15:03 ` Masami Hiramatsu
2020-05-29 22:38 ` Axel Rasmussen
2020-05-29 5:32 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200529080957.GI706495@hirez.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=ardb@kernel.org \
--cc=avagin@gmail.com \
--cc=axelrasmussen@google.com \
--cc=brendanhiggins@google.com \
--cc=chenqiwu@xiaomi.com \
--cc=christian.brauner@ubuntu.com \
--cc=christian@kellner.me \
--cc=clabbe@baylibre.com \
--cc=cyphar@cyphar.com \
--cc=dan.j.williams@intel.com \
--cc=daniel.m.jordan@oracle.com \
--cc=davem@davemloft.net \
--cc=davidgow@google.com \
--cc=dbueso@suse.de \
--cc=ebiederm@xmission.com \
--cc=esyr@redhat.com \
--cc=glider@google.com \
--cc=guro@fb.com \
--cc=jamieliu@google.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=john.garry@huawei.com \
--cc=junaids@google.com \
--cc=jwadams@google.com \
--cc=keescook@chromium.org \
--cc=khlebnikov@yandex-team.ru \
--cc=kirill.shutemov@linux.intel.com \
--cc=krzk@kernel.org \
--cc=ldufour@linux.ibm.com \
--cc=ldv@altlinux.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=mhocko@suse.com \
--cc=mingo@kernel.org \
--cc=mingo@redhat.com \
--cc=pmladek@suse.com \
--cc=rcampbell@nvidia.com \
--cc=rdunlap@infradead.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=shakeelb@google.com \
--cc=takahiro.akashi@linaro.org \
--cc=talgi@mellanox.com \
--cc=tglx@linutronix.de \
--cc=uwe@kleine-koenig.org \
--cc=vbabka@suse.cz \
--cc=vincenzo.frascino@arm.com \
--cc=viro@zeniv.linux.org.uk \
--cc=walken@google.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
--cc=yamada.masahiro@socionext.com \
--cc=yang.shi@linux.alibaba.com \
--cc=yuzhao@google.com \
--cc=zanussi@kernel.org \
--cc=zaslonko@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox