From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4EFECC433E0 for ; Wed, 27 May 2020 05:09:54 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 10A7D207E8 for ; Wed, 27 May 2020 05:09:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=infradead.org header.i=@infradead.org header.b="kvM2Iesn" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 10A7D207E8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=infradead.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A3C08800B6; Wed, 27 May 2020 01:09:53 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A11D680010; Wed, 27 May 2020 01:09:53 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 94E64800B6; Wed, 27 May 2020 01:09:53 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0121.hostedemail.com [216.40.44.121]) by kanga.kvack.org (Postfix) with ESMTP id 8A43B80010 for ; Wed, 27 May 2020 01:09:53 -0400 (EDT) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 57E00181AC9C6 for ; Wed, 27 May 2020 05:09:53 +0000 (UTC) X-FDA: 76861321866.10.wheel15_43063c226d4f Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin10.hostedemail.com (Postfix) with ESMTP id 3A01916A4AD for ; Wed, 27 May 2020 05:09:53 +0000 (UTC) X-HE-Tag: wheel15_43063c226d4f X-Filterd-Recvd-Size: 3596 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) by imf43.hostedemail.com (Postfix) with ESMTP for ; Wed, 27 May 2020 05:09:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=gHdtexCQGQRaatxx6IEb1gGC16jgjrLxhKEQOJ39uAQ=; b=kvM2IesnbKbAxu4uRnJqOjHn1U OkIhbK/PCHpdiGv/c7IzpFly3ueziTlwNiOXh/Y+3tpsSWg3LMrjVQ+LMnF+zEUZNmqNw6Kl5OnQC AFM8ATOv9heC9Nl0TZzyzRn1Cnh4gYHIngAMbimQN3Y4I0cpXIb2U3+NLOERIWMSbne/KPx/P0eB1 uR6Bp59hrw2Fe+P1qymKKKRIW6o6dnreDzWkemnh2tSCnLr4wc7/wD9Y8oXYIwiecGkPqEyWeNGTw 3dV84ae9v7pa1kHq0cQMpqc716FshZpviUGRx8aObBmHV3UBnQO0sia9QJcT5SegOXvISsfpGPctQ ZVrM3Gvg==; Received: from hch by bombadil.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdoJe-0000Ci-Ev; Wed, 27 May 2020 05:09:22 +0000 Date: Tue, 26 May 2020 22:09:22 -0700 From: Christoph Hellwig To: Dan Schatzberg Cc: Christoph Hellwig , Jens Axboe , Alexander Viro , Jan Kara , Amir Goldstein , Tejun Heo , Li Zefan , Johannes Weiner , Michal Hocko , Vladimir Davydov , Andrew Morton , Hugh Dickins , Roman Gushchin , Shakeel Butt , Chris Down , Yang Shi , Ingo Molnar , "Peter Zijlstra (Intel)" , Mathieu Desnoyers , "Kirill A. Shutemov" , Andrea Arcangeli , Thomas Gleixner , "open list:BLOCK LAYER" , open list , "open list:FILESYSTEMS (VFS and infrastructure)" , "open list:CONTROL GROUP (CGROUP)" , "open list:CONTROL GROUP - MEMORY RESOURCE CONTROLLER (MEMCG)" Subject: Re: [PATCH v5 0/4] Charge loop device i/o to issuing cgroup Message-ID: <20200527050922.GB31860@infradead.org> References: <20200428161355.6377-1-schatzberg.dan@gmail.com> <20200512132521.GA28700@dschatzberg-fedora-PC0Y6AEN.dhcp.thefacebook.com> <20200512133545.GA26535@infradead.org> <20200526142803.GA1061@dschatzberg-fedora-PC0Y6AEN.dhcp.thefacebook.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200526142803.GA1061@dschatzberg-fedora-PC0Y6AEN.dhcp.thefacebook.com> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html X-Rspamd-Queue-Id: 3A01916A4AD X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam02 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 26, 2020 at 10:28:03AM -0400, Dan Schatzberg wrote: > Will do - I'll split out the lock-use refactor into a separate > patch. Do you have particular concerns about re-using the existing > spinlock? Its existing use is not contended so I didn't see any harm > in extending its use. I'll add this justification to the commit > message as well, but I'm tempted to leave the re-use as is instead of > creating a new lock. Please don't share a lock for entirely separate critical sections that are used from different contexts.