From: Lukas Bulwahn <lukas.bulwahn@gmail.com>
To: Michel Lespinasse <walken@google.com>,
Vlastimil Babka <vbabka@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
linux-mm <linux-mm@kvack.org>
Cc: linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
Lukas Bulwahn <lukas.bulwahn@gmail.com>
Subject: [PATCH] doc: filesystems: format tables in locking properly
Date: Tue, 26 May 2020 08:41:59 +0200 [thread overview]
Message-ID: <20200526064159.11361-1-lukas.bulwahn@gmail.com> (raw)
Commit 28df3d1539de ("nfsd: clients don't need to break their own
delegations") introduced lm_breaker_owns_lease and documented that in the
according table. Commit 43dbd0e7e62b ("mmap locking API: convert mmap_sem
comments") renamed mmap_sem to mmap_lock in another table. Both changes
created a table entry longer than the content before, but did not adjust
the tables. Hence, make htmldocs warns about malformed tables.
Adjust the tables to address the warning.
Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
---
Michel, Vlastimil, please ack this patch.
Andrew, please pick this minor doc fix patch into your -next tree, where
patch "mmap locking API: convert mmap_sem comments" has been applied.
Documentation/filesystems/locking.rst | 24 ++++++++++++------------
1 file changed, 12 insertions(+), 12 deletions(-)
diff --git a/Documentation/filesystems/locking.rst b/Documentation/filesystems/locking.rst
index 318605de83f3..faf7f4abd54d 100644
--- a/Documentation/filesystems/locking.rst
+++ b/Documentation/filesystems/locking.rst
@@ -433,15 +433,15 @@ prototypes::
locking rules:
-========== ============= ================= =========
-ops inode->i_lock blocked_lock_lock may block
-========== ============= ================= =========
-lm_notify: yes yes no
-lm_grant: no no no
-lm_break: yes no no
-lm_change yes no no
-lm_breaker_owns_lease: no no no
-========== ============= ================= =========
+====================== ============= ================= =========
+ops inode->i_lock blocked_lock_lock may block
+====================== ============= ================= =========
+lm_notify: yes yes no
+lm_grant: no no no
+lm_break: yes no no
+lm_change yes no no
+lm_breaker_owns_lease: no no no
+====================== ============= ================= =========
buffer_head
===========
@@ -616,9 +616,9 @@ prototypes::
locking rules:
-============= ======== ===========================
+============= ========= ===========================
ops mmap_lock PageLocked(page)
-============= ======== ===========================
+============= ========= ===========================
open: yes
close: yes
fault: yes can return with page locked
@@ -626,7 +626,7 @@ map_pages: yes
page_mkwrite: yes can return with page locked
pfn_mkwrite: yes
access: yes
-============= ======== ===========================
+============= ========= ===========================
->fault() is called when a previously not present pte is about
to be faulted in. The filesystem must find and return the page associated
--
2.17.1
reply other threads:[~2020-05-26 6:42 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200526064159.11361-1-lukas.bulwahn@gmail.com \
--to=lukas.bulwahn@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox