From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A840C433E1 for ; Mon, 25 May 2020 16:05:55 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 062FE2071A for ; Mon, 25 May 2020 16:05:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 062FE2071A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.ibm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id A487180054; Mon, 25 May 2020 12:05:54 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F8B88E0008; Mon, 25 May 2020 12:05:54 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E6E280054; Mon, 25 May 2020 12:05:54 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0030.hostedemail.com [216.40.44.30]) by kanga.kvack.org (Postfix) with ESMTP id 734BD8E0008 for ; Mon, 25 May 2020 12:05:54 -0400 (EDT) Received: from smtpin06.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 36060D38 for ; Mon, 25 May 2020 16:05:54 +0000 (UTC) X-FDA: 76855717428.06.front90_6dae35f219012 X-HE-Tag: front90_6dae35f219012 X-Filterd-Recvd-Size: 4151 Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 May 2020 16:05:53 +0000 (UTC) Received: from pps.filterd (m0098394.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 04PG2rPx063620 for ; Mon, 25 May 2020 12:05:52 -0400 Received: from pps.reinject (localhost [127.0.0.1]) by mx0a-001b2d01.pphosted.com with ESMTP id 3170b78fja-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 25 May 2020 12:05:52 -0400 Received: from m0098394.ppops.net (m0098394.ppops.net [127.0.0.1]) by pps.reinject (8.16.0.36/8.16.0.36) with SMTP id 04PG3xst067883 for ; Mon, 25 May 2020 12:05:51 -0400 Received: from ppma01fra.de.ibm.com (46.49.7a9f.ip4.static.sl-reverse.com [159.122.73.70]) by mx0a-001b2d01.pphosted.com with ESMTP id 3170b78fhm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 May 2020 12:05:51 -0400 Received: from pps.filterd (ppma01fra.de.ibm.com [127.0.0.1]) by ppma01fra.de.ibm.com (8.16.0.42/8.16.0.42) with SMTP id 04PG5OhR030359; Mon, 25 May 2020 16:05:49 GMT Received: from b06cxnps3074.portsmouth.uk.ibm.com (d06relay09.portsmouth.uk.ibm.com [9.149.109.194]) by ppma01fra.de.ibm.com with ESMTP id 316uf8hrqg-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 25 May 2020 16:05:49 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06cxnps3074.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 04PG5lOf27197536 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 25 May 2020 16:05:47 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 48A7C4C046; Mon, 25 May 2020 16:05:47 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id C9EA14C040; Mon, 25 May 2020 16:05:46 +0000 (GMT) Received: from linux.ibm.com (unknown [9.148.200.96]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTPS; Mon, 25 May 2020 16:05:46 +0000 (GMT) Date: Mon, 25 May 2020 19:05:44 +0300 From: Mike Rapoport To: DaeRoLee Cc: skseofh@naver.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/memblock:Do not retry a range that has already been checked Message-ID: <20200525160544.GE13212@linux.ibm.com> References: <20200524141640.GA10017@roro-Lenovo-Y520-15IKBN> <20200524174922.GB1515425@linux.ibm.com> <20200525103458.GA13212@linux.ibm.com> <20200525154838.GA14725@roro-Lenovo-Y520-15IKBN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200525154838.GA14725@roro-Lenovo-Y520-15IKBN> X-TM-AS-GCONF: 00 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.216,18.0.687 definitions=2020-05-25_09:2020-05-25,2020-05-25 signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 cotscore=-2147483648 malwarescore=0 priorityscore=1501 clxscore=1015 impostorscore=0 mlxlogscore=666 spamscore=0 adultscore=0 mlxscore=0 phishscore=0 bulkscore=0 suspectscore=5 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2004280000 definitions=main-2005250126 X-Bogosity: Ham, tests=bogofilter, spamicity=0.016941, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, May 26, 2020 at 12:48:38AM +0900, DaeRoLee wrote: > Sorry for the invalid mail format.. > > Actually, I didn't experience a real issue. > > On second thought, I totally agree with you. > > Could you explain "size" in "min_addr + size -1"? > Does this mean memblock size? "size" is the allocation size. It could be that there is no free slot above min_addr, but there is free memory slightly below it. If you ceil the second search by min_addr, the allocation must start below min_addr - size, rather than below min_addr. -- Sincerely yours, Mike.