From: Mike Rapoport <rppt@linux.ibm.com>
To: DaeRoLee <skseofh@gmail.com>
Cc: skseofh@naver.com, linux-mm@kvack.org
Subject: Re: [PATCH] mm/memblock:Do not retry a range that has already been checked
Date: Mon, 25 May 2020 19:05:44 +0300 [thread overview]
Message-ID: <20200525160544.GE13212@linux.ibm.com> (raw)
In-Reply-To: <20200525154838.GA14725@roro-Lenovo-Y520-15IKBN>
On Tue, May 26, 2020 at 12:48:38AM +0900, DaeRoLee wrote:
> Sorry for the invalid mail format..
>
> Actually, I didn't experience a real issue.
>
> On second thought, I totally agree with you.
>
> Could you explain "size" in "min_addr + size -1"?
> Does this mean memblock size?
"size" is the allocation size. It could be that there is no free slot
above min_addr, but there is free memory slightly below it. If you ceil
the second search by min_addr, the allocation must start below min_addr
- size, rather than below min_addr.
--
Sincerely yours,
Mike.
prev parent reply other threads:[~2020-05-25 16:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200524141640.GA10017@roro-Lenovo-Y520-15IKBN>
2020-05-24 17:49 ` Mike Rapoport
[not found] ` <CAATEi5n-W-ZiurGvaF_jNUnxNE1Y_XbdSVy7sN_BH4JPURQL1Q@mail.gmail.com>
[not found] ` <20200525103458.GA13212@linux.ibm.com>
[not found] ` <20200525154838.GA14725@roro-Lenovo-Y520-15IKBN>
2020-05-25 16:05 ` Mike Rapoport [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200525160544.GE13212@linux.ibm.com \
--to=rppt@linux.ibm.com \
--cc=linux-mm@kvack.org \
--cc=skseofh@gmail.com \
--cc=skseofh@naver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox