From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67230C433E2 for ; Fri, 22 May 2020 17:22:56 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2B9D9206D5 for ; Fri, 22 May 2020 17:22:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QdOKlWAU" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2B9D9206D5 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C11A280008; Fri, 22 May 2020 13:22:55 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BC22A80007; Fri, 22 May 2020 13:22:55 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AB0F180008; Fri, 22 May 2020 13:22:55 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0120.hostedemail.com [216.40.44.120]) by kanga.kvack.org (Postfix) with ESMTP id 9541380007 for ; Fri, 22 May 2020 13:22:55 -0400 (EDT) Received: from smtpin29.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 51685499603 for ; Fri, 22 May 2020 17:22:55 +0000 (UTC) X-FDA: 76845025110.29.bear35_1975fa4914160 X-HE-Tag: bear35_1975fa4914160 X-Filterd-Recvd-Size: 4343 Received: from mail-pg1-f195.google.com (mail-pg1-f195.google.com [209.85.215.195]) by imf47.hostedemail.com (Postfix) with ESMTP for ; Fri, 22 May 2020 17:22:54 +0000 (UTC) Received: by mail-pg1-f195.google.com with SMTP id p21so5264339pgm.13 for ; Fri, 22 May 2020 10:22:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=amaxCECevOSXJrGQyIuXx97hyD0UaNdLUI7ilZbNErE=; b=QdOKlWAUfaOgmRv2+ys3+AI8VRaQjQGwiQE2Q9ixqsSc47+pg8ot2k8eV9uY4lzp++ i0TuH4yEnQR5YabGAbnFYlP73coOX4eGfIXprx+hq/fwlynG47mBziM1nHeMmGvyGC/p xuiDofpqRF65/vevf6CbCee7998FCjaJgYfFs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=amaxCECevOSXJrGQyIuXx97hyD0UaNdLUI7ilZbNErE=; b=naAjvxK+efL8+KvRLCPnM6uk8DfIHas9VTFN1v6t4JahueUUP1mE+I0CzDAMhdMHM/ zJ2JgPDgTKILrJ/xlX5Ojj6zTxUMQxLVVKQBEpWTVU72C4GgZkmSLCGJKvnpoEdUYEzj C2ocjtQvGBtJd4hGl1r6NOih1m7Vv9e9LudKqWWEXCHxQNEKEDq1aIQJ74I+JGynpN1v z6iwIWyLNZNdC7nxFZVoU3kQeBFC+6J/bobCEcR2bQS+H4txfzTTBnIaz1op+Ru3xBpU AF+YrShK3Z3rbkydQu6gwxI1AP0DsZ6aVvk/o8iuu4Y67DUhRqjjXWLBzkUN74QpaMpe t0AA== X-Gm-Message-State: AOAM533slTg0ih2qP7u4YmCmIe1XtK8lFUgnNn48qqD7+rBiY0NztYmP 1U22PZyfgvBySVd6mwihQylGBQ== X-Google-Smtp-Source: ABdhPJxp9FF04TnejNRz/NvrR22fKHIQ7m8bWd6qeiuqYrLZnucmLNFQPYrNAd8AJZHV+du2CRuRLQ== X-Received: by 2002:aa7:9ab6:: with SMTP id x22mr4840028pfi.136.1590168173772; Fri, 22 May 2020 10:22:53 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id d22sm6676581pgh.64.2020.05.22.10.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 22 May 2020 10:22:52 -0700 (PDT) Date: Fri, 22 May 2020 10:22:51 -0700 From: Kees Cook To: Peter Zijlstra Cc: Yu-cheng Yu , x86@kernel.org, "H. Peter Anvin" , Thomas Gleixner , Ingo Molnar , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-api@vger.kernel.org, Arnd Bergmann , Andy Lutomirski , Balbir Singh , Borislav Petkov , Cyrill Gorcunov , Dave Hansen , Eugene Syromiatnikov , Florian Weimer , "H.J. Lu" , Jann Horn , Jonathan Corbet , Mike Kravetz , Nadav Amit , Oleg Nesterov , Pavel Machek , Randy Dunlap , "Ravi V. Shankar" , Vedvyas Shanbhogue , Dave Martin , Weijiang Yang Subject: Re: [RFC PATCH 5/5] selftest/x86: Add CET quick test Message-ID: <202005221020.B578B8C6@keescook> References: <20200521211720.20236-1-yu-cheng.yu@intel.com> <20200521211720.20236-6-yu-cheng.yu@intel.com> <20200522092848.GJ325280@hirez.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200522092848.GJ325280@hirez.programming.kicks-ass.net> X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, May 22, 2020 at 11:28:48AM +0200, Peter Zijlstra wrote: > Get asm/asm.h into userspace and then write something like: Yeah, selftests is going to start suffering from the same "tools/ header duplication" problem. I've also had cases (see the logic in the Makefile in selftests/x86) where selftests is duplicating existing Kconfig and Makefile logic ("can I build this way?") But yes, I think getting a copy of asm.h would be nice here. I don't think the WRITE_ONCE() is needed in this particular case. Hmm. -- Kees Cook