From: Matthew Wilcox <willy@infradead.org>
To: John Hubbard <jhubbard@nvidia.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
jgg@ziepe.ca, Liam.Howlett@oracle.com,
daniel.m.jordan@oracle.com, dave@stgolabs.net, hughd@google.com,
jglisse@redhat.com, ldufour@linux.ibm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
peterz@infradead.org, rientjes@google.com, vbabka@suse.cz,
walken@google.com, yinghan@google.com
Subject: Re: [PATCH] mm/gup: might_lock_read(mmap_sem) in get_user_pages_fast()
Date: Thu, 21 May 2020 18:16:00 -0700 [thread overview]
Message-ID: <20200522011600.GJ28818@bombadil.infradead.org> (raw)
In-Reply-To: <20200522010443.1290485-1-jhubbard@nvidia.com>
On Thu, May 21, 2020 at 06:04:43PM -0700, John Hubbard wrote:
> Instead of scattering these assertions across the drivers,
> do this assertion inside the core of get_user_pages_fast*()
> functions. That also includes pin_user_pages_fast*()
> routines.
>
> Add a might_lock_read(mmap_sem) call to internal_get_user_pages_fast().
>
> Suggested-by: Matthew Wilcox <willy@infradead.org>
Yup, this is exactly what I meant. Feel free to transform this into
an Acked-by: or Reviewed-by: if that's the appropriate tag.
Thanks, John!
prev parent reply other threads:[~2020-05-22 1:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 1:04 John Hubbard
2020-05-22 1:16 ` Matthew Wilcox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522011600.GJ28818@bombadil.infradead.org \
--to=willy@infradead.org \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=daniel.m.jordan@oracle.com \
--cc=dave@stgolabs.net \
--cc=hughd@google.com \
--cc=jgg@ziepe.ca \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=ldufour@linux.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=vbabka@suse.cz \
--cc=walken@google.com \
--cc=yinghan@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox